Re: [PATCH] Revert part of "ASoC: tegra: Convert to managed resources"
On Tue, Aug 18, 2015 at 8:56 PM, Vaishali Thakkar
wrote:
> Revert the problematic part of commit 470805eb9f31 ("ASoC: tegra:
> Convert to managed resources"). Before this commit, PM cleanup was
> performed after the component was unregistered. But returning
> directly will skip PM cleanup. So, to be on safe side it is better
> to use snd_soc_register_component instead of
> devm_snd_soc_register_component.
>
> Signed-off-by: Vaishali Thakkar
I'm probably late for the party, but FWIW:
Reviewed-by: Alexandre Courbot
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Revert part of ASoC: tegra: Convert to managed resources
On Tue, Aug 18, 2015 at 8:56 PM, Vaishali Thakkar vthakkar1...@gmail.com wrote: Revert the problematic part of commit 470805eb9f31 (ASoC: tegra: Convert to managed resources). Before this commit, PM cleanup was performed after the component was unregistered. But returning directly will skip PM cleanup. So, to be on safe side it is better to use snd_soc_register_component instead of devm_snd_soc_register_component. Signed-off-by: Vaishali Thakkar vthakkar1...@gmail.com I'm probably late for the party, but FWIW: Reviewed-by: Alexandre Courbot acour...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Revert part of "ASoC: tegra: Convert to managed resources"
On Tue, Aug 18, 2015 at 05:26:45PM +0530, Vaishali Thakkar wrote:
> Revert the problematic part of commit 470805eb9f31 ("ASoC: tegra:
> Convert to managed resources"). Before this commit, PM cleanup was
Please use subject lines matching the style for the subsystem on
patches.
signature.asc
Description: Digital signature
[PATCH] Revert part of "ASoC: tegra: Convert to managed resources"
Revert the problematic part of commit 470805eb9f31 ("ASoC: tegra:
Convert to managed resources"). Before this commit, PM cleanup was
performed after the component was unregistered. But returning
directly will skip PM cleanup. So, to be on safe side it is better
to use snd_soc_register_component instead of
devm_snd_soc_register_component.
Signed-off-by: Vaishali Thakkar
---
sound/soc/tegra/tegra20_spdif.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/sound/soc/tegra/tegra20_spdif.c b/sound/soc/tegra/tegra20_spdif.c
index a814da0..66237bc 100644
--- a/sound/soc/tegra/tegra20_spdif.c
+++ b/sound/soc/tegra/tegra20_spdif.c
@@ -329,9 +329,8 @@ static int tegra20_spdif_platform_probe(struct
platform_device *pdev)
goto err_pm_disable;
}
- ret = devm_snd_soc_register_component(>dev,
- _spdif_component,
- _spdif_dai, 1);
+ ret = snd_soc_register_component(>dev, _spdif_component,
+_spdif_dai, 1);
if (ret) {
dev_err(>dev, "Could not register DAI: %d\n", ret);
ret = -ENOMEM;
@@ -341,11 +340,13 @@ static int tegra20_spdif_platform_probe(struct
platform_device *pdev)
ret = tegra_pcm_platform_register(>dev);
if (ret) {
dev_err(>dev, "Could not register PCM: %d\n", ret);
- return ret;
+ goto err_unregister_component;
}
return 0;
+err_unregister_component:
+ snd_soc_unregister_component(>dev);
err_suspend:
if (!pm_runtime_status_suspended(>dev))
tegra20_spdif_runtime_suspend(>dev);
@@ -364,6 +365,7 @@ static int tegra20_spdif_platform_remove(struct
platform_device *pdev)
tegra20_spdif_runtime_suspend(>dev);
tegra_pcm_platform_unregister(>dev);
+ snd_soc_unregister_component(>dev);
return 0;
}
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Revert part of ASoC: tegra: Convert to managed resources
Revert the problematic part of commit 470805eb9f31 (ASoC: tegra:
Convert to managed resources). Before this commit, PM cleanup was
performed after the component was unregistered. But returning
directly will skip PM cleanup. So, to be on safe side it is better
to use snd_soc_register_component instead of
devm_snd_soc_register_component.
Signed-off-by: Vaishali Thakkar vthakkar1...@gmail.com
---
sound/soc/tegra/tegra20_spdif.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/sound/soc/tegra/tegra20_spdif.c b/sound/soc/tegra/tegra20_spdif.c
index a814da0..66237bc 100644
--- a/sound/soc/tegra/tegra20_spdif.c
+++ b/sound/soc/tegra/tegra20_spdif.c
@@ -329,9 +329,8 @@ static int tegra20_spdif_platform_probe(struct
platform_device *pdev)
goto err_pm_disable;
}
- ret = devm_snd_soc_register_component(pdev-dev,
- tegra20_spdif_component,
- tegra20_spdif_dai, 1);
+ ret = snd_soc_register_component(pdev-dev, tegra20_spdif_component,
+tegra20_spdif_dai, 1);
if (ret) {
dev_err(pdev-dev, Could not register DAI: %d\n, ret);
ret = -ENOMEM;
@@ -341,11 +340,13 @@ static int tegra20_spdif_platform_probe(struct
platform_device *pdev)
ret = tegra_pcm_platform_register(pdev-dev);
if (ret) {
dev_err(pdev-dev, Could not register PCM: %d\n, ret);
- return ret;
+ goto err_unregister_component;
}
return 0;
+err_unregister_component:
+ snd_soc_unregister_component(pdev-dev);
err_suspend:
if (!pm_runtime_status_suspended(pdev-dev))
tegra20_spdif_runtime_suspend(pdev-dev);
@@ -364,6 +365,7 @@ static int tegra20_spdif_platform_remove(struct
platform_device *pdev)
tegra20_spdif_runtime_suspend(pdev-dev);
tegra_pcm_platform_unregister(pdev-dev);
+ snd_soc_unregister_component(pdev-dev);
return 0;
}
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Revert part of ASoC: tegra: Convert to managed resources
On Tue, Aug 18, 2015 at 05:26:45PM +0530, Vaishali Thakkar wrote: Revert the problematic part of commit 470805eb9f31 (ASoC: tegra: Convert to managed resources). Before this commit, PM cleanup was Please use subject lines matching the style for the subsystem on patches. signature.asc Description: Digital signature
