Re: [PATCH] SPARC64: check for possible NULL pointer dereference
From: Cyrill Gorcunov <[EMAIL PROTECTED]> Date: Tue, 20 Nov 2007 20:28:33 +0300 > From: Cyrill Gorcunov <[EMAIL PROTECTED]> > > This patch adds checking for possible NULL pointer dereference > if of_find_property() failed. > > Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] SPARC64: check for possible NULL pointer dereference
From: Cyrill Gorcunov <[EMAIL PROTECTED]>
This patch adds checking for possible NULL pointer dereference
if of_find_property() failed.
Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]>
---
I'm not sure about the message being printed in worst case.
Check please.
arch/sparc64/kernel/pci_sun4v.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/sparc64/kernel/pci_sun4v.c b/arch/sparc64/kernel/pci_sun4v.c
index 8c4875b..e587a37 100644
--- a/arch/sparc64/kernel/pci_sun4v.c
+++ b/arch/sparc64/kernel/pci_sun4v.c
@@ -1022,6 +1022,10 @@ void __init sun4v_pci_init(struct device_node *dp, char
*model_name)
}
prop = of_find_property(dp, "reg", NULL);
+ if (!prop) {
+ prom_printf("SUN4V_PCI: Could not find config registers\n");
+ prom_halt();
+ }
regs = prop->value;
devhandle = (regs->phys_addr >> 32UL) & 0x0fff;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] SPARC64: check for possible NULL pointer dereference
From: Cyrill Gorcunov [EMAIL PROTECTED]
This patch adds checking for possible NULL pointer dereference
if of_find_property() failed.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
I'm not sure about the message being printed in worst case.
Check please.
arch/sparc64/kernel/pci_sun4v.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/sparc64/kernel/pci_sun4v.c b/arch/sparc64/kernel/pci_sun4v.c
index 8c4875b..e587a37 100644
--- a/arch/sparc64/kernel/pci_sun4v.c
+++ b/arch/sparc64/kernel/pci_sun4v.c
@@ -1022,6 +1022,10 @@ void __init sun4v_pci_init(struct device_node *dp, char
*model_name)
}
prop = of_find_property(dp, reg, NULL);
+ if (!prop) {
+ prom_printf(SUN4V_PCI: Could not find config registers\n);
+ prom_halt();
+ }
regs = prop-value;
devhandle = (regs-phys_addr 32UL) 0x0fff;
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] SPARC64: check for possible NULL pointer dereference
From: Cyrill Gorcunov [EMAIL PROTECTED] Date: Tue, 20 Nov 2007 20:28:33 +0300 From: Cyrill Gorcunov [EMAIL PROTECTED] This patch adds checking for possible NULL pointer dereference if of_find_property() failed. Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED] Applied, thanks. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
