Re: [PATCH] Staging: comedi: drivers: fixed a coding style issue.
Patches need to be sent inline. Perhaps use git send-email.
On Fri, Apr 25, 2014 at 01:06:44AM -0300, Nicolas Del Piano wrote:
>
> >From 38e0d5778bd97062115e7d8a8ca40d18f3d71707 Mon Sep 17 00:00:00 2001
> From: Nicolas Del Piano
> Date: Thu, 24 Apr 2014 18:46:49 -0300
> Subject: [PATCH] Staging: comedi: drivers: fixed a missing blank line after a
> declaration coding style.
>
We don't want these headers in the patch.
> Fixed a coding style issue.
>
> Signed-off-by: Nicolas Del Piano
> ---
> drivers/staging/comedi/drivers.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/comedi/drivers.c
> b/drivers/staging/comedi/drivers.c
> index cb5d214..71569bc 100644
> --- a/drivers/staging/comedi/drivers.c
> +++ b/drivers/staging/comedi/drivers.c
> @@ -439,6 +439,7 @@ static void *comedi_recognize(struct comedi_driver *driv,
> const char *name)
> static void comedi_report_boards(struct comedi_driver *driv)
> {
> unsigned int i;
> +
> const char *const *name_ptr;
The original code was correct. This is a bug in checkpatch.pl. The
missing line check should count any lines starting with "const" or
"static" as declarations.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: comedi: drivers: fixed a coding style issue.
Patches need to be sent inline. Perhaps use git send-email.
On Fri, Apr 25, 2014 at 01:06:44AM -0300, Nicolas Del Piano wrote:
From 38e0d5778bd97062115e7d8a8ca40d18f3d71707 Mon Sep 17 00:00:00 2001
From: Nicolas Del Piano ndel...@gmail.com
Date: Thu, 24 Apr 2014 18:46:49 -0300
Subject: [PATCH] Staging: comedi: drivers: fixed a missing blank line after a
declaration coding style.
We don't want these headers in the patch.
Fixed a coding style issue.
Signed-off-by: Nicolas Del Piano ndel...@gmail.com
---
drivers/staging/comedi/drivers.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/drivers.c
b/drivers/staging/comedi/drivers.c
index cb5d214..71569bc 100644
--- a/drivers/staging/comedi/drivers.c
+++ b/drivers/staging/comedi/drivers.c
@@ -439,6 +439,7 @@ static void *comedi_recognize(struct comedi_driver *driv,
const char *name)
static void comedi_report_boards(struct comedi_driver *driv)
{
unsigned int i;
+
const char *const *name_ptr;
The original code was correct. This is a bug in checkpatch.pl. The
missing line check should count any lines starting with const or
static as declarations.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: comedi: drivers: fixed a coding style issue.
>From 38e0d5778bd97062115e7d8a8ca40d18f3d71707 Mon Sep 17 00:00:00 2001
From: Nicolas Del Piano
Date: Thu, 24 Apr 2014 18:46:49 -0300
Subject: [PATCH] Staging: comedi: drivers: fixed a missing blank line after a
declaration coding style.
Fixed a coding style issue.
Signed-off-by: Nicolas Del Piano
---
drivers/staging/comedi/drivers.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index cb5d214..71569bc 100644
--- a/drivers/staging/comedi/drivers.c
+++ b/drivers/staging/comedi/drivers.c
@@ -439,6 +439,7 @@ static void *comedi_recognize(struct comedi_driver *driv, const char *name)
static void comedi_report_boards(struct comedi_driver *driv)
{
unsigned int i;
+
const char *const *name_ptr;
pr_info("comedi: valid board names for %s driver are:\n",
--
1.7.9.5
[PATCH] Staging: comedi: drivers: fixed a coding style issue.
From 38e0d5778bd97062115e7d8a8ca40d18f3d71707 Mon Sep 17 00:00:00 2001
From: Nicolas Del Piano ndel...@gmail.com
Date: Thu, 24 Apr 2014 18:46:49 -0300
Subject: [PATCH] Staging: comedi: drivers: fixed a missing blank line after a
declaration coding style.
Fixed a coding style issue.
Signed-off-by: Nicolas Del Piano ndel...@gmail.com
---
drivers/staging/comedi/drivers.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index cb5d214..71569bc 100644
--- a/drivers/staging/comedi/drivers.c
+++ b/drivers/staging/comedi/drivers.c
@@ -439,6 +439,7 @@ static void *comedi_recognize(struct comedi_driver *driv, const char *name)
static void comedi_report_boards(struct comedi_driver *driv)
{
unsigned int i;
+
const char *const *name_ptr;
pr_info(comedi: valid board names for %s driver are:\n,
--
1.7.9.5
