Re: [PATCH] Staging: rtl8723bs: os_de: if-else coding style issues

[Dan Carpenter]

On Fri, May 15, 2020 at 01:49:30PM +0100, John Oldman wrote:
> @@ -1167,9 +1166,8 @@ void rtw_dev_unload(struct adapter *padapter)
>   DBG_871X_LEVEL(_drv_always_, "%s: driver in 
> IPS-FWLPS\n", __func__);
>   pdbgpriv->dbg_dev_unload_inIPS_cnt++;
>   LeaveAllPowerSaveMode(padapter);
> - } else {
> + } else
>   DBG_871X_LEVEL(_drv_always_, "%s: driver not in IPS\n", 
> __func__);
> - }

You didn't run checkpatch on this patch.  The rule is that if one side
of the if else statement has curly braces then all sides get curly
braces even if they're just one line long.

regards,
dan carpenter

[PATCH] Staging: rtl8723bs: os_de: if-else coding style issues

[John Oldman]

Coding style issues:
This patch clears the checkpatch.pl "braces {} are not necessary for
single statement blocks" and "else_should_follow_close_brace"
warnings."

Signed-off-by: John Oldman 
---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 49 +++--
 1 file changed, 17 insertions(+), 32 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c 
b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index d29f59bbb613..479049cb16e5 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -1057,8 +1057,7 @@ static int pm_netdev_open(struct net_device *pnetdev, u8 
bnormal)
status = _netdev_open(pnetdev);

mutex_unlock(&(adapter_to_dvobj(padapter)->hw_init_mutex));
}
-   }
-   else
+   } else
status =  (_SUCCESS == ips_netdrv_open(padapter)) ? (0) : (-1);
 
return status;
@@ -1167,9 +1166,8 @@ void rtw_dev_unload(struct adapter *padapter)
DBG_871X_LEVEL(_drv_always_, "%s: driver in 
IPS-FWLPS\n", __func__);
pdbgpriv->dbg_dev_unload_inIPS_cnt++;
LeaveAllPowerSaveMode(padapter);
-   } else {
+   } else
DBG_871X_LEVEL(_drv_always_, "%s: driver not in IPS\n", 
__func__);
-   }
 
if (padapter->bSurpriseRemoved == false) {
hal_btcoex_IpsNotify(padapter, pwrctl->ips_mode_req);
@@ -1177,8 +1175,7 @@ void rtw_dev_unload(struct adapter *padapter)
if (pwrctl->bSupportRemoteWakeup == true &&
pwrctl->wowlan_mode == true) {
DBG_871X_LEVEL(_drv_always_, "%s 
bSupportRemoteWakeup ==true  do not run rtw_hal_deinit()\n", __func__);
-   }
-   else
+   } else
 #endif
{
/* amy modify 20120221 for power seq is 
different between driver open and ips */
@@ -1192,8 +1189,7 @@ void rtw_dev_unload(struct adapter *padapter)
padapter->bup = false;
 
DBG_871X("<=== %s\n", __func__);
-   }
-   else {
+   } else {
RT_TRACE(_module_hci_intfs_c_, _drv_notice_, ("%s: bup 
==false\n", __func__));
DBG_871X("%s: bup ==false\n", __func__);
}
@@ -1223,10 +1219,8 @@ static int rtw_suspend_free_assoc_resource(struct 
adapter *padapter)
rtw_disassoc_cmd(padapter, 0, false);
/* s2-2.  indicate disconnect to os */
rtw_indicate_disconnect(padapter);
-   }
-   else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) {
+   } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE))
rtw_sta_flush(padapter);
-   }
 
/* s2-3. */
rtw_free_assoc_resources(padapter, 1);
@@ -1264,15 +1258,15 @@ void rtw_suspend_wow(struct adapter *padapter)
if (pwrpriv->wowlan_mode == true) {
if (pnetdev)
rtw_netif_stop_queue(pnetdev);
+
/*  1. stop thread */
padapter->bDriverStopped = true;/* for stop thread */
rtw_stop_drv_threads(padapter);
padapter->bDriverStopped = false;   /* for 32k command */
 
/*  2. disable interrupt */
-   if (padapter->intf_stop) {
+   if (padapter->intf_stop)
padapter->intf_stop(padapter);
-   }
 
/*  2.1 clean interrupt */
if (padapter->HalFunc.clear_interrupt)
@@ -1316,10 +1310,9 @@ void rtw_suspend_wow(struct adapter *padapter)
DBG_871X_LEVEL(_drv_always_, "%s: pno: %d\n", __func__, 
pwrpriv->wowlan_pno_enable);
else
rtw_set_ps_mode(padapter, PS_MODE_DTIM, 0, 0, "WOWLAN");
-   }
-   else {
+   } else
DBG_871X_LEVEL(_drv_always_, "%s: ### ERROR ### wowlan_mode 
=%d\n", __func__, pwrpriv->wowlan_mode);
-   }
+
DBG_871X("<== " FUNC_ADPT_FMT " exit\n", FUNC_ADPT_ARG(padapter));
 }
 #endif /* ifdef CONFIG_WOWLAN */
@@ -1448,14 +1441,13 @@ int rtw_suspend_common(struct adapter *padapter)
 
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) == true) {
#ifdef CONFIG_WOWLAN
-   if (check_fwstate(pmlmepriv, _FW_LINKED)) {
+   if (check_fwstate(pmlmepriv, _FW_LINKED))
pwrpriv->wowlan_mode = true;
-   } else if (pwrpriv->wowlan_pno_enable == true) {
+   else if (pwrpriv->wowlan_pno_enable == true)
pwrpriv->wowlan_mode |= pwrpriv->wowlan_pno_enable;
-   }
 
if (pwrpriv->wowlan_mode == true)
-   rtw_suspend_wow(padapter);
+   rtw_suspend_wow(padapter);