Re: [PATCH] Staging: xgifb: fix lines should not end with open parenthesis in vb_setmode.c

[Greg KH]

On Sat, Feb 17, 2018 at 12:12:36AM +0530, Yash Omer wrote:
> This patch fixes up line should not end with open parenthesis found by 
> checkpatch.pl script.
> 
> Signed-off-by: Yash Omer 
> ---
>  drivers/staging/xgifb/vb_setmode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/vb_setmode.c 
> b/drivers/staging/xgifb/vb_setmode.c
> index 1fa0dc66406e..1d6ac724fd61 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -1228,8 +1228,8 @@ static void const *XGI_GetLcdPtr(struct 
> XGI330_LCDDataTablStruct const *table,
>   return table[i].DATAPTR;
>  }
>  
> -static struct SiS_TVData const *XGI_GetTVPtr(
> - unsigned short ModeIdIndex,
> +static struct SiS_TVData const *XGI_GetTVPtr
> +(unsigned short ModeIdIndex,

Ick, that's horrid looking now, don't you think?

Please don't change things to make them look worse :)

greg k-h

Re: [PATCH] Staging: xgifb: fix lines should not end with open parenthesis in vb_setmode.c

[Greg KH]

On Sat, Feb 17, 2018 at 12:12:36AM +0530, Yash Omer wrote:
> This patch fixes up line should not end with open parenthesis found by 
> checkpatch.pl script.
> 
> Signed-off-by: Yash Omer 
> ---
>  drivers/staging/xgifb/vb_setmode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/vb_setmode.c 
> b/drivers/staging/xgifb/vb_setmode.c
> index 1fa0dc66406e..1d6ac724fd61 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -1228,8 +1228,8 @@ static void const *XGI_GetLcdPtr(struct 
> XGI330_LCDDataTablStruct const *table,
>   return table[i].DATAPTR;
>  }
>  
> -static struct SiS_TVData const *XGI_GetTVPtr(
> - unsigned short ModeIdIndex,
> +static struct SiS_TVData const *XGI_GetTVPtr
> +(unsigned short ModeIdIndex,

Ick, that's horrid looking now, don't you think?

Please don't change things to make them look worse :)

greg k-h

[PATCH] Staging: xgifb: fix lines should not end with open parenthesis in vb_setmode.c

[Yash Omer]

This patch fixes up line should not end with open parenthesis found by 
checkpatch.pl script.

Signed-off-by: Yash Omer 
---
 drivers/staging/xgifb/vb_setmode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/xgifb/vb_setmode.c 
b/drivers/staging/xgifb/vb_setmode.c
index 1fa0dc66406e..1d6ac724fd61 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -1228,8 +1228,8 @@ static void const *XGI_GetLcdPtr(struct 
XGI330_LCDDataTablStruct const *table,
return table[i].DATAPTR;
 }
 
-static struct SiS_TVData const *XGI_GetTVPtr(
-   unsigned short ModeIdIndex,
+static struct SiS_TVData const *XGI_GetTVPtr
+(unsigned short ModeIdIndex,
unsigned short RefreshRateTableIndex,
struct vb_device_info *pVBInfo)
 {
-- 
2.14.3

[PATCH] Staging: xgifb: fix lines should not end with open parenthesis in vb_setmode.c

[Yash Omer]

This patch fixes up line should not end with open parenthesis found by 
checkpatch.pl script.

Signed-off-by: Yash Omer 
---
 drivers/staging/xgifb/vb_setmode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/xgifb/vb_setmode.c 
b/drivers/staging/xgifb/vb_setmode.c
index 1fa0dc66406e..1d6ac724fd61 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -1228,8 +1228,8 @@ static void const *XGI_GetLcdPtr(struct 
XGI330_LCDDataTablStruct const *table,
return table[i].DATAPTR;
 }
 
-static struct SiS_TVData const *XGI_GetTVPtr(
-   unsigned short ModeIdIndex,
+static struct SiS_TVData const *XGI_GetTVPtr
+(unsigned short ModeIdIndex,
unsigned short RefreshRateTableIndex,
struct vb_device_info *pVBInfo)
 {
-- 
2.14.3