Re: [PATCH] adfs: trivial sparse fix

[Andrew Morton]

On Wed, 13 Feb 2008 19:52:12 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote:

> On Wed, 2008-02-13 at 19:39 -0800, Andrew Morton wrote:
> > On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison <[EMAIL PROTECTED]> 
> > wrote:
> > 
> > > fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound 
> > > statement
> > > 
> > > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
> > > ---
> > >  fs/adfs/dir_f.c |4 ++--
> > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
> > > index b9b2b27..ea7df21 100644
> > > --- a/fs/adfs/dir_f.c
> > > +++ b/fs/adfs/dir_f.c
> > > @@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
> > >   ptr.ptr8 = bufoff(bh, i);
> > >   end.ptr8 = ptr.ptr8 + last - i;
> > >  
> > > - do
> > > + do {
> > >   dircheck = *ptr.ptr8++ ^ ror13(dircheck);
> > > - while (ptr.ptr8 < end.ptr8);
> > > + } while (ptr.ptr8 < end.ptr8);
> > >   }
> > >  
> > 
> > eh?  It's sparse which needs fixing here, surely?
> 
> Well, I only 'fixed' it this way to match the surrounding code.  The
> warning is a little odd.
> 

Yup, well, I changed the title to something sufficiently rude to get a
reaction from Linus when it crosses his desk.  We'll see ;)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] adfs: trivial sparse fix

[Harvey Harrison]

On Wed, 2008-02-13 at 19:39 -0800, Andrew Morton wrote:
> On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote:
> 
> > fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound 
> > statement
> > 
> > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
> > ---
> >  fs/adfs/dir_f.c |4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
> > index b9b2b27..ea7df21 100644
> > --- a/fs/adfs/dir_f.c
> > +++ b/fs/adfs/dir_f.c
> > @@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
> > ptr.ptr8 = bufoff(bh, i);
> > end.ptr8 = ptr.ptr8 + last - i;
> >  
> > -   do
> > +   do {
> > dircheck = *ptr.ptr8++ ^ ror13(dircheck);
> > -   while (ptr.ptr8 < end.ptr8);
> > +   } while (ptr.ptr8 < end.ptr8);
> > }
> >  
> 
> eh?  It's sparse which needs fixing here, surely?

Well, I only 'fixed' it this way to match the surrounding code.  The
warning is a little odd.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] adfs: trivial sparse fix

[Andrew Morton]

On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote:

> fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement
> 
> Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
> ---
>  fs/adfs/dir_f.c |4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
> index b9b2b27..ea7df21 100644
> --- a/fs/adfs/dir_f.c
> +++ b/fs/adfs/dir_f.c
> @@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
>   ptr.ptr8 = bufoff(bh, i);
>   end.ptr8 = ptr.ptr8 + last - i;
>  
> - do
> + do {
>   dircheck = *ptr.ptr8++ ^ ror13(dircheck);
> - while (ptr.ptr8 < end.ptr8);
> + } while (ptr.ptr8 < end.ptr8);
>   }
>  

eh?  It's sparse which needs fixing here, surely?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] adfs: trivial sparse fix

[Harvey Harrison]

fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement

Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
 fs/adfs/dir_f.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
index b9b2b27..ea7df21 100644
--- a/fs/adfs/dir_f.c
+++ b/fs/adfs/dir_f.c
@@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
ptr.ptr8 = bufoff(bh, i);
end.ptr8 = ptr.ptr8 + last - i;
 
-   do
+   do {
dircheck = *ptr.ptr8++ ^ ror13(dircheck);
-   while (ptr.ptr8 < end.ptr8);
+   } while (ptr.ptr8 < end.ptr8);
}
 
/*
-- 
1.5.4.1.1278.gc75be



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] adfs: trivial sparse fix

[Harvey Harrison]

fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement

Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
 fs/adfs/dir_f.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
index b9b2b27..ea7df21 100644
--- a/fs/adfs/dir_f.c
+++ b/fs/adfs/dir_f.c
@@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
ptr.ptr8 = bufoff(bh, i);
end.ptr8 = ptr.ptr8 + last - i;
 
-   do
+   do {
dircheck = *ptr.ptr8++ ^ ror13(dircheck);
-   while (ptr.ptr8  end.ptr8);
+   } while (ptr.ptr8  end.ptr8);
}
 
/*
-- 
1.5.4.1.1278.gc75be



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] adfs: trivial sparse fix

[Andrew Morton]

On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison [EMAIL PROTECTED] wrote:

 fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement
 
 Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
 ---
  fs/adfs/dir_f.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
 index b9b2b27..ea7df21 100644
 --- a/fs/adfs/dir_f.c
 +++ b/fs/adfs/dir_f.c
 @@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
   ptr.ptr8 = bufoff(bh, i);
   end.ptr8 = ptr.ptr8 + last - i;
  
 - do
 + do {
   dircheck = *ptr.ptr8++ ^ ror13(dircheck);
 - while (ptr.ptr8  end.ptr8);
 + } while (ptr.ptr8  end.ptr8);
   }
  

eh?  It's sparse which needs fixing here, surely?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] adfs: trivial sparse fix

[Harvey Harrison]

On Wed, 2008-02-13 at 19:39 -0800, Andrew Morton wrote:
 On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison [EMAIL PROTECTED] wrote:
 
  fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound 
  statement
  
  Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
  ---
   fs/adfs/dir_f.c |4 ++--
   1 files changed, 2 insertions(+), 2 deletions(-)
  
  diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
  index b9b2b27..ea7df21 100644
  --- a/fs/adfs/dir_f.c
  +++ b/fs/adfs/dir_f.c
  @@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
  ptr.ptr8 = bufoff(bh, i);
  end.ptr8 = ptr.ptr8 + last - i;
   
  -   do
  +   do {
  dircheck = *ptr.ptr8++ ^ ror13(dircheck);
  -   while (ptr.ptr8  end.ptr8);
  +   } while (ptr.ptr8  end.ptr8);
  }
   
 
 eh?  It's sparse which needs fixing here, surely?

Well, I only 'fixed' it this way to match the surrounding code.  The
warning is a little odd.

Harvey

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] adfs: trivial sparse fix

[Andrew Morton]

On Wed, 13 Feb 2008 19:52:12 -0800 Harvey Harrison [EMAIL PROTECTED] wrote:

 On Wed, 2008-02-13 at 19:39 -0800, Andrew Morton wrote:
  On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison [EMAIL PROTECTED] 
  wrote:
  
   fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound 
   statement
   
   Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
   ---
fs/adfs/dir_f.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
   
   diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
   index b9b2b27..ea7df21 100644
   --- a/fs/adfs/dir_f.c
   +++ b/fs/adfs/dir_f.c
   @@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
 ptr.ptr8 = bufoff(bh, i);
 end.ptr8 = ptr.ptr8 + last - i;

   - do
   + do {
 dircheck = *ptr.ptr8++ ^ ror13(dircheck);
   - while (ptr.ptr8  end.ptr8);
   + } while (ptr.ptr8  end.ptr8);
 }

  
  eh?  It's sparse which needs fixing here, surely?
 
 Well, I only 'fixed' it this way to match the surrounding code.  The
 warning is a little odd.
 

Yup, well, I changed the title to something sufficiently rude to get a
reaction from Linus when it crosses his desk.  We'll see ;)

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/