Re: [PATCH] arcc/kernel/process: Few mundane typo fixes

[Vineet Gupta]

On 3/22/21 5:51 AM, Bhaskar Chowdhury wrote:
> s/defintion/definition/
> s/succeded/succeeded/
> s/commiting/committing/
> s/interrutps/interrupts/
>
> Signed-off-by: Bhaskar Chowdhury 

I've squashed all your 3 patches into one (no reason to break them out) 
and queued for 5.13.

Thx,
-Vineet

> ---
> diff --git a/arch/arc/kernel/process.c b/arch/arc/kernel/process.c
> index d838d0d57696..3793876f42d9 100644
> --- a/arch/arc/kernel/process.c
> +++ b/arch/arc/kernel/process.c
> @@ -50,14 +50,14 @@ SYSCALL_DEFINE3(arc_usr_cmpxchg, int *, uaddr, int, 
> expected, int, new)
>   int ret;
>
>   /*
> -  * This is only for old cores lacking LLOCK/SCOND, which by defintion
> +  * This is only for old cores lacking LLOCK/SCOND, which by definition
>* can't possibly be SMP. Thus doesn't need to be SMP safe.
>* And this also helps reduce the overhead for serializing in
>* the UP case
>*/
>   WARN_ON_ONCE(IS_ENABLED(CONFIG_SMP));
>
> - /* Z indicates to userspace if operation succeded */
> + /* Z indicates to userspace if operation succeeded */
>   regs->status32 &= ~STATUS_Z_MASK;
>
>   ret = access_ok(uaddr, sizeof(*uaddr));
> @@ -107,7 +107,7 @@ SYSCALL_DEFINE3(arc_usr_cmpxchg, int *, uaddr, int, 
> expected, int, new)
>
>   void arch_cpu_idle(void)
>   {
> - /* Re-enable interrupts <= default irq priority before commiting SLEEP 
> */
> + /* Re-enable interrupts <= default irq priority before committing SLEEP 
> */
>   const unsigned int arg = 0x10 | ARCV2_IRQ_DEF_PRIO;
>
>   __asm__ __volatile__(
> @@ -120,7 +120,7 @@ void arch_cpu_idle(void)
>
>   void arch_cpu_idle(void)
>   {
> - /* sleep, but enable both set E1/E2 (levels of interrutps) before 
> committing */
> + /* sleep, but enable both set E1/E2 (levels of interrupts) before 
> committing */
>   __asm__ __volatile__("sleep 0x3 \n");
>   }
>
> --
> 2.31.0
>

Re: [PATCH] arcc/kernel/process: Few mundane typo fixes

[Bhaskar Chowdhury]

On 14:23 Mon 22 Mar 2021, Christian Brauner wrote:

On Mon, Mar 22, 2021 at 06:21:55PM +0530, Bhaskar Chowdhury wrote:

s/defintion/definition/
s/succeded/succeeded/
s/commiting/committing/
s/interrutps/interrupts/

Signed-off-by: Bhaskar Chowdhury 
---


Since you aim to be mirroring the path arc/kernel/process there's a typo
in the patch subject :)
s/arcc/arc/


Thanks, will be careful in the future.


otherwise

Reviewed-by: Christian Brauner 


signature.asc
Description: PGP signature

Re: [PATCH] arcc/kernel/process: Few mundane typo fixes

[Christian Brauner]

On Mon, Mar 22, 2021 at 06:21:55PM +0530, Bhaskar Chowdhury wrote:
> s/defintion/definition/
> s/succeded/succeeded/
> s/commiting/committing/
> s/interrutps/interrupts/
> 
> Signed-off-by: Bhaskar Chowdhury 
> ---

Since you aim to be mirroring the path arc/kernel/process there's a typo
in the patch subject :)
s/arcc/arc/

otherwise

Reviewed-by: Christian Brauner 

[PATCH] arcc/kernel/process: Few mundane typo fixes

[Bhaskar Chowdhury]

s/defintion/definition/
s/succeded/succeeded/
s/commiting/committing/
s/interrutps/interrupts/

Signed-off-by: Bhaskar Chowdhury 
---
diff --git a/arch/arc/kernel/process.c b/arch/arc/kernel/process.c
index d838d0d57696..3793876f42d9 100644
--- a/arch/arc/kernel/process.c
+++ b/arch/arc/kernel/process.c
@@ -50,14 +50,14 @@ SYSCALL_DEFINE3(arc_usr_cmpxchg, int *, uaddr, int, 
expected, int, new)
int ret;

/*
-* This is only for old cores lacking LLOCK/SCOND, which by defintion
+* This is only for old cores lacking LLOCK/SCOND, which by definition
 * can't possibly be SMP. Thus doesn't need to be SMP safe.
 * And this also helps reduce the overhead for serializing in
 * the UP case
 */
WARN_ON_ONCE(IS_ENABLED(CONFIG_SMP));

-   /* Z indicates to userspace if operation succeded */
+   /* Z indicates to userspace if operation succeeded */
regs->status32 &= ~STATUS_Z_MASK;

ret = access_ok(uaddr, sizeof(*uaddr));
@@ -107,7 +107,7 @@ SYSCALL_DEFINE3(arc_usr_cmpxchg, int *, uaddr, int, 
expected, int, new)

 void arch_cpu_idle(void)
 {
-   /* Re-enable interrupts <= default irq priority before commiting SLEEP 
*/
+   /* Re-enable interrupts <= default irq priority before committing SLEEP 
*/
const unsigned int arg = 0x10 | ARCV2_IRQ_DEF_PRIO;

__asm__ __volatile__(
@@ -120,7 +120,7 @@ void arch_cpu_idle(void)

 void arch_cpu_idle(void)
 {
-   /* sleep, but enable both set E1/E2 (levels of interrutps) before 
committing */
+   /* sleep, but enable both set E1/E2 (levels of interrupts) before 
committing */
__asm__ __volatile__("sleep 0x3 \n");
 }

--
2.31.0