Re: [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume

2014-09-28 Thread Sudip Mukherjee 
On Sat, Sep 27, 2014 at 10:50:52PM -0400, Nicholas Krause wrote:
> This removes the FIXME message and issue with reading in this driver before 
> resuming
> in the function, sa_resume.
> 
> Signed-off-by: Nicholas Krause 
> ---
>  arch/arm/common/sa.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/common/sa.c b/arch/arm/common/sa.c
> index e57d7e5..0c4b9a9 100644
> --- a/arch/arm/common/sa.c
> +++ b/arch/arm/common/sa.c
> @@ -950,9 +950,7 @@ static int sa_resume(struct platform_device *dev)
>  
>   /*
>* Ensure that the SA is still here.
> -  * FIXME: shouldn't do this here.
>*/
> - id = sa_readl(sachip->base + SA_SKID);

do you understand the effect of removing this???
what is the value of id in the next part of the code?

thanks
sudip
>   if ((id & SKID_ID_MASK) != SKID_SA_ID) {
>   __sa_remove(sachip);
>   platform_set_drvdata(dev, NULL);
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume

2014-09-28 Thread Sudip Mukherjee 
On Sat, Sep 27, 2014 at 10:50:52PM -0400, Nicholas Krause wrote:
 This removes the FIXME message and issue with reading in this driver before 
 resuming
 in the function, sa_resume.
 
 Signed-off-by: Nicholas Krause yoc...@gmail.com
 ---
  arch/arm/common/sa.c | 2 --
  1 file changed, 2 deletions(-)
 
 diff --git a/arch/arm/common/sa.c b/arch/arm/common/sa.c
 index e57d7e5..0c4b9a9 100644
 --- a/arch/arm/common/sa.c
 +++ b/arch/arm/common/sa.c
 @@ -950,9 +950,7 @@ static int sa_resume(struct platform_device *dev)
  
   /*
* Ensure that the SA is still here.
 -  * FIXME: shouldn't do this here.
*/
 - id = sa_readl(sachip-base + SA_SKID);

do you understand the effect of removing this???
what is the value of id in the next part of the code?

thanks
sudip
   if ((id  SKID_ID_MASK) != SKID_SA_ID) {
   __sa_remove(sachip);
   platform_set_drvdata(dev, NULL);
 -- 
 1.9.1
 
 --
 To unsubscribe from this list: send the line unsubscribe linux-kernel in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume

2014-09-27 Thread nick 


On 14-09-27 11:31 PM, Randy Dunlap wrote:
> On 09/27/14 19:50, Nicholas Krause wrote:
>> This removes the FIXME message and issue with reading in this driver before 
>> resuming
>> in the function, sa_resume.
> 
> You need to explain why this makes any sense.
> Hint:  it doesn't.
> 
>> Signed-off-by: Nicholas Krause 
>> ---
>>  arch/arm/common/sa.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm/common/sa.c b/arch/arm/common/sa.c
>> index e57d7e5..0c4b9a9 100644
>> --- a/arch/arm/common/sa.c
>> +++ b/arch/arm/common/sa.c
>> @@ -950,9 +950,7 @@ static int sa_resume(struct platform_device *dev)
>>  
>>  /*
>>   * Ensure that the SA is still here.
>> - * FIXME: shouldn't do this here.
>>   */
>> -id = sa_readl(sachip->base + SA_SKID);
>>  if ((id & SKID_ID_MASK) != SKID_SA_ID) {
>>  __sa_remove(sachip);
>>  platform_set_drvdata(dev, NULL);
>>
> 
> 
Thanks for the reply Randy. I was wondering if was what the FIX ME meant if it 
meant something else please let me 
known.
Sorry,
Nick 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume

2014-09-27 Thread Randy Dunlap 
On 09/27/14 19:50, Nicholas Krause wrote:
> This removes the FIXME message and issue with reading in this driver before 
> resuming
> in the function, sa_resume.

You need to explain why this makes any sense.
Hint:  it doesn't.

> Signed-off-by: Nicholas Krause 
> ---
>  arch/arm/common/sa.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/common/sa.c b/arch/arm/common/sa.c
> index e57d7e5..0c4b9a9 100644
> --- a/arch/arm/common/sa.c
> +++ b/arch/arm/common/sa.c
> @@ -950,9 +950,7 @@ static int sa_resume(struct platform_device *dev)
>  
>   /*
>* Ensure that the SA is still here.
> -  * FIXME: shouldn't do this here.
>*/
> - id = sa_readl(sachip->base + SA_SKID);
>   if ((id & SKID_ID_MASK) != SKID_SA_ID) {
>   __sa_remove(sachip);
>   platform_set_drvdata(dev, NULL);
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume

2014-09-27 Thread Nicholas Krause 
This removes the FIXME message and issue with reading in this driver before 
resuming
in the function, sa_resume.

Signed-off-by: Nicholas Krause 
---
 arch/arm/common/sa.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/common/sa.c b/arch/arm/common/sa.c
index e57d7e5..0c4b9a9 100644
--- a/arch/arm/common/sa.c
+++ b/arch/arm/common/sa.c
@@ -950,9 +950,7 @@ static int sa_resume(struct platform_device *dev)
 
/*
 * Ensure that the SA is still here.
-* FIXME: shouldn't do this here.
 */
-   id = sa_readl(sachip->base + SA_SKID);
if ((id & SKID_ID_MASK) != SKID_SA_ID) {
__sa_remove(sachip);
platform_set_drvdata(dev, NULL);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume

2014-09-27 Thread Nicholas Krause 
This removes the FIXME message and issue with reading in this driver before 
resuming
in the function, sa_resume.

Signed-off-by: Nicholas Krause yoc...@gmail.com
---
 arch/arm/common/sa.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/common/sa.c b/arch/arm/common/sa.c
index e57d7e5..0c4b9a9 100644
--- a/arch/arm/common/sa.c
+++ b/arch/arm/common/sa.c
@@ -950,9 +950,7 @@ static int sa_resume(struct platform_device *dev)
 
/*
 * Ensure that the SA is still here.
-* FIXME: shouldn't do this here.
 */
-   id = sa_readl(sachip-base + SA_SKID);
if ((id  SKID_ID_MASK) != SKID_SA_ID) {
__sa_remove(sachip);
platform_set_drvdata(dev, NULL);
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume

2014-09-27 Thread Randy Dunlap 
On 09/27/14 19:50, Nicholas Krause wrote:
 This removes the FIXME message and issue with reading in this driver before 
 resuming
 in the function, sa_resume.

You need to explain why this makes any sense.
Hint:  it doesn't.

 Signed-off-by: Nicholas Krause yoc...@gmail.com
 ---
  arch/arm/common/sa.c | 2 --
  1 file changed, 2 deletions(-)
 
 diff --git a/arch/arm/common/sa.c b/arch/arm/common/sa.c
 index e57d7e5..0c4b9a9 100644
 --- a/arch/arm/common/sa.c
 +++ b/arch/arm/common/sa.c
 @@ -950,9 +950,7 @@ static int sa_resume(struct platform_device *dev)
  
   /*
* Ensure that the SA is still here.
 -  * FIXME: shouldn't do this here.
*/
 - id = sa_readl(sachip-base + SA_SKID);
   if ((id  SKID_ID_MASK) != SKID_SA_ID) {
   __sa_remove(sachip);
   platform_set_drvdata(dev, NULL);
 


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume

2014-09-27 Thread nick 


On 14-09-27 11:31 PM, Randy Dunlap wrote:
 On 09/27/14 19:50, Nicholas Krause wrote:
 This removes the FIXME message and issue with reading in this driver before 
 resuming
 in the function, sa_resume.
 
 You need to explain why this makes any sense.
 Hint:  it doesn't.
 
 Signed-off-by: Nicholas Krause yoc...@gmail.com
 ---
  arch/arm/common/sa.c | 2 --
  1 file changed, 2 deletions(-)

 diff --git a/arch/arm/common/sa.c b/arch/arm/common/sa.c
 index e57d7e5..0c4b9a9 100644
 --- a/arch/arm/common/sa.c
 +++ b/arch/arm/common/sa.c
 @@ -950,9 +950,7 @@ static int sa_resume(struct platform_device *dev)
  
  /*
   * Ensure that the SA is still here.
 - * FIXME: shouldn't do this here.
   */
 -id = sa_readl(sachip-base + SA_SKID);
  if ((id  SKID_ID_MASK) != SKID_SA_ID) {
  __sa_remove(sachip);
  platform_set_drvdata(dev, NULL);

 
 
Thanks for the reply Randy. I was wondering if was what the FIX ME meant if it 
meant something else please let me 
known.
Sorry,
Nick 
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/