Re: [PATCH] arm64: dts: hikey: Revert "Enable HS200 mode on eMMC"
Hi John,
On 1/23/2019 8:06 PM, John Stultz wrote:
> From: Alistair Strachan
>
> This reverts commit abd7d0972a192ee653efc7b151a6af69db58f2bb. This
> change was already partially reverted by John Stultz in commit
> 9c6d26df1fae ("arm64: dts: hikey: Fix eMMC corruption regression").
>
> This change appears to cause controller resets and block read failures
> which prevents successful booting on some hikey boards.
>
> Cc: Ryan Grachek
> Cc: Wei Xu
> Cc: Manivannan Sadhasivam
> Cc: Rob Herring
> Cc: Mark Rutland
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: devicet...@vger.kernel.org
> Cc: stable #4.17+
> Signed-off-by: Alistair Strachan
> Signed-off-by: John Stultz
Applied to the hisilicon soc dt tree.
Thanks!
Best Regards,
Wei
> ---
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index 6102350..7092460 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -300,7 +300,6 @@
>
> dwmmc_0: dwmmc0@f723d000 {
> cap-mmc-highspeed;
> - mmc-hs200-1_8v;
> non-removable;
> bus-width = <0x8>;
> vmmc-supply = <>;
>
Re: [PATCH] arm64: dts: hikey: Revert "Enable HS200 mode on eMMC"
On Thu, Jan 24, 2019 at 3:18 AM Robin Murphy wrote:
>
> Hi John,
>
> On 23/01/2019 20:06, John Stultz wrote:
> > From: Alistair Strachan
> >
> > This reverts commit abd7d0972a192ee653efc7b151a6af69db58f2bb. This
> > change was already partially reverted by John Stultz in commit
> > 9c6d26df1fae ("arm64: dts: hikey: Fix eMMC corruption regression").
> >
> > This change appears to cause controller resets and block read failures
> > which prevents successful booting on some hikey boards.
>
> FWIW, you might want to have a play with the pinctrl settings - I've
> seen various flakiness with HS200 eMMCs on Rockchip boards which could
> be solved by bumping up the drive strength.
>
Hm. Thanks for the tip. I'll have to dig around to see if that can
help. In the meantime though, I think the revert is the right
solution, as this is currently blocking some boards from booting
mainline. We can then look to re-enable HS200 mode if we can sort out
the issues we saw with boards using hynix mmc chips.
thanks
-john
Re: [PATCH] arm64: dts: hikey: Revert "Enable HS200 mode on eMMC"
Hi John,
On 23/01/2019 20:06, John Stultz wrote:
From: Alistair Strachan
This reverts commit abd7d0972a192ee653efc7b151a6af69db58f2bb. This
change was already partially reverted by John Stultz in commit
9c6d26df1fae ("arm64: dts: hikey: Fix eMMC corruption regression").
This change appears to cause controller resets and block read failures
which prevents successful booting on some hikey boards.
FWIW, you might want to have a play with the pinctrl settings - I've
seen various flakiness with HS200 eMMCs on Rockchip boards which could
be solved by bumping up the drive strength.
Robin.
Cc: Ryan Grachek
Cc: Wei Xu
Cc: Manivannan Sadhasivam
Cc: Rob Herring
Cc: Mark Rutland
Cc: linux-arm-ker...@lists.infradead.org
Cc: devicet...@vger.kernel.org
Cc: stable #4.17+
Signed-off-by: Alistair Strachan
Signed-off-by: John Stultz
---
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
index 6102350..7092460 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
@@ -300,7 +300,6 @@
dwmmc_0: dwmmc0@f723d000 {
cap-mmc-highspeed;
- mmc-hs200-1_8v;
non-removable;
bus-width = <0x8>;
vmmc-supply = <>;
[PATCH] arm64: dts: hikey: Revert "Enable HS200 mode on eMMC"
From: Alistair Strachan
This reverts commit abd7d0972a192ee653efc7b151a6af69db58f2bb. This
change was already partially reverted by John Stultz in commit
9c6d26df1fae ("arm64: dts: hikey: Fix eMMC corruption regression").
This change appears to cause controller resets and block read failures
which prevents successful booting on some hikey boards.
Cc: Ryan Grachek
Cc: Wei Xu
Cc: Manivannan Sadhasivam
Cc: Rob Herring
Cc: Mark Rutland
Cc: linux-arm-ker...@lists.infradead.org
Cc: devicet...@vger.kernel.org
Cc: stable #4.17+
Signed-off-by: Alistair Strachan
Signed-off-by: John Stultz
---
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
index 6102350..7092460 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
@@ -300,7 +300,6 @@
dwmmc_0: dwmmc0@f723d000 {
cap-mmc-highspeed;
- mmc-hs200-1_8v;
non-removable;
bus-width = <0x8>;
vmmc-supply = <>;
--
2.7.4
