RE: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes

2020-06-23 Thread Qiang Zhao 
On 2020/6/24, Leo Li  wrote:

> -Original Message-
> From: Leo Li 
> Sent: 2020年6月24日 7:12
> To: Qiang Zhao ; shawn...@kernel.org
> Cc: devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; Qiang Zhao
> ; Xiaowei Bao 
> Subject: RE: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes
> 
> 
> 
> > -Original Message-
> > From: Qiang Zhao 
> > Sent: Monday, June 22, 2020 3:29 AM
> > To: shawn...@kernel.org
> > Cc: devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; Leo Li
> > ; Qiang Zhao ; Xiaowei Bao
> > 
> > Subject: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes
> 
> This patch is actually defining dspi flash nodes for LS1028a-qds board instead
> of adding dspi nodes for the soc.

Thank you! Will correct next version. 

> 
> >
> > From: Xiaowei Bao 
> >
> > Add the DSPI nodes for ls1028a.
> >
> > Signed-off-by: Xiaowei Bao 
> > Signed-off-by: Zhao Qiang 
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 85
> > +++
> >  1 file changed, 85 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > index dd69c5b..e4f00c2 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > @@ -107,6 +107,91 @@
> > };
> >  };
> >
> > + {
> > +   bus-num = <0>;
> > +   status = "okay";
> > +
> > +   flash@0 {
> > +   #address-cells = <1>;
> > +   #size-cells = <1>;
> > +   compatible = "jedec,spi-nor";
> > +   spi-cpol;
> > +   spi-cpha;
> > +   reg = <0>;
> > +   spi-max-frequency = <1000>;
> > +   };
> > +
> > +   flash@1 {
> > +   #address-cells = <1>;
> > +   #size-cells = <1>;
> > +   compatible = "jedec,spi-nor";
> > +   spi-cpol;
> > +   spi-cpha;
> > +   reg = <1>;
> > +   spi-max-frequency = <1000>;
> > +   };
> > +
> > +   flash@2 {
> > +   #address-cells = <1>;
> > +   #size-cells = <1>;
> > +   compatible = "jedec,spi-nor";
> > +   spi-cpol;
> > +   spi-cpha;
> > +   reg = <2>;
> > +   spi-max-frequency = <1000>;
> > +   };
> > +};
> > +
> > + {
> > +   bus-num = <1>;
> > +   status = "okay";
> > +
> > +   flash@0 {
> > +   #address-cells = <1>;
> > +   #size-cells = <1>;
> 
> These probably are not needed when no sub nodes are defined.
> 
> > +   compatible = "jedec,spi-nor";
> > +   spi-cpol;
> > +   spi-cpha;
> > +   reg = <0>;
> > +   spi-max-frequency = <1000>;
> > +   };
> > +
> > +   flash@1 {
> > +   #address-cells = <1>;
> > +   #size-cells = <1>;
> > +   compatible = "jedec,spi-nor";
> > +   spi-cpol;
> > +   spi-cpha;
> > +   reg = <1>;
> > +   spi-max-frequency = <1000>;
> > +   };
> > +
> > +   flash@2 {
> > +   #address-cells = <1>;
> > +   #size-cells = <1>;
> > +   compatible = "jedec,spi-nor";
> > +   spi-cpol;
> > +   spi-cpha;
> > +   reg = <2>;
> > +   spi-max-frequency = <1000>;
> > +   };
> > +};
> > +
> > + {
> > +   bus-num = <2>;
> > +   status = "okay";
> > +
> > +   flash@0 {
> > +   #address-cells = <1>;
> > +   #size-cells = <1>;
> > +   compatible = "jedec,spi-nor";
> > +   spi-cpol;
> > +   spi-cpha;
> > +   reg = <0>;
> > +   spi-max-frequency = <1000>;
> > +   };
> > +};
> > +
> >   {
> > status = "okay";
> >  };
> > --
> > 2.7.4

Best Regards
Qiang Zhao

RE: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes

2020-06-23 Thread Leo Li 



> -Original Message-
> From: Qiang Zhao 
> Sent: Monday, June 22, 2020 3:29 AM
> To: shawn...@kernel.org
> Cc: devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; Leo Li
> ; Qiang Zhao ; Xiaowei Bao
> 
> Subject: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes

This patch is actually defining dspi flash nodes for LS1028a-qds board instead 
of adding dspi nodes for the soc.

> 
> From: Xiaowei Bao 
> 
> Add the DSPI nodes for ls1028a.
> 
> Signed-off-by: Xiaowei Bao 
> Signed-off-by: Zhao Qiang 
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 85
> +++
>  1 file changed, 85 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index dd69c5b..e4f00c2 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -107,6 +107,91 @@
>   };
>  };
> 
> + {
> + bus-num = <0>;
> + status = "okay";
> +
> + flash@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + spi-cpol;
> + spi-cpha;
> + reg = <0>;
> + spi-max-frequency = <1000>;
> + };
> +
> + flash@1 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + spi-cpol;
> + spi-cpha;
> + reg = <1>;
> + spi-max-frequency = <1000>;
> + };
> +
> + flash@2 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + spi-cpol;
> + spi-cpha;
> + reg = <2>;
> + spi-max-frequency = <1000>;
> + };
> +};
> +
> + {
> + bus-num = <1>;
> + status = "okay";
> +
> + flash@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;

These probably are not needed when no sub nodes are defined.

> + compatible = "jedec,spi-nor";
> + spi-cpol;
> + spi-cpha;
> + reg = <0>;
> + spi-max-frequency = <1000>;
> + };
> +
> + flash@1 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + spi-cpol;
> + spi-cpha;
> + reg = <1>;
> + spi-max-frequency = <1000>;
> + };
> +
> + flash@2 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + spi-cpol;
> + spi-cpha;
> + reg = <2>;
> + spi-max-frequency = <1000>;
> + };
> +};
> +
> + {
> + bus-num = <2>;
> + status = "okay";
> +
> + flash@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + spi-cpol;
> + spi-cpha;
> + reg = <0>;
> + spi-max-frequency = <1000>;
> + };
> +};
> +
>   {
>   status = "okay";
>  };
> --
> 2.7.4

[RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes

2020-06-22 Thread Qiang Zhao 
From: Xiaowei Bao 

Add the DSPI nodes for ls1028a.

Signed-off-by: Xiaowei Bao 
Signed-off-by: Zhao Qiang 
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 85 +++
 1 file changed, 85 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts 
b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
index dd69c5b..e4f00c2 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
@@ -107,6 +107,91 @@
};
 };
 
+ {
+   bus-num = <0>;
+   status = "okay";
+
+   flash@0 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "jedec,spi-nor";
+   spi-cpol;
+   spi-cpha;
+   reg = <0>;
+   spi-max-frequency = <1000>;
+   };
+
+   flash@1 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "jedec,spi-nor";
+   spi-cpol;
+   spi-cpha;
+   reg = <1>;
+   spi-max-frequency = <1000>;
+   };
+
+   flash@2 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "jedec,spi-nor";
+   spi-cpol;
+   spi-cpha;
+   reg = <2>;
+   spi-max-frequency = <1000>;
+   };
+};
+
+ {
+   bus-num = <1>;
+   status = "okay";
+
+   flash@0 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "jedec,spi-nor";
+   spi-cpol;
+   spi-cpha;
+   reg = <0>;
+   spi-max-frequency = <1000>;
+   };
+
+   flash@1 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "jedec,spi-nor";
+   spi-cpol;
+   spi-cpha;
+   reg = <1>;
+   spi-max-frequency = <1000>;
+   };
+
+   flash@2 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "jedec,spi-nor";
+   spi-cpol;
+   spi-cpha;
+   reg = <2>;
+   spi-max-frequency = <1000>;
+   };
+};
+
+ {
+   bus-num = <2>;
+   status = "okay";
+
+   flash@0 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "jedec,spi-nor";
+   spi-cpol;
+   spi-cpha;
+   reg = <0>;
+   spi-max-frequency = <1000>;
+   };
+};
+
  {
status = "okay";
 };
-- 
2.7.4

[PATCH] arm64: dts: ls1028a: Add DSPI nodes

2020-06-22 Thread Qiang Zhao 
From: Xiaowei Bao 

Add the DSPI nodes for ls1028a.

Signed-off-by: Xiaowei Bao 
Signed-off-by: Zhao Qiang 
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 85 +++
 1 file changed, 85 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts 
b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
index dd69c5b..e4f00c2 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
@@ -107,6 +107,91 @@
};
 };
 
+ {
+   bus-num = <0>;
+   status = "okay";
+
+   flash@0 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "jedec,spi-nor";
+   spi-cpol;
+   spi-cpha;
+   reg = <0>;
+   spi-max-frequency = <1000>;
+   };
+
+   flash@1 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "jedec,spi-nor";
+   spi-cpol;
+   spi-cpha;
+   reg = <1>;
+   spi-max-frequency = <1000>;
+   };
+
+   flash@2 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "jedec,spi-nor";
+   spi-cpol;
+   spi-cpha;
+   reg = <2>;
+   spi-max-frequency = <1000>;
+   };
+};
+
+ {
+   bus-num = <1>;
+   status = "okay";
+
+   flash@0 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "jedec,spi-nor";
+   spi-cpol;
+   spi-cpha;
+   reg = <0>;
+   spi-max-frequency = <1000>;
+   };
+
+   flash@1 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "jedec,spi-nor";
+   spi-cpol;
+   spi-cpha;
+   reg = <1>;
+   spi-max-frequency = <1000>;
+   };
+
+   flash@2 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "jedec,spi-nor";
+   spi-cpol;
+   spi-cpha;
+   reg = <2>;
+   spi-max-frequency = <1000>;
+   };
+};
+
+ {
+   bus-num = <2>;
+   status = "okay";
+
+   flash@0 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "jedec,spi-nor";
+   spi-cpol;
+   spi-cpha;
+   reg = <0>;
+   spi-max-frequency = <1000>;
+   };
+};
+
  {
status = "okay";
 };
-- 
2.7.4