Re: [PATCH] arm64: dts: msm8996: fix gic_irq_domain_translate warnings
On Fri, Apr 27, 2018 at 9:10 AM, Thierry Escandewrote: > Remove the usage of IRQ_TYPE_NONE to fix loud warnings from > patch (83a86fbb5b56b "irqchip/gic: Loudly complain about > the use of IRQ_TYPE_NONE"). > > Signed-off-by: Thierry Escande Reviewed-by: Amit Kucheria Tested-by: Amit Kucheria (boot report here: https://storage.kernelci.org/qcom-lt/integration-linux-qcomlt/v4.17-rc4-247-gbe94bee41bf6/arm64/defconfig/lab-bjorn/boot-apq8096-db820c.txt) > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi > b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 410ae787ebb4..1aaf1fa2604e 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -437,7 +437,7 @@ > blsp2_i2c0: i2c@75b5000 { > compatible = "qcom,i2c-qup-v2.2.1"; > reg = <0x075b5000 0x1000>; > - interrupts = ; > + interrupts = ; > clocks = < GCC_BLSP2_AHB_CLK>, > < GCC_BLSP2_QUP1_I2C_APPS_CLK>; > clock-names = "iface", "core"; > @@ -468,7 +468,7 @@ > blsp2_i2c1: i2c@75b6000 { > compatible = "qcom,i2c-qup-v2.2.1"; > reg = <0x075b6000 0x1000>; > - interrupts = ; > + interrupts = ; > clocks = < GCC_BLSP2_AHB_CLK>, > < GCC_BLSP2_QUP2_I2C_APPS_CLK>; > clock-names = "iface", "core"; > @@ -493,7 +493,7 @@ > blsp1_i2c2: i2c@7577000 { > compatible = "qcom,i2c-qup-v2.2.1"; > reg = <0x07577000 0x1000>; > - interrupts = ; > + interrupts = ; > clocks = < GCC_BLSP1_AHB_CLK>, > < GCC_BLSP1_QUP3_I2C_APPS_CLK>; > clock-names = "iface", "core"; > @@ -526,7 +526,8 @@ > reg = <0x74a4900 0x314>, <0x74a4000 0x800>; > reg-names = "hc_mem", "core_mem"; > > -interrupts = <0 125 0>, <0 221 0>; > +interrupts = <0 125 IRQ_TYPE_LEVEL_HIGH>, > + <0 221 IRQ_TYPE_LEVEL_HIGH>; > interrupt-names = "hc_irq", "pwr_irq"; > > clock-names = "iface", "core", "xo"; > @@ -809,7 +810,7 @@ > dwc3@760 { > compatible = "snps,dwc3"; > reg = <0x760 0xcc00>; > - interrupts = <0 138 0>; > + interrupts = <0 138 IRQ_TYPE_LEVEL_HIGH>; > phys = <_phy2>; > phy-names = "usb2-phy"; > }; > @@ -838,7 +839,7 @@ > dwc3@6a0 { > compatible = "snps,dwc3"; > reg = <0x6a0 0xcc00>; > - interrupts = <0 131 0>; > + interrupts = <0 131 IRQ_TYPE_LEVEL_HIGH>; > phys = <_phy1>, <_phy_0>; > phy-names = "usb2-phy", "usb3-phy"; > }; > @@ -872,7 +873,7 @@ > ranges = <0x0100 0x0 0x0c20 > 0x0c20 0x0 0x10>, > <0x0200 0x0 0x0c30 0x0c30 > 0x0 0xd0>; > > - interrupts = ; > + interrupts = IRQ_TYPE_LEVEL_HIGH>; > interrupt-names = "msi"; > #interrupt-cells = <1>; > interrupt-map-mask = <0 0 0 0x7>; > @@ -927,7 +928,7 @@ > ranges = <0x0100 0x0 0x0d20 > 0x0d20 0x0 0x10>, > <0x0200 0x0 0x0d30 0x0d30 > 0x0 0xd0>; > > - interrupts = ; > + interrupts = IRQ_TYPE_LEVEL_HIGH>; > interrupt-names = "msi"; > #interrupt-cells = <1>; > interrupt-map-mask = <0 0 0 0x7>; > @@ -980,7 +981,7 @@ > > device_type = "pci"; > > - interrupts = ; > + interrupts = IRQ_TYPE_LEVEL_HIGH>; > interrupt-names = "msi"; >
Re: [PATCH] arm64: dts: msm8996: fix gic_irq_domain_translate warnings
On Fri, Apr 27, 2018 at 9:10 AM, Thierry Escande wrote: > Remove the usage of IRQ_TYPE_NONE to fix loud warnings from > patch (83a86fbb5b56b "irqchip/gic: Loudly complain about > the use of IRQ_TYPE_NONE"). > > Signed-off-by: Thierry Escande Reviewed-by: Amit Kucheria Tested-by: Amit Kucheria (boot report here: https://storage.kernelci.org/qcom-lt/integration-linux-qcomlt/v4.17-rc4-247-gbe94bee41bf6/arm64/defconfig/lab-bjorn/boot-apq8096-db820c.txt) > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi > b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 410ae787ebb4..1aaf1fa2604e 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -437,7 +437,7 @@ > blsp2_i2c0: i2c@75b5000 { > compatible = "qcom,i2c-qup-v2.2.1"; > reg = <0x075b5000 0x1000>; > - interrupts = ; > + interrupts = ; > clocks = < GCC_BLSP2_AHB_CLK>, > < GCC_BLSP2_QUP1_I2C_APPS_CLK>; > clock-names = "iface", "core"; > @@ -468,7 +468,7 @@ > blsp2_i2c1: i2c@75b6000 { > compatible = "qcom,i2c-qup-v2.2.1"; > reg = <0x075b6000 0x1000>; > - interrupts = ; > + interrupts = ; > clocks = < GCC_BLSP2_AHB_CLK>, > < GCC_BLSP2_QUP2_I2C_APPS_CLK>; > clock-names = "iface", "core"; > @@ -493,7 +493,7 @@ > blsp1_i2c2: i2c@7577000 { > compatible = "qcom,i2c-qup-v2.2.1"; > reg = <0x07577000 0x1000>; > - interrupts = ; > + interrupts = ; > clocks = < GCC_BLSP1_AHB_CLK>, > < GCC_BLSP1_QUP3_I2C_APPS_CLK>; > clock-names = "iface", "core"; > @@ -526,7 +526,8 @@ > reg = <0x74a4900 0x314>, <0x74a4000 0x800>; > reg-names = "hc_mem", "core_mem"; > > -interrupts = <0 125 0>, <0 221 0>; > +interrupts = <0 125 IRQ_TYPE_LEVEL_HIGH>, > + <0 221 IRQ_TYPE_LEVEL_HIGH>; > interrupt-names = "hc_irq", "pwr_irq"; > > clock-names = "iface", "core", "xo"; > @@ -809,7 +810,7 @@ > dwc3@760 { > compatible = "snps,dwc3"; > reg = <0x760 0xcc00>; > - interrupts = <0 138 0>; > + interrupts = <0 138 IRQ_TYPE_LEVEL_HIGH>; > phys = <_phy2>; > phy-names = "usb2-phy"; > }; > @@ -838,7 +839,7 @@ > dwc3@6a0 { > compatible = "snps,dwc3"; > reg = <0x6a0 0xcc00>; > - interrupts = <0 131 0>; > + interrupts = <0 131 IRQ_TYPE_LEVEL_HIGH>; > phys = <_phy1>, <_phy_0>; > phy-names = "usb2-phy", "usb3-phy"; > }; > @@ -872,7 +873,7 @@ > ranges = <0x0100 0x0 0x0c20 > 0x0c20 0x0 0x10>, > <0x0200 0x0 0x0c30 0x0c30 > 0x0 0xd0>; > > - interrupts = ; > + interrupts = IRQ_TYPE_LEVEL_HIGH>; > interrupt-names = "msi"; > #interrupt-cells = <1>; > interrupt-map-mask = <0 0 0 0x7>; > @@ -927,7 +928,7 @@ > ranges = <0x0100 0x0 0x0d20 > 0x0d20 0x0 0x10>, > <0x0200 0x0 0x0d30 0x0d30 > 0x0 0xd0>; > > - interrupts = ; > + interrupts = IRQ_TYPE_LEVEL_HIGH>; > interrupt-names = "msi"; > #interrupt-cells = <1>; > interrupt-map-mask = <0 0 0 0x7>; > @@ -980,7 +981,7 @@ > > device_type = "pci"; > > - interrupts = ; > + interrupts = IRQ_TYPE_LEVEL_HIGH>; > interrupt-names = "msi"; > #interrupt-cells = <1>; > interrupt-map-mask = <0 0 0 0x7>;
[PATCH] arm64: dts: msm8996: fix gic_irq_domain_translate warnings
Remove the usage of IRQ_TYPE_NONE to fix loud warnings from patch (83a86fbb5b56b "irqchip/gic: Loudly complain about the use of IRQ_TYPE_NONE"). Signed-off-by: Thierry Escande--- arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 410ae787ebb4..1aaf1fa2604e 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -437,7 +437,7 @@ blsp2_i2c0: i2c@75b5000 { compatible = "qcom,i2c-qup-v2.2.1"; reg = <0x075b5000 0x1000>; - interrupts = ; + interrupts = ; clocks = < GCC_BLSP2_AHB_CLK>, < GCC_BLSP2_QUP1_I2C_APPS_CLK>; clock-names = "iface", "core"; @@ -468,7 +468,7 @@ blsp2_i2c1: i2c@75b6000 { compatible = "qcom,i2c-qup-v2.2.1"; reg = <0x075b6000 0x1000>; - interrupts = ; + interrupts = ; clocks = < GCC_BLSP2_AHB_CLK>, < GCC_BLSP2_QUP2_I2C_APPS_CLK>; clock-names = "iface", "core"; @@ -493,7 +493,7 @@ blsp1_i2c2: i2c@7577000 { compatible = "qcom,i2c-qup-v2.2.1"; reg = <0x07577000 0x1000>; - interrupts = ; + interrupts = ; clocks = < GCC_BLSP1_AHB_CLK>, < GCC_BLSP1_QUP3_I2C_APPS_CLK>; clock-names = "iface", "core"; @@ -526,7 +526,8 @@ reg = <0x74a4900 0x314>, <0x74a4000 0x800>; reg-names = "hc_mem", "core_mem"; -interrupts = <0 125 0>, <0 221 0>; +interrupts = <0 125 IRQ_TYPE_LEVEL_HIGH>, + <0 221 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "hc_irq", "pwr_irq"; clock-names = "iface", "core", "xo"; @@ -809,7 +810,7 @@ dwc3@760 { compatible = "snps,dwc3"; reg = <0x760 0xcc00>; - interrupts = <0 138 0>; + interrupts = <0 138 IRQ_TYPE_LEVEL_HIGH>; phys = <_phy2>; phy-names = "usb2-phy"; }; @@ -838,7 +839,7 @@ dwc3@6a0 { compatible = "snps,dwc3"; reg = <0x6a0 0xcc00>; - interrupts = <0 131 0>; + interrupts = <0 131 IRQ_TYPE_LEVEL_HIGH>; phys = <_phy1>, <_phy_0>; phy-names = "usb2-phy", "usb3-phy"; }; @@ -872,7 +873,7 @@ ranges = <0x0100 0x0 0x0c20 0x0c20 0x0 0x10>, <0x0200 0x0 0x0c30 0x0c30 0x0 0xd0>; - interrupts = ; + interrupts = ; interrupt-names = "msi"; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0x7>; @@ -927,7 +928,7 @@ ranges = <0x0100 0x0 0x0d20 0x0d20 0x0 0x10>, <0x0200 0x0 0x0d30 0x0d30 0x0 0xd0>; - interrupts = ; + interrupts = ; interrupt-names = "msi"; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0x7>; @@ -980,7 +981,7 @@ device_type = "pci"; - interrupts = ; + interrupts = ; interrupt-names = "msi"; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0x7>; -- 2.14.1
[PATCH] arm64: dts: msm8996: fix gic_irq_domain_translate warnings
Remove the usage of IRQ_TYPE_NONE to fix loud warnings from patch (83a86fbb5b56b "irqchip/gic: Loudly complain about the use of IRQ_TYPE_NONE"). Signed-off-by: Thierry Escande --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 410ae787ebb4..1aaf1fa2604e 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -437,7 +437,7 @@ blsp2_i2c0: i2c@75b5000 { compatible = "qcom,i2c-qup-v2.2.1"; reg = <0x075b5000 0x1000>; - interrupts = ; + interrupts = ; clocks = < GCC_BLSP2_AHB_CLK>, < GCC_BLSP2_QUP1_I2C_APPS_CLK>; clock-names = "iface", "core"; @@ -468,7 +468,7 @@ blsp2_i2c1: i2c@75b6000 { compatible = "qcom,i2c-qup-v2.2.1"; reg = <0x075b6000 0x1000>; - interrupts = ; + interrupts = ; clocks = < GCC_BLSP2_AHB_CLK>, < GCC_BLSP2_QUP2_I2C_APPS_CLK>; clock-names = "iface", "core"; @@ -493,7 +493,7 @@ blsp1_i2c2: i2c@7577000 { compatible = "qcom,i2c-qup-v2.2.1"; reg = <0x07577000 0x1000>; - interrupts = ; + interrupts = ; clocks = < GCC_BLSP1_AHB_CLK>, < GCC_BLSP1_QUP3_I2C_APPS_CLK>; clock-names = "iface", "core"; @@ -526,7 +526,8 @@ reg = <0x74a4900 0x314>, <0x74a4000 0x800>; reg-names = "hc_mem", "core_mem"; -interrupts = <0 125 0>, <0 221 0>; +interrupts = <0 125 IRQ_TYPE_LEVEL_HIGH>, + <0 221 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "hc_irq", "pwr_irq"; clock-names = "iface", "core", "xo"; @@ -809,7 +810,7 @@ dwc3@760 { compatible = "snps,dwc3"; reg = <0x760 0xcc00>; - interrupts = <0 138 0>; + interrupts = <0 138 IRQ_TYPE_LEVEL_HIGH>; phys = <_phy2>; phy-names = "usb2-phy"; }; @@ -838,7 +839,7 @@ dwc3@6a0 { compatible = "snps,dwc3"; reg = <0x6a0 0xcc00>; - interrupts = <0 131 0>; + interrupts = <0 131 IRQ_TYPE_LEVEL_HIGH>; phys = <_phy1>, <_phy_0>; phy-names = "usb2-phy", "usb3-phy"; }; @@ -872,7 +873,7 @@ ranges = <0x0100 0x0 0x0c20 0x0c20 0x0 0x10>, <0x0200 0x0 0x0c30 0x0c30 0x0 0xd0>; - interrupts = ; + interrupts = ; interrupt-names = "msi"; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0x7>; @@ -927,7 +928,7 @@ ranges = <0x0100 0x0 0x0d20 0x0d20 0x0 0x10>, <0x0200 0x0 0x0d30 0x0d30 0x0 0xd0>; - interrupts = ; + interrupts = ; interrupt-names = "msi"; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0x7>; @@ -980,7 +981,7 @@ device_type = "pci"; - interrupts = ; + interrupts = ; interrupt-names = "msi"; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0x7>; -- 2.14.1