Re: [PATCH] asmlinkage tag for sys_iopl
On Sun, Feb 03, 2013 at 11:44:22PM +0400, Artem Savkov wrote: > On Sun, Feb 03, 2013 at 07:04:35PM +, Al Viro wrote: > > On Sun, Feb 03, 2013 at 07:59:12PM +0100, Ingo Molnar wrote: > > > > > > * Artem Savkov wrote: > > > > > > > asmlinkage tag seems to be missing from sys_iopl prototype rendering > > > > iopl > > > > syscalls unusable, i.e. every call returns -EINVAL. Most likely > > > > introduced in > > > > 9e0b2428bc6a6c6df90bb701ca843820727cadf0. > > > > > > What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's > > > certainly not upstream nor in the x86 tree. > > > > It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). I'll push it > > tonight. > > It is also in linux-next.git, so it would be nice to have a fix merged > there too. > Thanks. linux-next pulls signal.git, which is how that commit has appeared there in the first place... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] asmlinkage tag for sys_iopl
On Sun, Feb 03, 2013 at 11:44:22PM +0400, Artem Savkov wrote: On Sun, Feb 03, 2013 at 07:04:35PM +, Al Viro wrote: On Sun, Feb 03, 2013 at 07:59:12PM +0100, Ingo Molnar wrote: * Artem Savkov artem.sav...@gmail.com wrote: asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in 9e0b2428bc6a6c6df90bb701ca843820727cadf0. What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's certainly not upstream nor in the x86 tree. It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). I'll push it tonight. It is also in linux-next.git, so it would be nice to have a fix merged there too. Thanks. linux-next pulls signal.git, which is how that commit has appeared there in the first place... -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] asmlinkage tag for sys_iopl
On Sun, Feb 03, 2013 at 07:04:35PM +, Al Viro wrote: > On Sun, Feb 03, 2013 at 07:59:12PM +0100, Ingo Molnar wrote: > > > > * Artem Savkov wrote: > > > > > asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl > > > syscalls unusable, i.e. every call returns -EINVAL. Most likely > > > introduced in > > > 9e0b2428bc6a6c6df90bb701ca843820727cadf0. > > > > What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's > > certainly not upstream nor in the x86 tree. > > It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). I'll push it > tonight. It is also in linux-next.git, so it would be nice to have a fix merged there too. Thanks. -- Kind regards, Artem -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] asmlinkage tag for sys_iopl
* Al Viro wrote: > On Sun, Feb 03, 2013 at 07:59:12PM +0100, Ingo Molnar wrote: > > > > * Artem Savkov wrote: > > > > > asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl > > > syscalls unusable, i.e. every call returns -EINVAL. Most likely > > > introduced in > > > 9e0b2428bc6a6c6df90bb701ca843820727cadf0. > > > > What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's > > certainly not upstream nor in the x86 tree. > > It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). > I'll push it tonight. Thanks! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] asmlinkage tag for sys_iopl
On Sun, Feb 03, 2013 at 07:59:12PM +0100, Ingo Molnar wrote: > > * Artem Savkov wrote: > > > asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl > > syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced > > in > > 9e0b2428bc6a6c6df90bb701ca843820727cadf0. > > What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's > certainly not upstream nor in the x86 tree. It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). I'll push it tonight. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] asmlinkage tag for sys_iopl
* Artem Savkov wrote: > asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl > syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in > 9e0b2428bc6a6c6df90bb701ca843820727cadf0. What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's certainly not upstream nor in the x86 tree. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] asmlinkage tag for sys_iopl
asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl
syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in
9e0b2428bc6a6c6df90bb701ca843820727cadf0.
Signed-off-by: Artem Savkov
---
arch/x86/include/asm/syscalls.h | 2 +-
arch/x86/kernel/ioport.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/syscalls.h b/arch/x86/include/asm/syscalls.h
index 13f078c..6cf0a9c 100644
--- a/arch/x86/include/asm/syscalls.h
+++ b/arch/x86/include/asm/syscalls.h
@@ -18,7 +18,7 @@
/* Common in X86_32 and X86_64 */
/* kernel/ioport.c */
asmlinkage long sys_ioperm(unsigned long, unsigned long, int);
-long sys_iopl(unsigned int);
+asmlinkage long sys_iopl(unsigned int);
/* kernel/ldt.c */
asmlinkage int sys_modify_ldt(int, void __user *, unsigned long);
diff --git a/arch/x86/kernel/ioport.c b/arch/x86/kernel/ioport.c
index 5f98381..b1127a0 100644
--- a/arch/x86/kernel/ioport.c
+++ b/arch/x86/kernel/ioport.c
@@ -93,7 +93,7 @@ asmlinkage long sys_ioperm(unsigned long from, unsigned long
num, int turn_on)
* on system-call entry - see also fork() and the signal handling
* code.
*/
-long sys_iopl(unsigned int level)
+asmlinkage long sys_iopl(unsigned int level)
{
struct pt_regs *regs = current_pt_regs();
unsigned int old = (regs->flags >> 12) & 3;
--
1.8.1.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] asmlinkage tag for sys_iopl
asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl
syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in
9e0b2428bc6a6c6df90bb701ca843820727cadf0.
Signed-off-by: Artem Savkov artem.sav...@gmail.com
---
arch/x86/include/asm/syscalls.h | 2 +-
arch/x86/kernel/ioport.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/syscalls.h b/arch/x86/include/asm/syscalls.h
index 13f078c..6cf0a9c 100644
--- a/arch/x86/include/asm/syscalls.h
+++ b/arch/x86/include/asm/syscalls.h
@@ -18,7 +18,7 @@
/* Common in X86_32 and X86_64 */
/* kernel/ioport.c */
asmlinkage long sys_ioperm(unsigned long, unsigned long, int);
-long sys_iopl(unsigned int);
+asmlinkage long sys_iopl(unsigned int);
/* kernel/ldt.c */
asmlinkage int sys_modify_ldt(int, void __user *, unsigned long);
diff --git a/arch/x86/kernel/ioport.c b/arch/x86/kernel/ioport.c
index 5f98381..b1127a0 100644
--- a/arch/x86/kernel/ioport.c
+++ b/arch/x86/kernel/ioport.c
@@ -93,7 +93,7 @@ asmlinkage long sys_ioperm(unsigned long from, unsigned long
num, int turn_on)
* on system-call entry - see also fork() and the signal handling
* code.
*/
-long sys_iopl(unsigned int level)
+asmlinkage long sys_iopl(unsigned int level)
{
struct pt_regs *regs = current_pt_regs();
unsigned int old = (regs-flags 12) 3;
--
1.8.1.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] asmlinkage tag for sys_iopl
* Artem Savkov artem.sav...@gmail.com wrote: asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in 9e0b2428bc6a6c6df90bb701ca843820727cadf0. What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's certainly not upstream nor in the x86 tree. Thanks, Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] asmlinkage tag for sys_iopl
On Sun, Feb 03, 2013 at 07:59:12PM +0100, Ingo Molnar wrote: * Artem Savkov artem.sav...@gmail.com wrote: asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in 9e0b2428bc6a6c6df90bb701ca843820727cadf0. What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's certainly not upstream nor in the x86 tree. It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). I'll push it tonight. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] asmlinkage tag for sys_iopl
* Al Viro v...@zeniv.linux.org.uk wrote: On Sun, Feb 03, 2013 at 07:59:12PM +0100, Ingo Molnar wrote: * Artem Savkov artem.sav...@gmail.com wrote: asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in 9e0b2428bc6a6c6df90bb701ca843820727cadf0. What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's certainly not upstream nor in the x86 tree. It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). I'll push it tonight. Thanks! Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] asmlinkage tag for sys_iopl
On Sun, Feb 03, 2013 at 07:04:35PM +, Al Viro wrote: On Sun, Feb 03, 2013 at 07:59:12PM +0100, Ingo Molnar wrote: * Artem Savkov artem.sav...@gmail.com wrote: asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in 9e0b2428bc6a6c6df90bb701ca843820727cadf0. What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's certainly not upstream nor in the x86 tree. It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). I'll push it tonight. It is also in linux-next.git, so it would be nice to have a fix merged there too. Thanks. -- Kind regards, Artem -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
