Re: [PATCH] ath10k: remove h from printk format specifier

2021-02-03 Thread Kalle Valo
t...@redhat.com wrote:

> This change fixes the checkpatch warning described in this commit
> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
>   unnecessary %h[xudi] and %hh[xudi]")
> 
> Standard integer promotion is already done and %hx and %hhx is useless
> so do not encourage the use of %hh[xudi] or %h[xudi].
> 
> Signed-off-by: Tom Rix 
> Signed-off-by: Kalle Valo 

Patch applied to ath-next branch of ath.git, thanks.

779750bb153d ath10k: remove h from printk format specifier

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210127222344.2445641-1-t...@redhat.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



[PATCH] ath10k: remove h from printk format specifier

2021-01-27 Thread trix
From: Tom Rix 

This change fixes the checkpatch warning described in this commit
commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
  unnecessary %h[xudi] and %hh[xudi]")

Standard integer promotion is already done and %hx and %hhx is useless
so do not encourage the use of %hh[xudi] or %h[xudi].

Signed-off-by: Tom Rix 
---
 drivers/net/wireless/ath/ath10k/htt_rx.c  | 32 +++
 drivers/net/wireless/ath/ath10k/htt_tx.c  | 12 -
 drivers/net/wireless/ath/ath10k/mac.c | 12 -
 drivers/net/wireless/ath/ath10k/trace.h   |  4 +--
 drivers/net/wireless/ath/ath10k/txrx.c|  4 +--
 drivers/net/wireless/ath/ath10k/wmi-tlv.c |  6 ++---
 drivers/net/wireless/ath/ath10k/wmi.c |  2 +-
 7 files changed, 36 insertions(+), 36 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c 
b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 9c4e6cf2137a..1a08156d5011 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -2781,13 +2781,13 @@ static void ath10k_htt_rx_addba(struct ath10k *ar, 
struct htt_resp *resp)
peer_id = MS(info0, HTT_RX_BA_INFO0_PEER_ID);
 
ath10k_dbg(ar, ATH10K_DBG_HTT,
-  "htt rx addba tid %hu peer_id %hu size %hhu\n",
+  "htt rx addba tid %u peer_id %u size %u\n",
   tid, peer_id, ev->window_size);
 
spin_lock_bh(>data_lock);
peer = ath10k_peer_find_by_id(ar, peer_id);
if (!peer) {
-   ath10k_warn(ar, "received addba event for invalid peer_id: 
%hu\n",
+   ath10k_warn(ar, "received addba event for invalid peer_id: 
%u\n",
peer_id);
spin_unlock_bh(>data_lock);
return;
@@ -2802,7 +2802,7 @@ static void ath10k_htt_rx_addba(struct ath10k *ar, struct 
htt_resp *resp)
}
 
ath10k_dbg(ar, ATH10K_DBG_HTT,
-  "htt rx start rx ba session sta %pM tid %hu size %hhu\n",
+  "htt rx start rx ba session sta %pM tid %u size %u\n",
   peer->addr, tid, ev->window_size);
 
ieee80211_start_rx_ba_session_offl(arvif->vif, peer->addr, tid);
@@ -2821,13 +2821,13 @@ static void ath10k_htt_rx_delba(struct ath10k *ar, 
struct htt_resp *resp)
peer_id = MS(info0, HTT_RX_BA_INFO0_PEER_ID);
 
ath10k_dbg(ar, ATH10K_DBG_HTT,
-  "htt rx delba tid %hu peer_id %hu\n",
+  "htt rx delba tid %u peer_id %u\n",
   tid, peer_id);
 
spin_lock_bh(>data_lock);
peer = ath10k_peer_find_by_id(ar, peer_id);
if (!peer) {
-   ath10k_warn(ar, "received addba event for invalid peer_id: 
%hu\n",
+   ath10k_warn(ar, "received addba event for invalid peer_id: 
%u\n",
peer_id);
spin_unlock_bh(>data_lock);
return;
@@ -2842,7 +2842,7 @@ static void ath10k_htt_rx_delba(struct ath10k *ar, struct 
htt_resp *resp)
}
 
ath10k_dbg(ar, ATH10K_DBG_HTT,
-  "htt rx stop rx ba session sta %pM tid %hu\n",
+  "htt rx stop rx ba session sta %pM tid %u\n",
   peer->addr, tid);
 
ieee80211_stop_rx_ba_session_offl(arvif->vif, peer->addr, tid);
@@ -3102,7 +3102,7 @@ static void ath10k_htt_rx_tx_fetch_ind(struct ath10k *ar, 
struct sk_buff *skb)
return;
}
 
-   ath10k_dbg(ar, ATH10K_DBG_HTT, "htt rx tx fetch ind num records %hu num 
resps %hu seq %hu\n",
+   ath10k_dbg(ar, ATH10K_DBG_HTT, "htt rx tx fetch ind num records %u num 
resps %u seq %u\n",
   num_records, num_resp_ids,
   le16_to_cpu(resp->tx_fetch_ind.fetch_seq_num));
 
@@ -3127,12 +3127,12 @@ static void ath10k_htt_rx_tx_fetch_ind(struct ath10k 
*ar, struct sk_buff *skb)
max_num_msdus = le16_to_cpu(record->num_msdus);
max_num_bytes = le32_to_cpu(record->num_bytes);
 
-   ath10k_dbg(ar, ATH10K_DBG_HTT, "htt rx tx fetch record %i 
peer_id %hu tid %hhu msdus %zu bytes %zu\n",
+   ath10k_dbg(ar, ATH10K_DBG_HTT, "htt rx tx fetch record %i 
peer_id %u tid %u msdus %zu bytes %zu\n",
   i, peer_id, tid, max_num_msdus, max_num_bytes);
 
if (unlikely(peer_id >= ar->htt.tx_q_state.num_peers) ||
unlikely(tid >= ar->htt.tx_q_state.num_tids)) {
-   ath10k_warn(ar, "received out of range peer_id %hu tid 
%hhu\n",
+   ath10k_warn(ar, "received out of range peer_id %u tid 
%u\n",
peer_id, tid);
continue;
}
@@ -3146,7 +3146,7 @@ static void ath10k_htt_rx_tx_fetch_ind(struct ath10k *ar, 
struct sk_buff *skb)
 */
 
if (unlikely(!txq)) {
-   ath10k_warn(ar, "failed to lookup txq for peer_id %hu 
tid