Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Tue, Feb 20, 2018 at 8:41 AM, Philippe Ombredannewrote: > On Sun, Feb 18, 2018 at 9:18 PM, Joe Perches wrote: >> On Sun, 2018-02-18 at 20:37 +0100, Geert Uytterhoeven wrote: >>> Hi Philippe, >>> >>> On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne >>> wrote: >>> > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda >>> > wrote: >>> > > Cc: Willy Tarreau >>> > > Cc: Geert Uytterhoeven >>> > > Cc: Linus Walleij >>> > > Cc: Robin van der Gracht >>> > > Cc: Paul Burton >>> > > Signed-off-by: Miguel Ojeda >>> > > --- Pinging Paul Burton in a couple of emails more... Cheers, Miguel
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Tue, Feb 20, 2018 at 8:41 AM, Philippe Ombredanne wrote: > On Sun, Feb 18, 2018 at 9:18 PM, Joe Perches wrote: >> On Sun, 2018-02-18 at 20:37 +0100, Geert Uytterhoeven wrote: >>> Hi Philippe, >>> >>> On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne >>> wrote: >>> > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda >>> > wrote: >>> > > Cc: Willy Tarreau >>> > > Cc: Geert Uytterhoeven >>> > > Cc: Linus Walleij >>> > > Cc: Robin van der Gracht >>> > > Cc: Paul Burton >>> > > Signed-off-by: Miguel Ojeda >>> > > --- Pinging Paul Burton in a couple of emails more... Cheers, Miguel
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Sun, Feb 18, 2018 at 9:18 PM, Joe Percheswrote: > On Sun, 2018-02-18 at 20:37 +0100, Geert Uytterhoeven wrote: >> Hi Philippe, >> >> On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne >> wrote: >> > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda >> > wrote: >> > > Cc: Willy Tarreau >> > > Cc: Geert Uytterhoeven >> > > Cc: Linus Walleij >> > > Cc: Robin van der Gracht >> > > Cc: Paul Burton >> > > Signed-off-by: Miguel Ojeda >> > > --- >> > >> > >> > >> > > diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h >> > > index b454dfce60d9..aa960efc32f6 100644 >> > > --- a/include/linux/cfag12864b.h >> > > +++ b/include/linux/cfag12864b.h >> > > @@ -1,25 +1,11 @@ >> > > +// SPDX-License-Identifier: GPL-2.0 >> > >> > Per the doc [1] you should be using instead this in a .h: >> > /* SPDX-License-Identifier: GPL-2.0 */ >> > >> > I know this can be surprising. This has been discussed on list quite >> > lot and the doc has some rationale. >> > >> > >> > >> > > diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h >> > > index cb311798e0bc..2a1c985fedea 100644 >> > > --- a/include/linux/ks0108.h >> > > +++ b/include/linux/ks0108.h >> > > @@ -1,25 +1,11 @@ >> > > +// SPDX-License-Identifier: GPL-2.0 >> > >> > Same comment as above. >> > >> > [1] >> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst >> > >> >> Obviously we need a check in scripts/checkpatch.pl, to catch this >> before submission... >> >> Care to send a patch? > > There's one already in progress. > https://lkml.org/lkml/2018/2/8/712 > And I will try to help there as much as I can. Time to dust off my Perl! -- Cordially Philippe Ombredanne
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Sun, Feb 18, 2018 at 9:18 PM, Joe Perches wrote: > On Sun, 2018-02-18 at 20:37 +0100, Geert Uytterhoeven wrote: >> Hi Philippe, >> >> On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne >> wrote: >> > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda >> > wrote: >> > > Cc: Willy Tarreau >> > > Cc: Geert Uytterhoeven >> > > Cc: Linus Walleij >> > > Cc: Robin van der Gracht >> > > Cc: Paul Burton >> > > Signed-off-by: Miguel Ojeda >> > > --- >> > >> > >> > >> > > diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h >> > > index b454dfce60d9..aa960efc32f6 100644 >> > > --- a/include/linux/cfag12864b.h >> > > +++ b/include/linux/cfag12864b.h >> > > @@ -1,25 +1,11 @@ >> > > +// SPDX-License-Identifier: GPL-2.0 >> > >> > Per the doc [1] you should be using instead this in a .h: >> > /* SPDX-License-Identifier: GPL-2.0 */ >> > >> > I know this can be surprising. This has been discussed on list quite >> > lot and the doc has some rationale. >> > >> > >> > >> > > diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h >> > > index cb311798e0bc..2a1c985fedea 100644 >> > > --- a/include/linux/ks0108.h >> > > +++ b/include/linux/ks0108.h >> > > @@ -1,25 +1,11 @@ >> > > +// SPDX-License-Identifier: GPL-2.0 >> > >> > Same comment as above. >> > >> > [1] >> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst >> > >> >> Obviously we need a check in scripts/checkpatch.pl, to catch this >> before submission... >> >> Care to send a patch? > > There's one already in progress. > https://lkml.org/lkml/2018/2/8/712 > And I will try to help there as much as I can. Time to dust off my Perl! -- Cordially Philippe Ombredanne
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Mon, 19 Feb 2018 08:44:17 +0100 Robin van der Grachtwrote: > On Sat, 17 Feb 2018 20:39:55 +0100 > Miguel Ojeda wrote: > > > Cc: Willy Tarreau > > Cc: Geert Uytterhoeven > > Cc: Linus Walleij > > Cc: Robin van der Gracht > > Cc: Paul Burton > > Signed-off-by: Miguel Ojeda > > --- > > Please let me know if you agree for your files and I will queue it up. > > Thanks! > > ... > > > > > #include > > diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c > > index fbfa5b4cc567..a43276c76fc6 100644 > > --- a/drivers/auxdisplay/ht16k33.c > > +++ b/drivers/auxdisplay/ht16k33.c > > @@ -1,18 +1,10 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > /* > > * HT16K33 driver > > * > > * Author: Robin van der Gracht > > * > > * Copyright: (C) 2016 Protonic Holland. > > - * > > - * This program is free software; you can redistribute it and/or modify > > - * it under the terms of the GNU General Public License version 2 as > > - * published by the Free Software Foundation. > > - * > > - * This program is distributed in the hope that it will be useful, but > > - * WITHOUT ANY WARRANTY; without even the implied warranty of > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > - * General Public License for more details. > > */ > > > > Signed-off-by: Robin van der Gracht Change to: Acked-by: Robin van der Gracht Best regards, / vriendelijke groet, -- Robin van der Gracht Protonic Holland tel.: +31 (0) 229 212928 fax.: +31 (0) 229 210930 Factorij 36 / 1689 AL Zwaag
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Mon, 19 Feb 2018 08:44:17 +0100 Robin van der Gracht wrote: > On Sat, 17 Feb 2018 20:39:55 +0100 > Miguel Ojeda wrote: > > > Cc: Willy Tarreau > > Cc: Geert Uytterhoeven > > Cc: Linus Walleij > > Cc: Robin van der Gracht > > Cc: Paul Burton > > Signed-off-by: Miguel Ojeda > > --- > > Please let me know if you agree for your files and I will queue it up. > > Thanks! > > ... > > > > > #include > > diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c > > index fbfa5b4cc567..a43276c76fc6 100644 > > --- a/drivers/auxdisplay/ht16k33.c > > +++ b/drivers/auxdisplay/ht16k33.c > > @@ -1,18 +1,10 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > /* > > * HT16K33 driver > > * > > * Author: Robin van der Gracht > > * > > * Copyright: (C) 2016 Protonic Holland. > > - * > > - * This program is free software; you can redistribute it and/or modify > > - * it under the terms of the GNU General Public License version 2 as > > - * published by the Free Software Foundation. > > - * > > - * This program is distributed in the hope that it will be useful, but > > - * WITHOUT ANY WARRANTY; without even the implied warranty of > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > - * General Public License for more details. > > */ > > > > Signed-off-by: Robin van der Gracht Change to: Acked-by: Robin van der Gracht Best regards, / vriendelijke groet, -- Robin van der Gracht Protonic Holland tel.: +31 (0) 229 212928 fax.: +31 (0) 229 210930 Factorij 36 / 1689 AL Zwaag
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Sat, 17 Feb 2018 20:39:55 +0100 Miguel Ojedawrote: > Cc: Willy Tarreau > Cc: Geert Uytterhoeven > Cc: Linus Walleij > Cc: Robin van der Gracht > Cc: Paul Burton > Signed-off-by: Miguel Ojeda > --- > Please let me know if you agree for your files and I will queue it up. > Thanks! ... > > #include > diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c > index fbfa5b4cc567..a43276c76fc6 100644 > --- a/drivers/auxdisplay/ht16k33.c > +++ b/drivers/auxdisplay/ht16k33.c > @@ -1,18 +1,10 @@ > +// SPDX-License-Identifier: GPL-2.0 > /* > * HT16K33 driver > * > * Author: Robin van der Gracht > * > * Copyright: (C) 2016 Protonic Holland. > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - * > - * This program is distributed in the hope that it will be useful, but > - * WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - * General Public License for more details. > */ > Signed-off-by: Robin van der Gracht Best regards, / vriendelijke groet, -- Robin van der Gracht Protonic Holland tel.: +31 (0) 229 212928 fax.: +31 (0) 229 210930 Factorij 36 / 1689 AL Zwaag
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Sat, 17 Feb 2018 20:39:55 +0100 Miguel Ojeda wrote: > Cc: Willy Tarreau > Cc: Geert Uytterhoeven > Cc: Linus Walleij > Cc: Robin van der Gracht > Cc: Paul Burton > Signed-off-by: Miguel Ojeda > --- > Please let me know if you agree for your files and I will queue it up. > Thanks! ... > > #include > diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c > index fbfa5b4cc567..a43276c76fc6 100644 > --- a/drivers/auxdisplay/ht16k33.c > +++ b/drivers/auxdisplay/ht16k33.c > @@ -1,18 +1,10 @@ > +// SPDX-License-Identifier: GPL-2.0 > /* > * HT16K33 driver > * > * Author: Robin van der Gracht > * > * Copyright: (C) 2016 Protonic Holland. > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - * > - * This program is distributed in the hope that it will be useful, but > - * WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - * General Public License for more details. > */ > Signed-off-by: Robin van der Gracht Best regards, / vriendelijke groet, -- Robin van der Gracht Protonic Holland tel.: +31 (0) 229 212928 fax.: +31 (0) 229 210930 Factorij 36 / 1689 AL Zwaag
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojedawrote: > Signed-off-by: Miguel Ojeda For: > drivers/auxdisplay/hd44780.c| 6 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda wrote: > Signed-off-by: Miguel Ojeda For: > drivers/auxdisplay/hd44780.c| 6 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Sun, 2018-02-18 at 20:37 +0100, Geert Uytterhoeven wrote: > Hi Philippe, > > On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne >wrote: > > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda > > wrote: > > > Cc: Willy Tarreau > > > Cc: Geert Uytterhoeven > > > Cc: Linus Walleij > > > Cc: Robin van der Gracht > > > Cc: Paul Burton > > > Signed-off-by: Miguel Ojeda > > > --- > > > > > > > > > diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h > > > index b454dfce60d9..aa960efc32f6 100644 > > > --- a/include/linux/cfag12864b.h > > > +++ b/include/linux/cfag12864b.h > > > @@ -1,25 +1,11 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > > Per the doc [1] you should be using instead this in a .h: > > /* SPDX-License-Identifier: GPL-2.0 */ > > > > I know this can be surprising. This has been discussed on list quite > > lot and the doc has some rationale. > > > > > > > > > diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h > > > index cb311798e0bc..2a1c985fedea 100644 > > > --- a/include/linux/ks0108.h > > > +++ b/include/linux/ks0108.h > > > @@ -1,25 +1,11 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > > Same comment as above. > > > > [1] > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst > > > > Obviously we need a check in scripts/checkpatch.pl, to catch this > before submission... > > Care to send a patch? There's one already in progress. https://lkml.org/lkml/2018/2/8/712
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Sun, 2018-02-18 at 20:37 +0100, Geert Uytterhoeven wrote: > Hi Philippe, > > On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne > wrote: > > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda > > wrote: > > > Cc: Willy Tarreau > > > Cc: Geert Uytterhoeven > > > Cc: Linus Walleij > > > Cc: Robin van der Gracht > > > Cc: Paul Burton > > > Signed-off-by: Miguel Ojeda > > > --- > > > > > > > > > diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h > > > index b454dfce60d9..aa960efc32f6 100644 > > > --- a/include/linux/cfag12864b.h > > > +++ b/include/linux/cfag12864b.h > > > @@ -1,25 +1,11 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > > Per the doc [1] you should be using instead this in a .h: > > /* SPDX-License-Identifier: GPL-2.0 */ > > > > I know this can be surprising. This has been discussed on list quite > > lot and the doc has some rationale. > > > > > > > > > diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h > > > index cb311798e0bc..2a1c985fedea 100644 > > > --- a/include/linux/ks0108.h > > > +++ b/include/linux/ks0108.h > > > @@ -1,25 +1,11 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > > Same comment as above. > > > > [1] > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst > > > > Obviously we need a check in scripts/checkpatch.pl, to catch this > before submission... > > Care to send a patch? There's one already in progress. https://lkml.org/lkml/2018/2/8/712
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredannewrote: > Miguel, > > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda > wrote: >> Cc: Willy Tarreau >> Cc: Geert Uytterhoeven >> Cc: Linus Walleij >> Cc: Robin van der Gracht >> Cc: Paul Burton >> Signed-off-by: Miguel Ojeda >> --- > > > >> diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h >> index b454dfce60d9..aa960efc32f6 100644 >> --- a/include/linux/cfag12864b.h >> +++ b/include/linux/cfag12864b.h >> @@ -1,25 +1,11 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > Per the doc [1] you should be using instead this in a .h: > /* SPDX-License-Identifier: GPL-2.0 */ > > I know this can be surprising. This has been discussed on list quite > lot and the doc has some rationale. Thanks for taking the time to check the patch. It was a mistake on my side -- I had actually read the docs but I recalled Linus talking about moving to // at some point (and somehow my brain recorded that the discussion was about the headers :-), so I thought I was actually doing the right thing by using // already. Don't worry, I will fix it when I put it in the queue. Cheers, Miguel > > > >> diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h >> index cb311798e0bc..2a1c985fedea 100644 >> --- a/include/linux/ks0108.h >> +++ b/include/linux/ks0108.h >> @@ -1,25 +1,11 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > Same comment as above. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst > > -- > Cordially > Philippe Ombredanne
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne wrote: > Miguel, > > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda > wrote: >> Cc: Willy Tarreau >> Cc: Geert Uytterhoeven >> Cc: Linus Walleij >> Cc: Robin van der Gracht >> Cc: Paul Burton >> Signed-off-by: Miguel Ojeda >> --- > > > >> diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h >> index b454dfce60d9..aa960efc32f6 100644 >> --- a/include/linux/cfag12864b.h >> +++ b/include/linux/cfag12864b.h >> @@ -1,25 +1,11 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > Per the doc [1] you should be using instead this in a .h: > /* SPDX-License-Identifier: GPL-2.0 */ > > I know this can be surprising. This has been discussed on list quite > lot and the doc has some rationale. Thanks for taking the time to check the patch. It was a mistake on my side -- I had actually read the docs but I recalled Linus talking about moving to // at some point (and somehow my brain recorded that the discussion was about the headers :-), so I thought I was actually doing the right thing by using // already. Don't worry, I will fix it when I put it in the queue. Cheers, Miguel > > > >> diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h >> index cb311798e0bc..2a1c985fedea 100644 >> --- a/include/linux/ks0108.h >> +++ b/include/linux/ks0108.h >> @@ -1,25 +1,11 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > Same comment as above. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst > > -- > Cordially > Philippe Ombredanne
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
Hi Philippe, On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredannewrote: > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda > wrote: >> Cc: Willy Tarreau >> Cc: Geert Uytterhoeven >> Cc: Linus Walleij >> Cc: Robin van der Gracht >> Cc: Paul Burton >> Signed-off-by: Miguel Ojeda >> --- > > > >> diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h >> index b454dfce60d9..aa960efc32f6 100644 >> --- a/include/linux/cfag12864b.h >> +++ b/include/linux/cfag12864b.h >> @@ -1,25 +1,11 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > Per the doc [1] you should be using instead this in a .h: > /* SPDX-License-Identifier: GPL-2.0 */ > > I know this can be surprising. This has been discussed on list quite > lot and the doc has some rationale. > > > >> diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h >> index cb311798e0bc..2a1c985fedea 100644 >> --- a/include/linux/ks0108.h >> +++ b/include/linux/ks0108.h >> @@ -1,25 +1,11 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > Same comment as above. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst > Obviously we need a check in scripts/checkpatch.pl, to catch this before submission... Care to send a patch? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
Hi Philippe, On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne wrote: > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda > wrote: >> Cc: Willy Tarreau >> Cc: Geert Uytterhoeven >> Cc: Linus Walleij >> Cc: Robin van der Gracht >> Cc: Paul Burton >> Signed-off-by: Miguel Ojeda >> --- > > > >> diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h >> index b454dfce60d9..aa960efc32f6 100644 >> --- a/include/linux/cfag12864b.h >> +++ b/include/linux/cfag12864b.h >> @@ -1,25 +1,11 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > Per the doc [1] you should be using instead this in a .h: > /* SPDX-License-Identifier: GPL-2.0 */ > > I know this can be surprising. This has been discussed on list quite > lot and the doc has some rationale. > > > >> diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h >> index cb311798e0bc..2a1c985fedea 100644 >> --- a/include/linux/ks0108.h >> +++ b/include/linux/ks0108.h >> @@ -1,25 +1,11 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > Same comment as above. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst > Obviously we need a check in scripts/checkpatch.pl, to catch this before submission... Care to send a patch? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
Miguel, On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojedawrote: > Cc: Willy Tarreau > Cc: Geert Uytterhoeven > Cc: Linus Walleij > Cc: Robin van der Gracht > Cc: Paul Burton > Signed-off-by: Miguel Ojeda > --- > diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h > index b454dfce60d9..aa960efc32f6 100644 > --- a/include/linux/cfag12864b.h > +++ b/include/linux/cfag12864b.h > @@ -1,25 +1,11 @@ > +// SPDX-License-Identifier: GPL-2.0 Per the doc [1] you should be using instead this in a .h: /* SPDX-License-Identifier: GPL-2.0 */ I know this can be surprising. This has been discussed on list quite lot and the doc has some rationale. > diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h > index cb311798e0bc..2a1c985fedea 100644 > --- a/include/linux/ks0108.h > +++ b/include/linux/ks0108.h > @@ -1,25 +1,11 @@ > +// SPDX-License-Identifier: GPL-2.0 Same comment as above. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
Miguel, On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda wrote: > Cc: Willy Tarreau > Cc: Geert Uytterhoeven > Cc: Linus Walleij > Cc: Robin van der Gracht > Cc: Paul Burton > Signed-off-by: Miguel Ojeda > --- > diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h > index b454dfce60d9..aa960efc32f6 100644 > --- a/include/linux/cfag12864b.h > +++ b/include/linux/cfag12864b.h > @@ -1,25 +1,11 @@ > +// SPDX-License-Identifier: GPL-2.0 Per the doc [1] you should be using instead this in a .h: /* SPDX-License-Identifier: GPL-2.0 */ I know this can be surprising. This has been discussed on list quite lot and the doc has some rationale. > diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h > index cb311798e0bc..2a1c985fedea 100644 > --- a/include/linux/ks0108.h > +++ b/include/linux/ks0108.h > @@ -1,25 +1,11 @@ > +// SPDX-License-Identifier: GPL-2.0 Same comment as above. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
2018-02-17 20:39 GMT+01:00 Miguel Ojeda: > Cc: Willy Tarreau > Cc: Geert Uytterhoeven > Cc: Linus Walleij > Cc: Robin van der Gracht > Cc: Paul Burton > Signed-off-by: Miguel Ojeda > --- > Please let me know if you agree for your files and I will queue it up. > Thanks! Acked-by: Linus Walleij Yours, Linus Walleij
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
2018-02-17 20:39 GMT+01:00 Miguel Ojeda : > Cc: Willy Tarreau > Cc: Geert Uytterhoeven > Cc: Linus Walleij > Cc: Robin van der Gracht > Cc: Paul Burton > Signed-off-by: Miguel Ojeda > --- > Please let me know if you agree for your files and I will queue it up. > Thanks! Acked-by: Linus Walleij Yours, Linus Walleij
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Sat, Feb 17, 2018 at 08:39:55PM +0100, Miguel Ojeda wrote: > Cc: Willy Tarreau> Cc: Geert Uytterhoeven > Cc: Linus Walleij > Cc: Robin van der Gracht > Cc: Paul Burton > Signed-off-by: Miguel Ojeda > --- > Please let me know if you agree for your files and I will queue it up. > Thanks! Ack from me. Willy
Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers
On Sat, Feb 17, 2018 at 08:39:55PM +0100, Miguel Ojeda wrote: > Cc: Willy Tarreau > Cc: Geert Uytterhoeven > Cc: Linus Walleij > Cc: Robin van der Gracht > Cc: Paul Burton > Signed-off-by: Miguel Ojeda > --- > Please let me know if you agree for your files and I will queue it up. > Thanks! Ack from me. Willy
[PATCH] auxdisplay: Replace licenses with SPDX identifiers
Cc: Willy TarreauCc: Geert Uytterhoeven Cc: Linus Walleij Cc: Robin van der Gracht Cc: Paul Burton Signed-off-by: Miguel Ojeda --- Please let me know if you agree for your files and I will queue it up. Thanks! drivers/auxdisplay/arm-charlcd.c| 2 +- drivers/auxdisplay/cfag12864b.c | 16 +--- drivers/auxdisplay/cfag12864bfb.c | 16 +--- drivers/auxdisplay/charlcd.c| 6 +- drivers/auxdisplay/hd44780.c| 6 +- drivers/auxdisplay/ht16k33.c| 10 +- drivers/auxdisplay/img-ascii-lcd.c | 6 +- drivers/auxdisplay/ks0108.c | 16 +--- drivers/auxdisplay/panel.c | 6 +- include/linux/cfag12864b.h | 16 +--- include/linux/ks0108.h | 16 +--- samples/auxdisplay/cfag12864b-example.c | 16 +--- 12 files changed, 12 insertions(+), 120 deletions(-) diff --git a/drivers/auxdisplay/arm-charlcd.c b/drivers/auxdisplay/arm-charlcd.c index b3176ee92b90..ec5bd065d0d5 100644 --- a/drivers/auxdisplay/arm-charlcd.c +++ b/drivers/auxdisplay/arm-charlcd.c @@ -1,10 +1,10 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Driver for the on-board character LCD found on some ARM reference boards * This is basically an Hitachi HD44780 LCD with a custom IP block to drive it * http://en.wikipedia.org/wiki/HD44780_Character_LCD * Currently it will just display the text "ARM Linux" and the linux version * - * License terms: GNU General Public License (GPL) version 2 * Author: Linus Walleij */ #include diff --git a/drivers/auxdisplay/cfag12864b.c b/drivers/auxdisplay/cfag12864b.c index 41ce4bd96813..6bd2f65e116a 100644 --- a/drivers/auxdisplay/cfag12864b.c +++ b/drivers/auxdisplay/cfag12864b.c @@ -1,26 +1,12 @@ +// SPDX-License-Identifier: GPL-2.0 /* *Filename: cfag12864b.c * Version: 0.1.0 * Description: cfag12864b LCD driver - * License: GPLv2 * Depends: ks0108 * * Author: Copyright (C) Miguel Ojeda Sandonis *Date: 2006-10-31 - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * */ #include diff --git a/drivers/auxdisplay/cfag12864bfb.c b/drivers/auxdisplay/cfag12864bfb.c index a3874034e2ce..898d14ca8ac8 100644 --- a/drivers/auxdisplay/cfag12864bfb.c +++ b/drivers/auxdisplay/cfag12864bfb.c @@ -1,26 +1,12 @@ +// SPDX-License-Identifier: GPL-2.0 /* *Filename: cfag12864bfb.c * Version: 0.1.0 * Description: cfag12864b LCD framebuffer driver - * License: GPLv2 * Depends: cfag12864b * * Author: Copyright (C) Miguel Ojeda Sandonis *Date: 2006-10-31 - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * */ #include diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c index 642afd88870b..dc187a7a1a67 100644 --- a/drivers/auxdisplay/charlcd.c +++ b/drivers/auxdisplay/charlcd.c @@ -1,13 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0+ /* * Character LCD driver for Linux * * Copyright (C) 2000-2008, Willy Tarreau * Copyright (C) 2016-2017 Glider bvba - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License - * as published by the Free Software Foundation; either version - * 2 of the License, or (at your option) any later version. */ #include diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c index 036eec404289..78d8f1986fec 100644 --- a/drivers/auxdisplay/hd44780.c +++ b/drivers/auxdisplay/hd44780.c @@ -1,13 +1,9
[PATCH] auxdisplay: Replace licenses with SPDX identifiers
Cc: Willy Tarreau Cc: Geert Uytterhoeven Cc: Linus Walleij Cc: Robin van der Gracht Cc: Paul Burton Signed-off-by: Miguel Ojeda --- Please let me know if you agree for your files and I will queue it up. Thanks! drivers/auxdisplay/arm-charlcd.c| 2 +- drivers/auxdisplay/cfag12864b.c | 16 +--- drivers/auxdisplay/cfag12864bfb.c | 16 +--- drivers/auxdisplay/charlcd.c| 6 +- drivers/auxdisplay/hd44780.c| 6 +- drivers/auxdisplay/ht16k33.c| 10 +- drivers/auxdisplay/img-ascii-lcd.c | 6 +- drivers/auxdisplay/ks0108.c | 16 +--- drivers/auxdisplay/panel.c | 6 +- include/linux/cfag12864b.h | 16 +--- include/linux/ks0108.h | 16 +--- samples/auxdisplay/cfag12864b-example.c | 16 +--- 12 files changed, 12 insertions(+), 120 deletions(-) diff --git a/drivers/auxdisplay/arm-charlcd.c b/drivers/auxdisplay/arm-charlcd.c index b3176ee92b90..ec5bd065d0d5 100644 --- a/drivers/auxdisplay/arm-charlcd.c +++ b/drivers/auxdisplay/arm-charlcd.c @@ -1,10 +1,10 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Driver for the on-board character LCD found on some ARM reference boards * This is basically an Hitachi HD44780 LCD with a custom IP block to drive it * http://en.wikipedia.org/wiki/HD44780_Character_LCD * Currently it will just display the text "ARM Linux" and the linux version * - * License terms: GNU General Public License (GPL) version 2 * Author: Linus Walleij */ #include diff --git a/drivers/auxdisplay/cfag12864b.c b/drivers/auxdisplay/cfag12864b.c index 41ce4bd96813..6bd2f65e116a 100644 --- a/drivers/auxdisplay/cfag12864b.c +++ b/drivers/auxdisplay/cfag12864b.c @@ -1,26 +1,12 @@ +// SPDX-License-Identifier: GPL-2.0 /* *Filename: cfag12864b.c * Version: 0.1.0 * Description: cfag12864b LCD driver - * License: GPLv2 * Depends: ks0108 * * Author: Copyright (C) Miguel Ojeda Sandonis *Date: 2006-10-31 - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * */ #include diff --git a/drivers/auxdisplay/cfag12864bfb.c b/drivers/auxdisplay/cfag12864bfb.c index a3874034e2ce..898d14ca8ac8 100644 --- a/drivers/auxdisplay/cfag12864bfb.c +++ b/drivers/auxdisplay/cfag12864bfb.c @@ -1,26 +1,12 @@ +// SPDX-License-Identifier: GPL-2.0 /* *Filename: cfag12864bfb.c * Version: 0.1.0 * Description: cfag12864b LCD framebuffer driver - * License: GPLv2 * Depends: cfag12864b * * Author: Copyright (C) Miguel Ojeda Sandonis *Date: 2006-10-31 - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * */ #include diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c index 642afd88870b..dc187a7a1a67 100644 --- a/drivers/auxdisplay/charlcd.c +++ b/drivers/auxdisplay/charlcd.c @@ -1,13 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0+ /* * Character LCD driver for Linux * * Copyright (C) 2000-2008, Willy Tarreau * Copyright (C) 2016-2017 Glider bvba - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License - * as published by the Free Software Foundation; either version - * 2 of the License, or (at your option) any later version. */ #include diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c index 036eec404289..78d8f1986fec 100644 --- a/drivers/auxdisplay/hd44780.c +++ b/drivers/auxdisplay/hd44780.c @@ -1,13 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0+ /* * HD44780 Character LCD driver for Linux * * Copyright (C) 2000-2008, Willy Tarreau * Copyright (C)