Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK
On 02/07/13 15:15, Oskar Andero wrote:
> From: Shingo Nakao
>
> When backlight turns on early from display, a white line can be
> seen on the screen. Therefore make sure backlight is off when we
> are under an fb blank event.
>
> Signed-off-by: Shingo Nakao
> Cc: Milo Kim
> Cc: Richard Purdie
> Signed-off-by: Oskar Andero
> ---
> drivers/video/backlight/lp855x_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lp855x_bl.c
> b/drivers/video/backlight/lp855x_bl.c
> index a0e1e02..c0b41f1 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct
> backlight_device *bl)
> {
> struct lp855x *lp = bl_get_data(bl);
>
> - if (bl->props.state & BL_CORE_SUSPENDED)
> + if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
> bl->props.brightness = 0;
>
> if (lp->mode == PWM_BASED) {
>
Thanks, I've applied this into my 3.12/fbdev branch.
Tomi
signature.asc
Description: OpenPGP digital signature
Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK
On 02/07/13 15:15, Oskar Andero wrote:
From: Shingo Nakao shingo.x.na...@sonymobile.com
When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.
Signed-off-by: Shingo Nakao shingo.x.na...@sonymobile.com
Cc: Milo Kim milo@ti.com
Cc: Richard Purdie rpur...@rpsys.net
Signed-off-by: Oskar Andero oskar.and...@sonymobile.com
---
drivers/video/backlight/lp855x_bl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lp855x_bl.c
b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct
backlight_device *bl)
{
struct lp855x *lp = bl_get_data(bl);
- if (bl-props.state BL_CORE_SUSPENDED)
+ if (bl-props.state (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
bl-props.brightness = 0;
if (lp-mode == PWM_BASED) {
Thanks, I've applied this into my 3.12/fbdev branch.
Tomi
signature.asc
Description: OpenPGP digital signature
Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK
On Tuesday, July 02, 2013 9:16 PM, Oskar Andero wrote:
>
> From: Shingo Nakao
>
> When backlight turns on early from display, a white line can be
> seen on the screen. Therefore make sure backlight is off when we
> are under an fb blank event.
>
> Signed-off-by: Shingo Nakao
> Cc: Milo Kim
> Cc: Richard Purdie
> Signed-off-by: Oskar Andero
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/video/backlight/lp855x_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lp855x_bl.c
> b/drivers/video/backlight/lp855x_bl.c
> index a0e1e02..c0b41f1 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct
> backlight_device *bl)
> {
> struct lp855x *lp = bl_get_data(bl);
>
> - if (bl->props.state & BL_CORE_SUSPENDED)
> + if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
> bl->props.brightness = 0;
>
> if (lp->mode == PWM_BASED) {
> --
> 1.8.1.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK
> From: Shingo Nakao
>
> When backlight turns on early from display, a white line can be
> seen on the screen. Therefore make sure backlight is off when we
> are under an fb blank event.
>
> Signed-off-by: Shingo Nakao
> Cc: Milo Kim
> Cc: Richard Purdie
> Signed-off-by: Oskar Andero
Acked-by: Milo Kim
> ---
> drivers/video/backlight/lp855x_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lp855x_bl.c
> b/drivers/video/backlight/lp855x_bl.c
> index a0e1e02..c0b41f1 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct
> backlight_device *bl)
> {
> struct lp855x *lp = bl_get_data(bl);
>
> - if (bl->props.state & BL_CORE_SUSPENDED)
> + if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
> bl->props.brightness = 0;
>
> if (lp->mode == PWM_BASED) {
> --
> 1.8.1.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] backlight: lp855x: set zero brightness at FBBLANK
From: Shingo Nakao
When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.
Signed-off-by: Shingo Nakao
Cc: Milo Kim
Cc: Richard Purdie
Signed-off-by: Oskar Andero
---
drivers/video/backlight/lp855x_bl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lp855x_bl.c
b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device
*bl)
{
struct lp855x *lp = bl_get_data(bl);
- if (bl->props.state & BL_CORE_SUSPENDED)
+ if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
bl->props.brightness = 0;
if (lp->mode == PWM_BASED) {
--
1.8.1.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK
From: Shingo Nakao shingo.x.na...@sonymobile.com
When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.
Signed-off-by: Shingo Nakao shingo.x.na...@sonymobile.com
Cc: Milo Kim milo@ti.com
Cc: Richard Purdie rpur...@rpsys.net
Signed-off-by: Oskar Andero oskar.and...@sonymobile.com
Acked-by: Milo Kim milo@ti.com
---
drivers/video/backlight/lp855x_bl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lp855x_bl.c
b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct
backlight_device *bl)
{
struct lp855x *lp = bl_get_data(bl);
- if (bl-props.state BL_CORE_SUSPENDED)
+ if (bl-props.state (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
bl-props.brightness = 0;
if (lp-mode == PWM_BASED) {
--
1.8.1.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK
On Tuesday, July 02, 2013 9:16 PM, Oskar Andero wrote:
From: Shingo Nakao shingo.x.na...@sonymobile.com
When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.
Signed-off-by: Shingo Nakao shingo.x.na...@sonymobile.com
Cc: Milo Kim milo@ti.com
Cc: Richard Purdie rpur...@rpsys.net
Signed-off-by: Oskar Andero oskar.and...@sonymobile.com
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/video/backlight/lp855x_bl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lp855x_bl.c
b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct
backlight_device *bl)
{
struct lp855x *lp = bl_get_data(bl);
- if (bl-props.state BL_CORE_SUSPENDED)
+ if (bl-props.state (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
bl-props.brightness = 0;
if (lp-mode == PWM_BASED) {
--
1.8.1.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] backlight: lp855x: set zero brightness at FBBLANK
From: Shingo Nakao shingo.x.na...@sonymobile.com
When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.
Signed-off-by: Shingo Nakao shingo.x.na...@sonymobile.com
Cc: Milo Kim milo@ti.com
Cc: Richard Purdie rpur...@rpsys.net
Signed-off-by: Oskar Andero oskar.and...@sonymobile.com
---
drivers/video/backlight/lp855x_bl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lp855x_bl.c
b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device
*bl)
{
struct lp855x *lp = bl_get_data(bl);
- if (bl-props.state BL_CORE_SUSPENDED)
+ if (bl-props.state (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
bl-props.brightness = 0;
if (lp-mode == PWM_BASED) {
--
1.8.1.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
