Re: [PATCH] bus: moxtet: declare moxtet_bus_type

2019-10-16 Thread Christoph Hellwig 
On Wed, Oct 16, 2019 at 08:34:06AM +0100, Ben Dooks wrote:
> On 15/10/2019 17:32, Christoph Hellwig wrote:
> > On Tue, Oct 15, 2019 at 01:25:35PM +0100, Ben Dooks wrote:
> > > The moxtet_bus_type object is exported from the bus
> > > driver, but not declared. Add a declaration for use
> > > and to silence the following warning:
> > 
> > The symbol can be marked static instead.
> 
> Then it would have to be un-exported as it's listed as
> EXPORT_SYMBOL_GPL(moxtet_bus_type);

Yes, once you mark it static you should also remove the export.

Re: [PATCH] bus: moxtet: declare moxtet_bus_type

2019-10-16 Thread Ben Dooks 

On 15/10/2019 17:32, Christoph Hellwig wrote:

On Tue, Oct 15, 2019 at 01:25:35PM +0100, Ben Dooks wrote:

The moxtet_bus_type object is exported from the bus
driver, but not declared. Add a declaration for use
and to silence the following warning:


The symbol can be marked static instead.


Then it would have to be un-exported as it's listed as
EXPORT_SYMBOL_GPL(moxtet_bus_type);



--
Ben Dooks   http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html

Re: [PATCH] bus: moxtet: declare moxtet_bus_type

2019-10-15 Thread Christoph Hellwig 
On Tue, Oct 15, 2019 at 01:25:35PM +0100, Ben Dooks wrote:
> The moxtet_bus_type object is exported from the bus
> driver, but not declared. Add a declaration for use
> and to silence the following warning:

The symbol can be marked static instead.

[PATCH] bus: moxtet: declare moxtet_bus_type

2019-10-15 Thread Ben Dooks 
The moxtet_bus_type object is exported from the bus
driver, but not declared. Add a declaration for use
and to silence the following warning:

drivers/bus/moxtet.c:105:17: warning: symbol 'moxtet_bus_type' was not 
declared. Should it be static?

Signed-off-by: Ben Dooks 
---
Cc: Marek Behun 
Cc: linux-kernel@vger.kernel.org
---
 include/linux/moxtet.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/moxtet.h b/include/linux/moxtet.h
index 490db6886dcc..b76231cb60e4 100644
--- a/include/linux/moxtet.h
+++ b/include/linux/moxtet.h
@@ -94,6 +94,8 @@ struct moxtet_device {
unsigned intidx;
 };
 
+extern struct bus_type moxtet_bus_type;
+
 extern int moxtet_device_read(struct device *dev);
 extern int moxtet_device_write(struct device *dev, u8 val);
 extern int moxtet_device_written(struct device *dev);
-- 
2.23.0