Re: [PATCH] c6x: Include init.h in asm/cache.h
On Sat, 2014-02-15 at 09:57 -0800, Guenter Roeck wrote: > On 02/07/2014 06:02 AM, Guenter Roeck wrote: > > arch/c6x/include/asm/cache.h uses __init and thus needs to include init.h. > > This fixes the following c6x build error. > > > > arch/c6x/include/asm/cache.h:63:20: error: expected '=', ',', ';', > > 'asm' or '__attribute__' before 'c6x_cache_init' > > extern void __init c6x_cache_init(void); > > > > Problem was inadvertendly introduced with commit c28aa1f > > (printk/cache: mark printk_once test variable __read_mostly). > > > > Cc: Joe Perches > > Signed-off-by: Guenter Roeck > > --- > > arch/c6x/include/asm/cache.h |1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/c6x/include/asm/cache.h b/arch/c6x/include/asm/cache.h > > index 09c5a0f..86648c0 100644 > > --- a/arch/c6x/include/asm/cache.h > > +++ b/arch/c6x/include/asm/cache.h > > @@ -12,6 +12,7 @@ > > #define _ASM_C6X_CACHE_H > > > > #include > > +#include > > > > /* > >* Cache line size > > > > ping ... c6x builds still fail in mainline due to this problem. > Anyone interested in a fix ? > Yes, I'm interested. A fix has been in linux-next for a while but I haven't pushed it to Linus yet. Will do that this week. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] c6x: Include init.h in asm/cache.h
On 02/07/2014 06:02 AM, Guenter Roeck wrote: arch/c6x/include/asm/cache.h uses __init and thus needs to include init.h. This fixes the following c6x build error. arch/c6x/include/asm/cache.h:63:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'c6x_cache_init' extern void __init c6x_cache_init(void); Problem was inadvertendly introduced with commit c28aa1f (printk/cache: mark printk_once test variable __read_mostly). Cc: Joe Perches Signed-off-by: Guenter Roeck --- arch/c6x/include/asm/cache.h |1 + 1 file changed, 1 insertion(+) diff --git a/arch/c6x/include/asm/cache.h b/arch/c6x/include/asm/cache.h index 09c5a0f..86648c0 100644 --- a/arch/c6x/include/asm/cache.h +++ b/arch/c6x/include/asm/cache.h @@ -12,6 +12,7 @@ #define _ASM_C6X_CACHE_H #include +#include /* * Cache line size ping ... c6x builds still fail in mainline due to this problem. Anyone interested in a fix ? Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] c6x: Include init.h in asm/cache.h
On 02/07/2014 06:02 AM, Guenter Roeck wrote: arch/c6x/include/asm/cache.h uses __init and thus needs to include init.h. This fixes the following c6x build error. arch/c6x/include/asm/cache.h:63:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'c6x_cache_init' extern void __init c6x_cache_init(void); Problem was inadvertendly introduced with commit c28aa1f (printk/cache: mark printk_once test variable __read_mostly). Cc: Joe Perches j...@perches.com Signed-off-by: Guenter Roeck li...@roeck-us.net --- arch/c6x/include/asm/cache.h |1 + 1 file changed, 1 insertion(+) diff --git a/arch/c6x/include/asm/cache.h b/arch/c6x/include/asm/cache.h index 09c5a0f..86648c0 100644 --- a/arch/c6x/include/asm/cache.h +++ b/arch/c6x/include/asm/cache.h @@ -12,6 +12,7 @@ #define _ASM_C6X_CACHE_H #include linux/irqflags.h +#include linux/init.h /* * Cache line size ping ... c6x builds still fail in mainline due to this problem. Anyone interested in a fix ? Guenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] c6x: Include init.h in asm/cache.h
On Sat, 2014-02-15 at 09:57 -0800, Guenter Roeck wrote: On 02/07/2014 06:02 AM, Guenter Roeck wrote: arch/c6x/include/asm/cache.h uses __init and thus needs to include init.h. This fixes the following c6x build error. arch/c6x/include/asm/cache.h:63:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'c6x_cache_init' extern void __init c6x_cache_init(void); Problem was inadvertendly introduced with commit c28aa1f (printk/cache: mark printk_once test variable __read_mostly). Cc: Joe Perches j...@perches.com Signed-off-by: Guenter Roeck li...@roeck-us.net --- arch/c6x/include/asm/cache.h |1 + 1 file changed, 1 insertion(+) diff --git a/arch/c6x/include/asm/cache.h b/arch/c6x/include/asm/cache.h index 09c5a0f..86648c0 100644 --- a/arch/c6x/include/asm/cache.h +++ b/arch/c6x/include/asm/cache.h @@ -12,6 +12,7 @@ #define _ASM_C6X_CACHE_H #include linux/irqflags.h +#include linux/init.h /* * Cache line size ping ... c6x builds still fail in mainline due to this problem. Anyone interested in a fix ? Yes, I'm interested. A fix has been in linux-next for a while but I haven't pushed it to Linus yet. Will do that this week. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] c6x: Include init.h in asm/cache.h
arch/c6x/include/asm/cache.h uses __init and thus needs to include init.h. This fixes the following c6x build error. arch/c6x/include/asm/cache.h:63:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'c6x_cache_init' extern void __init c6x_cache_init(void); Problem was inadvertendly introduced with commit c28aa1f (printk/cache: mark printk_once test variable __read_mostly). Cc: Joe Perches Signed-off-by: Guenter Roeck --- arch/c6x/include/asm/cache.h |1 + 1 file changed, 1 insertion(+) diff --git a/arch/c6x/include/asm/cache.h b/arch/c6x/include/asm/cache.h index 09c5a0f..86648c0 100644 --- a/arch/c6x/include/asm/cache.h +++ b/arch/c6x/include/asm/cache.h @@ -12,6 +12,7 @@ #define _ASM_C6X_CACHE_H #include +#include /* * Cache line size -- 1.7.9.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] c6x: Include init.h in asm/cache.h
arch/c6x/include/asm/cache.h uses __init and thus needs to include init.h. This fixes the following c6x build error. arch/c6x/include/asm/cache.h:63:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'c6x_cache_init' extern void __init c6x_cache_init(void); Problem was inadvertendly introduced with commit c28aa1f (printk/cache: mark printk_once test variable __read_mostly). Cc: Joe Perches j...@perches.com Signed-off-by: Guenter Roeck li...@roeck-us.net --- arch/c6x/include/asm/cache.h |1 + 1 file changed, 1 insertion(+) diff --git a/arch/c6x/include/asm/cache.h b/arch/c6x/include/asm/cache.h index 09c5a0f..86648c0 100644 --- a/arch/c6x/include/asm/cache.h +++ b/arch/c6x/include/asm/cache.h @@ -12,6 +12,7 @@ #define _ASM_C6X_CACHE_H #include linux/irqflags.h +#include linux/init.h /* * Cache line size -- 1.7.9.7 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
