Re: [PATCH] checkpatch: Add spell checking of email subject line
On Thu, 05 Mar 2015, Joe Perches wrote: > Only commit log and patch additions are checked for > typos and spelling errors currently. Add a check > of the email subject line too. > > Suggested-by: Jani Nikula > Signed-off-by: Joe Perches Thanks Joe. FWIW, Tested-by: Jani Nikula > --- > scripts/checkpatch.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 421bbb4..c061a63 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2303,7 +2303,8 @@ sub process { > } > > # Check for various typo / spelling mistakes > - if (defined($misspellings) && ($in_commit_log || $line =~ > /^\+/)) { > + if (defined($misspellings) && > + ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) { > while ($rawline =~ > /(?:^|[^a-z@])($misspellings)(?:$|[^a-z@])/gi) { > my $typo = $1; > my $typo_fix = $spelling_fix{lc($typo)}; > > -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] checkpatch: Add spell checking of email subject line
Only commit log and patch additions are checked for typos and spelling errors currently. Add a check of the email subject line too. Suggested-by: Jani Nikula Signed-off-by: Joe Perches --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 421bbb4..c061a63 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2303,7 +2303,8 @@ sub process { } # Check for various typo / spelling mistakes - if (defined($misspellings) && ($in_commit_log || $line =~ /^\+/)) { + if (defined($misspellings) && + ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) { while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:$|[^a-z@])/gi) { my $typo = $1; my $typo_fix = $spelling_fix{lc($typo)}; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] checkpatch: Add spell checking of email subject line
Only commit log and patch additions are checked for typos and spelling errors currently. Add a check of the email subject line too. Suggested-by: Jani Nikula jani.nik...@linux.intel.com Signed-off-by: Joe Perches j...@perches.com --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 421bbb4..c061a63 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2303,7 +2303,8 @@ sub process { } # Check for various typo / spelling mistakes - if (defined($misspellings) ($in_commit_log || $line =~ /^\+/)) { + if (defined($misspellings) + ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) { while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:$|[^a-z@])/gi) { my $typo = $1; my $typo_fix = $spelling_fix{lc($typo)}; -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] checkpatch: Add spell checking of email subject line
On Thu, 05 Mar 2015, Joe Perches j...@perches.com wrote: Only commit log and patch additions are checked for typos and spelling errors currently. Add a check of the email subject line too. Suggested-by: Jani Nikula jani.nik...@linux.intel.com Signed-off-by: Joe Perches j...@perches.com Thanks Joe. FWIW, Tested-by: Jani Nikula jani.nik...@intel.com --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 421bbb4..c061a63 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2303,7 +2303,8 @@ sub process { } # Check for various typo / spelling mistakes - if (defined($misspellings) ($in_commit_log || $line =~ /^\+/)) { + if (defined($misspellings) + ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) { while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:$|[^a-z@])/gi) { my $typo = $1; my $typo_fix = $spelling_fix{lc($typo)}; -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/