Re: [PATCH] checkpatch: Don't complain about long "Fixes:" lines

2015-08-05 Thread Michael Ellerman 
On Wed, 2015-08-05 at 20:50 -0700, Joe Perches wrote:
> On Thu, 2015-08-06 at 13:44 +1000, Michael Ellerman wrote:
> > We encourage people to mention the commit they are fixing, if any, using
> > a Fixes line, see SubmittingPatches.
> 
> https://lkml.org/lkml/2015/7/31/1271

Thanks.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] checkpatch: Don't complain about long "Fixes:" lines

2015-08-05 Thread Joe Perches 
On Thu, 2015-08-06 at 13:44 +1000, Michael Ellerman wrote:
> We encourage people to mention the commit they are fixing, if any, using
> a Fixes line, see SubmittingPatches.

https://lkml.org/lkml/2015/7/31/1271


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] checkpatch: Don't complain about long "Fixes:" lines

2015-08-05 Thread Michael Ellerman 
We encourage people to mention the commit they are fixing, if any, using
a Fixes line, see SubmittingPatches.

Although it's not mentioned explicitly, it's preferable if the Fixes
line is not wrapped, so skip Fixes lines when checking for overlength
lines.

Signed-off-by: Michael Ellerman 
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d5c8e9a3a73c..b3139cb1bf9d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2310,7 +2310,7 @@ sub process {
 
 # Check for line lengths > 75 in commit log, warn once
if ($in_commit_log && !$commit_log_long_line &&
-   length($line) > 75) {
+   length($line) > 75 && $line !~ /^\s*Fixes: [0-9a-f]+/i) {
WARN("COMMIT_LOG_LONG_LINE",
 "Possible unwrapped commit description (prefer a 
maximum 75 chars per line)\n" . $herecurr);
$commit_log_long_line = 1;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/