Re: [PATCH] clk: bcm2835: add missing release if devm_clk_hw_register fails

[Stephen Boyd]

Quoting Navid Emamdoost (2020-08-09 16:11:58)
> In the implementation of bcm2835_register_pll(), the allocated pll is
> leaked if devm_clk_hw_register() fails to register hw. Release pll if
> devm_clk_hw_register() fails.
> 
> Signed-off-by: Navid Emamdoost 
> ---

Applied to clk-next

[PATCH] clk: bcm2835: add missing release if devm_clk_hw_register fails

[Navid Emamdoost]

In the implementation of bcm2835_register_pll(), the allocated pll is
leaked if devm_clk_hw_register() fails to register hw. Release pll if
devm_clk_hw_register() fails.

Signed-off-by: Navid Emamdoost 
---
 drivers/clk/bcm/clk-bcm2835.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index 6bb7efa12037..12b950d50252 100644
--- a/drivers/clk/bcm/clk-bcm2835.c
+++ b/drivers/clk/bcm/clk-bcm2835.c
@@ -1321,8 +1321,10 @@ static struct clk_hw *bcm2835_register_pll(struct 
bcm2835_cprman *cprman,
pll->hw.init = &init;
 
ret = devm_clk_hw_register(cprman->dev, &pll->hw);
-   if (ret)
+   if (ret) {
+   kfree(pll);
return NULL;
+   }
return &pll->hw;
 }
 
-- 
2.17.1