Re: [PATCH] coresight: Use devm_kcalloc() in coresight_alloc_conns()

2020-07-28 Thread Mathieu Poirier 
On Sun, 26 Jul 2020 at 19:51, Xu Wang  wrote:
>
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "devm_kcalloc".
>
> Signed-off-by: Xu Wang 
> ---
>  drivers/hwtracing/coresight/coresight-platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-platform.c 
> b/drivers/hwtracing/coresight/coresight-platform.c
> index e4912abda3aa..d1460b6e4e07 100644
> --- a/drivers/hwtracing/coresight/coresight-platform.c
> +++ b/drivers/hwtracing/coresight/coresight-platform.c
> @@ -27,7 +27,7 @@ static int coresight_alloc_conns(struct device *dev,
>  struct coresight_platform_data *pdata)
>  {
> if (pdata->nr_outport) {
> -   pdata->conns = devm_kzalloc(dev, pdata->nr_outport *
> +   pdata->conns = devm_kcalloc(dev, pdata->nr_outport,

https://lkml.org/lkml/2020/5/27/1098

> sizeof(*pdata->conns),
> GFP_KERNEL);
> if (!pdata->conns)
> --
> 2.17.1
>

[PATCH] coresight: Use devm_kcalloc() in coresight_alloc_conns()

2020-07-26 Thread Xu Wang 
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "devm_kcalloc".

Signed-off-by: Xu Wang 
---
 drivers/hwtracing/coresight/coresight-platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-platform.c 
b/drivers/hwtracing/coresight/coresight-platform.c
index e4912abda3aa..d1460b6e4e07 100644
--- a/drivers/hwtracing/coresight/coresight-platform.c
+++ b/drivers/hwtracing/coresight/coresight-platform.c
@@ -27,7 +27,7 @@ static int coresight_alloc_conns(struct device *dev,
 struct coresight_platform_data *pdata)
 {
if (pdata->nr_outport) {
-   pdata->conns = devm_kzalloc(dev, pdata->nr_outport *
+   pdata->conns = devm_kcalloc(dev, pdata->nr_outport,
sizeof(*pdata->conns),
GFP_KERNEL);
if (!pdata->conns)
-- 
2.17.1

Re: [PATCH] coresight: Use devm_kcalloc() in coresight_alloc_conns()

2020-05-27 Thread Mathieu Poirier 
On Mon, 25 May 2020 at 23:53, Xu Wang  wrote:
>
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "devm_kcalloc".
>
> Signed-off-by: Xu Wang 
> ---
>  drivers/hwtracing/coresight/coresight-platform.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-platform.c 
> b/drivers/hwtracing/coresight/coresight-platform.c
> index 43418a2126ff..6720049409f3 100644
> --- a/drivers/hwtracing/coresight/coresight-platform.c
> +++ b/drivers/hwtracing/coresight/coresight-platform.c
> @@ -27,9 +27,8 @@ static int coresight_alloc_conns(struct device *dev,
>  struct coresight_platform_data *pdata)
>  {
> if (pdata->nr_outport) {
> -   pdata->conns = devm_kzalloc(dev, pdata->nr_outport *
> -   sizeof(*pdata->conns),
> -   GFP_KERNEL);
> +   pdata->conns = devm_kcalloc(dev, pdata->nr_outport,
> +   sizeof(*pdata->conns), 
> GFP_KERNEL);

I have applied your patch.

Thanks,
Mathieu

> if (!pdata->conns)
> return -ENOMEM;
> }
> --
> 2.17.1
>

[PATCH] coresight: Use devm_kcalloc() in coresight_alloc_conns()

2020-05-25 Thread Xu Wang 
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "devm_kcalloc".

Signed-off-by: Xu Wang 
---
 drivers/hwtracing/coresight/coresight-platform.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-platform.c 
b/drivers/hwtracing/coresight/coresight-platform.c
index 43418a2126ff..6720049409f3 100644
--- a/drivers/hwtracing/coresight/coresight-platform.c
+++ b/drivers/hwtracing/coresight/coresight-platform.c
@@ -27,9 +27,8 @@ static int coresight_alloc_conns(struct device *dev,
 struct coresight_platform_data *pdata)
 {
if (pdata->nr_outport) {
-   pdata->conns = devm_kzalloc(dev, pdata->nr_outport *
-   sizeof(*pdata->conns),
-   GFP_KERNEL);
+   pdata->conns = devm_kcalloc(dev, pdata->nr_outport,
+   sizeof(*pdata->conns), GFP_KERNEL);
if (!pdata->conns)
return -ENOMEM;
}
-- 
2.17.1