Re: [PATCH] cpufreq: mediatek: add missing platform_driver_unregister() on error in mtk_cpufreq_driver_init

2020-11-01 Thread Viresh Kumar 
On 31-10-20, 09:18, Qinglang Miao wrote:
> Add the missing platform_driver_unregister() before return from
> mtk_cpufreq_driver_init in the error handling case when failed
> to register mtk-cpufreq platform device
> 
> Signed-off-by: Qinglang Miao 
> ---
>  drivers/cpufreq/mediatek-cpufreq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/mediatek-cpufreq.c 
> b/drivers/cpufreq/mediatek-cpufreq.c
> index 7d1212c9b..c03c76a0c 100644
> --- a/drivers/cpufreq/mediatek-cpufreq.c
> +++ b/drivers/cpufreq/mediatek-cpufreq.c
> @@ -572,6 +572,7 @@ static int __init mtk_cpufreq_driver_init(void)
>   pdev = platform_device_register_simple("mtk-cpufreq", -1, NULL, 0);
>   if (IS_ERR(pdev)) {
>   pr_err("failed to register mtk-cpufreq platform device\n");
> + platform_driver_unregister(_cpufreq_platdrv);
>   return PTR_ERR(pdev);
>   }

Applied. Thanks.

-- 
viresh

[PATCH] cpufreq: mediatek: add missing platform_driver_unregister() on error in mtk_cpufreq_driver_init

2020-10-30 Thread Qinglang Miao 
Add the missing platform_driver_unregister() before return from
mtk_cpufreq_driver_init in the error handling case when failed
to register mtk-cpufreq platform device

Signed-off-by: Qinglang Miao 
---
 drivers/cpufreq/mediatek-cpufreq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/mediatek-cpufreq.c 
b/drivers/cpufreq/mediatek-cpufreq.c
index 7d1212c9b..c03c76a0c 100644
--- a/drivers/cpufreq/mediatek-cpufreq.c
+++ b/drivers/cpufreq/mediatek-cpufreq.c
@@ -572,6 +572,7 @@ static int __init mtk_cpufreq_driver_init(void)
pdev = platform_device_register_simple("mtk-cpufreq", -1, NULL, 0);
if (IS_ERR(pdev)) {
pr_err("failed to register mtk-cpufreq platform device\n");
+   platform_driver_unregister(_cpufreq_platdrv);
return PTR_ERR(pdev);
}
 
-- 
2.23.0