Re: [PATCH] cpuidle/coupled: Init cpuidle_device::safe_state_index

[pang . xunlei]

Hi Daniel,

Daniel Lezcano  wrote 2015-08-04 AM 12:22:54:
> Re: [PATCH] cpuidle/coupled: Init cpuidle_device::safe_state_index
> 
> On 07/23/2015 02:31 PM, Xunlei Pang wrote:
> > From: Xunlei Pang 
> >
> > cpuidle_device::safe_state_index need to be initialized before use,
> > so assign the driver's safe_state_index to it.
> >
> > Signed-off-by: Xunlei Pang 
> > ---
> >   drivers/cpuidle/cpuidle.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> > index e8e2775..ed5c8efe 100644
> > --- a/drivers/cpuidle/cpuidle.c
> > +++ b/drivers/cpuidle/cpuidle.c
> > @@ -585,6 +585,8 @@ int cpuidle_register(struct cpuidle_driver *drv,
> >  */
> > if (coupled_cpus)
> >device->coupled_cpus = *coupled_cpus;
> > +
> > +  device->safe_state_index = drv->safe_state_index;
> 
> Hey, good catch. We are lucky the safe_state_index is always zero.
> 
> I think we can simplify the code by removing the safe_state_index from 
> the cpuidle_device structure and use the one in the cpuidle_driver 
> structure in coupled.c

Will do, thanks!

Regards,
-Xunlei


ZTE Information Security Notice: The information contained in this mail (and 
any attachment transmitted herewith) is privileged and confidential and is 
intended for the exclusive use of the addressee(s).  If you are not an intended 
recipient, any disclosure, reproduction, distribution or other dissemination or 
use of the information contained is strictly prohibited.  If you have received 
this mail in error, please delete it and notify us immediately.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] cpuidle/coupled: Init cpuidle_device::safe_state_index

[Daniel Lezcano]

On 07/23/2015 02:31 PM, Xunlei Pang wrote:

From: Xunlei Pang 

cpuidle_device::safe_state_index need to be initialized before use,
so assign the driver's safe_state_index to it.

Signed-off-by: Xunlei Pang 
---
  drivers/cpuidle/cpuidle.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index e8e2775..ed5c8efe 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -585,6 +585,8 @@ int cpuidle_register(struct cpuidle_driver *drv,
 */
if (coupled_cpus)
device->coupled_cpus = *coupled_cpus;
+
+   device->safe_state_index = drv->safe_state_index;


Hey, good catch. We are lucky the safe_state_index is always zero.

I think we can simplify the code by removing the safe_state_index from 
the cpuidle_device structure and use the one in the cpuidle_driver 
structure in coupled.c





--
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] cpuidle/coupled: Init cpuidle_device::safe_state_index

[Xunlei Pang]

From: Xunlei Pang 

cpuidle_device::safe_state_index need to be initialized before use,
so assign the driver's safe_state_index to it.

Signed-off-by: Xunlei Pang 
---
 drivers/cpuidle/cpuidle.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index e8e2775..ed5c8efe 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -585,6 +585,8 @@ int cpuidle_register(struct cpuidle_driver *drv,
 */
if (coupled_cpus)
device->coupled_cpus = *coupled_cpus;
+
+   device->safe_state_index = drv->safe_state_index;
 #endif
ret = cpuidle_register_device(device);
if (!ret)
-- 
1.9.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/