Re: [PATCH] cxl: Remove use of macro DEFINE_PCI_DEVICE_TABLE

2015-07-19 Thread Ian Munsie 
Acked-by: Ian Munsie 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] cxl: Remove use of macro DEFINE_PCI_DEVICE_TABLE

2015-07-19 Thread Michael Neuling 
On Sun, 2015-07-19 at 22:53 +0530, Vaishali Thakkar wrote:
> Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use
> struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
> the goal of getting rid of this macro completely.
> 
> The Coccinelle semantic patch that performs this transformation
> is as follows:
> 
> @@
> identifier a;
> declarer name DEFINE_PCI_DEVICE_TABLE;
> initializer i;
> @@
> - DEFINE_PCI_DEVICE_TABLE(a)
> + const struct pci_device_id a[]
> = i;
> 
> Signed-off-by: Vaishali Thakkar 

Looks good, thanks!

Acked-by: Michael Neuling 


> ---
>  drivers/misc/cxl/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index 32ad097..3ed0621 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -133,7 +133,7 @@ u8 cxl_afu_cr_read8(struct cxl_afu *afu, int cr, u64 off)
>   return (val >> ((off & 0x3) * 8)) & 0xff;
>  }
>  
> -static DEFINE_PCI_DEVICE_TABLE(cxl_pci_tbl) = {
> +static const struct pci_device_id cxl_pci_tbl[] = {
>   { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0477), },
>   { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x044b), },
>   { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x04cf), },

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] cxl: Remove use of macro DEFINE_PCI_DEVICE_TABLE

2015-07-19 Thread Vaishali Thakkar 
Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use
struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
the goal of getting rid of this macro completely.

The Coccinelle semantic patch that performs this transformation
is as follows:

@@
identifier a;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer i;
@@
- DEFINE_PCI_DEVICE_TABLE(a)
+ const struct pci_device_id a[]
= i;

Signed-off-by: Vaishali Thakkar 
---
 drivers/misc/cxl/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index 32ad097..3ed0621 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -133,7 +133,7 @@ u8 cxl_afu_cr_read8(struct cxl_afu *afu, int cr, u64 off)
return (val >> ((off & 0x3) * 8)) & 0xff;
 }
 
-static DEFINE_PCI_DEVICE_TABLE(cxl_pci_tbl) = {
+static const struct pci_device_id cxl_pci_tbl[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0477), },
{ PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x044b), },
{ PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x04cf), },
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] cxl: Remove use of macro DEFINE_PCI_DEVICE_TABLE

2015-07-19 Thread Vaishali Thakkar 
Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use
struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
the goal of getting rid of this macro completely.

The Coccinelle semantic patch that performs this transformation
is as follows:

@@
identifier a;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer i;
@@
- DEFINE_PCI_DEVICE_TABLE(a)
+ const struct pci_device_id a[]
= i;

Signed-off-by: Vaishali Thakkar vthakkar1...@gmail.com
---
 drivers/misc/cxl/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index 32ad097..3ed0621 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -133,7 +133,7 @@ u8 cxl_afu_cr_read8(struct cxl_afu *afu, int cr, u64 off)
return (val  ((off  0x3) * 8))  0xff;
 }
 
-static DEFINE_PCI_DEVICE_TABLE(cxl_pci_tbl) = {
+static const struct pci_device_id cxl_pci_tbl[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0477), },
{ PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x044b), },
{ PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x04cf), },
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] cxl: Remove use of macro DEFINE_PCI_DEVICE_TABLE

2015-07-19 Thread Michael Neuling 
On Sun, 2015-07-19 at 22:53 +0530, Vaishali Thakkar wrote:
 Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use
 struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
 the goal of getting rid of this macro completely.
 
 The Coccinelle semantic patch that performs this transformation
 is as follows:
 
 @@
 identifier a;
 declarer name DEFINE_PCI_DEVICE_TABLE;
 initializer i;
 @@
 - DEFINE_PCI_DEVICE_TABLE(a)
 + const struct pci_device_id a[]
 = i;
 
 Signed-off-by: Vaishali Thakkar vthakkar1...@gmail.com

Looks good, thanks!

Acked-by: Michael Neuling mi...@neuling.org


 ---
  drivers/misc/cxl/pci.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
 index 32ad097..3ed0621 100644
 --- a/drivers/misc/cxl/pci.c
 +++ b/drivers/misc/cxl/pci.c
 @@ -133,7 +133,7 @@ u8 cxl_afu_cr_read8(struct cxl_afu *afu, int cr, u64 off)
   return (val  ((off  0x3) * 8))  0xff;
  }
  
 -static DEFINE_PCI_DEVICE_TABLE(cxl_pci_tbl) = {
 +static const struct pci_device_id cxl_pci_tbl[] = {
   { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0477), },
   { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x044b), },
   { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x04cf), },

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] cxl: Remove use of macro DEFINE_PCI_DEVICE_TABLE

2015-07-19 Thread Ian Munsie 
Acked-by: Ian Munsie imun...@au1.ibm.com

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/