Re: [PATCH] devres: no print device_node.name in devres_log()

[Frank Lee]

On Sat, Nov 24, 2018 at 10:25 PM Yangtao Li  wrote:
>
> In preparation to remove the node name pointer from struct device_node,
> avoid to printf node name.
>
> Signed-off-by: Yangtao Li 
> ---
>  drivers/base/devres.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/devres.c b/drivers/base/devres.c
> index 4aaf00d2098b..34c07e9faaf9 100644
> --- a/drivers/base/devres.c
> +++ b/drivers/base/devres.c
> @@ -52,8 +52,8 @@ static void devres_log(struct device *dev, struct 
> devres_node *node,
>const char *op)
>  {
> if (unlikely(log_devres))
> -   dev_err(dev, "DEVRES %3s %p %s (%lu bytes)\n",
> -   op, node, node->name, (unsigned long)node->size);
The modification of this place is a bit problematic, ignoring this email.

Yours,
Yangtao
> +   dev_err(dev, "DEVRES %3s %p (%lu bytes)\n",
> +   op, node, (unsigned long)node->size);
>  }
>  #else /* CONFIG_DEBUG_DEVRES */
>  #define set_node_dbginfo(node, n, s)   do {} while (0)
> --
> 2.17.0
>

Re: [PATCH] devres: no print device_node.name in devres_log()

[Frank Lee]

On Sat, Nov 24, 2018 at 10:25 PM Yangtao Li  wrote:
>
> In preparation to remove the node name pointer from struct device_node,
> avoid to printf node name.
>
> Signed-off-by: Yangtao Li 
> ---
>  drivers/base/devres.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/devres.c b/drivers/base/devres.c
> index 4aaf00d2098b..34c07e9faaf9 100644
> --- a/drivers/base/devres.c
> +++ b/drivers/base/devres.c
> @@ -52,8 +52,8 @@ static void devres_log(struct device *dev, struct 
> devres_node *node,
>const char *op)
>  {
> if (unlikely(log_devres))
> -   dev_err(dev, "DEVRES %3s %p %s (%lu bytes)\n",
> -   op, node, node->name, (unsigned long)node->size);
The modification of this place is a bit problematic, ignoring this email.

Yours,
Yangtao
> +   dev_err(dev, "DEVRES %3s %p (%lu bytes)\n",
> +   op, node, (unsigned long)node->size);
>  }
>  #else /* CONFIG_DEBUG_DEVRES */
>  #define set_node_dbginfo(node, n, s)   do {} while (0)
> --
> 2.17.0
>

[PATCH] devres: no print device_node.name in devres_log()

[Yangtao Li]

In preparation to remove the node name pointer from struct device_node,
avoid to printf node name.

Signed-off-by: Yangtao Li 
---
 drivers/base/devres.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/devres.c b/drivers/base/devres.c
index 4aaf00d2098b..34c07e9faaf9 100644
--- a/drivers/base/devres.c
+++ b/drivers/base/devres.c
@@ -52,8 +52,8 @@ static void devres_log(struct device *dev, struct devres_node 
*node,
   const char *op)
 {
if (unlikely(log_devres))
-   dev_err(dev, "DEVRES %3s %p %s (%lu bytes)\n",
-   op, node, node->name, (unsigned long)node->size);
+   dev_err(dev, "DEVRES %3s %p (%lu bytes)\n",
+   op, node, (unsigned long)node->size);
 }
 #else /* CONFIG_DEBUG_DEVRES */
 #define set_node_dbginfo(node, n, s)   do {} while (0)
-- 
2.17.0

[PATCH] devres: no print device_node.name in devres_log()

[Yangtao Li]

In preparation to remove the node name pointer from struct device_node,
avoid to printf node name.

Signed-off-by: Yangtao Li 
---
 drivers/base/devres.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/devres.c b/drivers/base/devres.c
index 4aaf00d2098b..34c07e9faaf9 100644
--- a/drivers/base/devres.c
+++ b/drivers/base/devres.c
@@ -52,8 +52,8 @@ static void devres_log(struct device *dev, struct devres_node 
*node,
   const char *op)
 {
if (unlikely(log_devres))
-   dev_err(dev, "DEVRES %3s %p %s (%lu bytes)\n",
-   op, node, node->name, (unsigned long)node->size);
+   dev_err(dev, "DEVRES %3s %p (%lu bytes)\n",
+   op, node, (unsigned long)node->size);
 }
 #else /* CONFIG_DEBUG_DEVRES */
 #define set_node_dbginfo(node, n, s)   do {} while (0)
-- 
2.17.0