Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
On Tue, Dec 10, 2013 at 03:26:33PM +0800, Fengguang Wu wrote: > > Hi, Fengguang > > Can you help to add this patch to your test systems? > > It's a one-line change, you can find the patch at > > https://patchwork.kernel.org/patch/3192361/ > > Hi Axel, > > Do you have a public git tree? If not, I'd like to take this chance to > encourage you to setup one. The best work flow is to create a branch, > apply the patch and tell me the git URL and branch name to test. Unless you have a bunch of devices added and removed from the system dynamically, you really aren't going to hit this codepath, so I don't think your automated system really is going to help out much here, sorry. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
> Hi, Fengguang > Can you help to add this patch to your test systems? > It's a one-line change, you can find the patch at > https://patchwork.kernel.org/patch/3192361/ Hi Axel, Do you have a public git tree? If not, I'd like to take this chance to encourage you to setup one. The best work flow is to create a branch, apply the patch and tell me the git URL and branch name to test. Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
2013/12/9 Axel Lin : > 2013/12/9 Greg Kroah-Hartman : >> On Mon, Dec 09, 2013 at 04:54:29PM +0800, Axel Lin wrote: >>> 2013/12/9 Greg Kroah-Hartman : >>> > On Wed, Dec 04, 2013 at 02:44:14PM +0800, Axel Lin wrote: >>> >> 2013/12/4 Rob Landley : >>> >> > On 11/16/2013 02:15:23 AM, Axel Lin wrote: >>> >> >> >>> >> >> The deleted variable is always 1 in current code. >>> >> >> Initialize deleted variable to be 0, so delete_path() will be called >>> >> >> only >>> >> >> when >>> >> >> necessary. >>> >> >> >>> >> >> Signed-off-by: Axel Lin >>> >> > >>> >> > >>> >> > I'm not seeing this in linux-next, or a reply on the web archive. >>> >> > Assuming >>> >> > nobody's objected to this, you might want to forward it to >>> >> > triv...@kernel.org. >>> >> > >>> >> > That said, you could describe what it _does_ a little more? >>> >> >>> >> I was expecting Greg to pick up this patch. >>> >> >>> >> I thought the description is pretty clear. >>> >> What the patch does is changing the init value of deleted variable to 0. >>> >> The intention of this change is to avoid unnecessary delete_path() call. >>> > >>> > I agree the logic is a bit odd here, but are you seeing an "unnecessary" >>> > delete_path() call happening? The code has always been like this from >>> > what I can tell... >>> >>> Honestly, I havn't see the "unnecessary" delete_path() call happening >>> druing my >>> test. I look at the code when I was debugging a hangup issue. >>> (In the end, I think the issue is not related to the devtmpfs code.) >>> But I found the logic for the deleted variable looks odd. >>> There are below possible (unlikely) case: >>> When strchr(nodename, '/') != 0 and >>> 1. If dentry->d_inode is NULL >>> 2. vfs_getattr returns error >>> 3. vfs_unlink returns error except -ENOENT. >>> >>> In these cases, delete_path() will fail anyway. >>> >>> Although this is a unlikely case, and I know the code is there since initial >>> commit. But I think it's still good to fix it. >> >> Have you tested your patch to verify nothing breaks? > Yes. I have this patch in my local build image since the day I sent the patch. Hi Greg, If you want more testing for this patch to ensure nothing break, I think maybe Fengguang can also help to test it. Hi, Fengguang Can you help to add this patch to your test systems? It's a one-line change, you can find the patch at https://patchwork.kernel.org/patch/3192361/ Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
2013/12/9 Greg Kroah-Hartman : > On Mon, Dec 09, 2013 at 04:54:29PM +0800, Axel Lin wrote: >> 2013/12/9 Greg Kroah-Hartman : >> > On Wed, Dec 04, 2013 at 02:44:14PM +0800, Axel Lin wrote: >> >> 2013/12/4 Rob Landley : >> >> > On 11/16/2013 02:15:23 AM, Axel Lin wrote: >> >> >> >> >> >> The deleted variable is always 1 in current code. >> >> >> Initialize deleted variable to be 0, so delete_path() will be called >> >> >> only >> >> >> when >> >> >> necessary. >> >> >> >> >> >> Signed-off-by: Axel Lin >> >> > >> >> > >> >> > I'm not seeing this in linux-next, or a reply on the web archive. >> >> > Assuming >> >> > nobody's objected to this, you might want to forward it to >> >> > triv...@kernel.org. >> >> > >> >> > That said, you could describe what it _does_ a little more? >> >> >> >> I was expecting Greg to pick up this patch. >> >> >> >> I thought the description is pretty clear. >> >> What the patch does is changing the init value of deleted variable to 0. >> >> The intention of this change is to avoid unnecessary delete_path() call. >> > >> > I agree the logic is a bit odd here, but are you seeing an "unnecessary" >> > delete_path() call happening? The code has always been like this from >> > what I can tell... >> >> Honestly, I havn't see the "unnecessary" delete_path() call happening druing >> my >> test. I look at the code when I was debugging a hangup issue. >> (In the end, I think the issue is not related to the devtmpfs code.) >> But I found the logic for the deleted variable looks odd. >> There are below possible (unlikely) case: >> When strchr(nodename, '/') != 0 and >> 1. If dentry->d_inode is NULL >> 2. vfs_getattr returns error >> 3. vfs_unlink returns error except -ENOENT. >> >> In these cases, delete_path() will fail anyway. >> >> Although this is a unlikely case, and I know the code is there since initial >> commit. But I think it's still good to fix it. > > Have you tested your patch to verify nothing breaks? Yes. I have this patch in my local build image since the day I sent the patch. Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
On Mon, Dec 09, 2013 at 04:54:29PM +0800, Axel Lin wrote: > 2013/12/9 Greg Kroah-Hartman : > > On Wed, Dec 04, 2013 at 02:44:14PM +0800, Axel Lin wrote: > >> 2013/12/4 Rob Landley : > >> > On 11/16/2013 02:15:23 AM, Axel Lin wrote: > >> >> > >> >> The deleted variable is always 1 in current code. > >> >> Initialize deleted variable to be 0, so delete_path() will be called > >> >> only > >> >> when > >> >> necessary. > >> >> > >> >> Signed-off-by: Axel Lin > >> > > >> > > >> > I'm not seeing this in linux-next, or a reply on the web archive. > >> > Assuming > >> > nobody's objected to this, you might want to forward it to > >> > triv...@kernel.org. > >> > > >> > That said, you could describe what it _does_ a little more? > >> > >> I was expecting Greg to pick up this patch. > >> > >> I thought the description is pretty clear. > >> What the patch does is changing the init value of deleted variable to 0. > >> The intention of this change is to avoid unnecessary delete_path() call. > > > > I agree the logic is a bit odd here, but are you seeing an "unnecessary" > > delete_path() call happening? The code has always been like this from > > what I can tell... > > Honestly, I havn't see the "unnecessary" delete_path() call happening druing > my > test. I look at the code when I was debugging a hangup issue. > (In the end, I think the issue is not related to the devtmpfs code.) > But I found the logic for the deleted variable looks odd. > There are below possible (unlikely) case: > When strchr(nodename, '/') != 0 and > 1. If dentry->d_inode is NULL > 2. vfs_getattr returns error > 3. vfs_unlink returns error except -ENOENT. > > In these cases, delete_path() will fail anyway. > > Although this is a unlikely case, and I know the code is there since initial > commit. But I think it's still good to fix it. Have you tested your patch to verify nothing breaks? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
2013/12/9 Greg Kroah-Hartman : > On Wed, Dec 04, 2013 at 02:44:14PM +0800, Axel Lin wrote: >> 2013/12/4 Rob Landley : >> > On 11/16/2013 02:15:23 AM, Axel Lin wrote: >> >> >> >> The deleted variable is always 1 in current code. >> >> Initialize deleted variable to be 0, so delete_path() will be called only >> >> when >> >> necessary. >> >> >> >> Signed-off-by: Axel Lin >> > >> > >> > I'm not seeing this in linux-next, or a reply on the web archive. Assuming >> > nobody's objected to this, you might want to forward it to >> > triv...@kernel.org. >> > >> > That said, you could describe what it _does_ a little more? >> >> I was expecting Greg to pick up this patch. >> >> I thought the description is pretty clear. >> What the patch does is changing the init value of deleted variable to 0. >> The intention of this change is to avoid unnecessary delete_path() call. > > I agree the logic is a bit odd here, but are you seeing an "unnecessary" > delete_path() call happening? The code has always been like this from > what I can tell... Honestly, I havn't see the "unnecessary" delete_path() call happening druing my test. I look at the code when I was debugging a hangup issue. (In the end, I think the issue is not related to the devtmpfs code.) But I found the logic for the deleted variable looks odd. There are below possible (unlikely) case: When strchr(nodename, '/') != 0 and 1. If dentry->d_inode is NULL 2. vfs_getattr returns error 3. vfs_unlink returns error except -ENOENT. In these cases, delete_path() will fail anyway. Although this is a unlikely case, and I know the code is there since initial commit. But I think it's still good to fix it. Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
On Wed, Dec 04, 2013 at 02:44:14PM +0800, Axel Lin wrote: > 2013/12/4 Rob Landley : > > On 11/16/2013 02:15:23 AM, Axel Lin wrote: > >> > >> The deleted variable is always 1 in current code. > >> Initialize deleted variable to be 0, so delete_path() will be called only > >> when > >> necessary. > >> > >> Signed-off-by: Axel Lin > > > > > > I'm not seeing this in linux-next, or a reply on the web archive. Assuming > > nobody's objected to this, you might want to forward it to > > triv...@kernel.org. > > > > That said, you could describe what it _does_ a little more? > > I was expecting Greg to pick up this patch. > > I thought the description is pretty clear. > What the patch does is changing the init value of deleted variable to 0. > The intention of this change is to avoid unnecessary delete_path() call. I agree the logic is a bit odd here, but are you seeing an "unnecessary" delete_path() call happening? The code has always been like this from what I can tell... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
On Wed, Dec 04, 2013 at 02:44:14PM +0800, Axel Lin wrote: 2013/12/4 Rob Landley r...@landley.net: On 11/16/2013 02:15:23 AM, Axel Lin wrote: The deleted variable is always 1 in current code. Initialize deleted variable to be 0, so delete_path() will be called only when necessary. Signed-off-by: Axel Lin axel@ingics.com I'm not seeing this in linux-next, or a reply on the web archive. Assuming nobody's objected to this, you might want to forward it to triv...@kernel.org. That said, you could describe what it _does_ a little more? I was expecting Greg to pick up this patch. I thought the description is pretty clear. What the patch does is changing the init value of deleted variable to 0. The intention of this change is to avoid unnecessary delete_path() call. I agree the logic is a bit odd here, but are you seeing an unnecessary delete_path() call happening? The code has always been like this from what I can tell... thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
2013/12/9 Greg Kroah-Hartman gre...@linuxfoundation.org: On Wed, Dec 04, 2013 at 02:44:14PM +0800, Axel Lin wrote: 2013/12/4 Rob Landley r...@landley.net: On 11/16/2013 02:15:23 AM, Axel Lin wrote: The deleted variable is always 1 in current code. Initialize deleted variable to be 0, so delete_path() will be called only when necessary. Signed-off-by: Axel Lin axel@ingics.com I'm not seeing this in linux-next, or a reply on the web archive. Assuming nobody's objected to this, you might want to forward it to triv...@kernel.org. That said, you could describe what it _does_ a little more? I was expecting Greg to pick up this patch. I thought the description is pretty clear. What the patch does is changing the init value of deleted variable to 0. The intention of this change is to avoid unnecessary delete_path() call. I agree the logic is a bit odd here, but are you seeing an unnecessary delete_path() call happening? The code has always been like this from what I can tell... Honestly, I havn't see the unnecessary delete_path() call happening druing my test. I look at the code when I was debugging a hangup issue. (In the end, I think the issue is not related to the devtmpfs code.) But I found the logic for the deleted variable looks odd. There are below possible (unlikely) case: When strchr(nodename, '/') != 0 and 1. If dentry-d_inode is NULL 2. vfs_getattr returns error 3. vfs_unlink returns error except -ENOENT. In these cases, delete_path() will fail anyway. Although this is a unlikely case, and I know the code is there since initial commit. But I think it's still good to fix it. Regards, Axel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
On Mon, Dec 09, 2013 at 04:54:29PM +0800, Axel Lin wrote: 2013/12/9 Greg Kroah-Hartman gre...@linuxfoundation.org: On Wed, Dec 04, 2013 at 02:44:14PM +0800, Axel Lin wrote: 2013/12/4 Rob Landley r...@landley.net: On 11/16/2013 02:15:23 AM, Axel Lin wrote: The deleted variable is always 1 in current code. Initialize deleted variable to be 0, so delete_path() will be called only when necessary. Signed-off-by: Axel Lin axel@ingics.com I'm not seeing this in linux-next, or a reply on the web archive. Assuming nobody's objected to this, you might want to forward it to triv...@kernel.org. That said, you could describe what it _does_ a little more? I was expecting Greg to pick up this patch. I thought the description is pretty clear. What the patch does is changing the init value of deleted variable to 0. The intention of this change is to avoid unnecessary delete_path() call. I agree the logic is a bit odd here, but are you seeing an unnecessary delete_path() call happening? The code has always been like this from what I can tell... Honestly, I havn't see the unnecessary delete_path() call happening druing my test. I look at the code when I was debugging a hangup issue. (In the end, I think the issue is not related to the devtmpfs code.) But I found the logic for the deleted variable looks odd. There are below possible (unlikely) case: When strchr(nodename, '/') != 0 and 1. If dentry-d_inode is NULL 2. vfs_getattr returns error 3. vfs_unlink returns error except -ENOENT. In these cases, delete_path() will fail anyway. Although this is a unlikely case, and I know the code is there since initial commit. But I think it's still good to fix it. Have you tested your patch to verify nothing breaks? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
2013/12/9 Greg Kroah-Hartman gre...@linuxfoundation.org: On Mon, Dec 09, 2013 at 04:54:29PM +0800, Axel Lin wrote: 2013/12/9 Greg Kroah-Hartman gre...@linuxfoundation.org: On Wed, Dec 04, 2013 at 02:44:14PM +0800, Axel Lin wrote: 2013/12/4 Rob Landley r...@landley.net: On 11/16/2013 02:15:23 AM, Axel Lin wrote: The deleted variable is always 1 in current code. Initialize deleted variable to be 0, so delete_path() will be called only when necessary. Signed-off-by: Axel Lin axel@ingics.com I'm not seeing this in linux-next, or a reply on the web archive. Assuming nobody's objected to this, you might want to forward it to triv...@kernel.org. That said, you could describe what it _does_ a little more? I was expecting Greg to pick up this patch. I thought the description is pretty clear. What the patch does is changing the init value of deleted variable to 0. The intention of this change is to avoid unnecessary delete_path() call. I agree the logic is a bit odd here, but are you seeing an unnecessary delete_path() call happening? The code has always been like this from what I can tell... Honestly, I havn't see the unnecessary delete_path() call happening druing my test. I look at the code when I was debugging a hangup issue. (In the end, I think the issue is not related to the devtmpfs code.) But I found the logic for the deleted variable looks odd. There are below possible (unlikely) case: When strchr(nodename, '/') != 0 and 1. If dentry-d_inode is NULL 2. vfs_getattr returns error 3. vfs_unlink returns error except -ENOENT. In these cases, delete_path() will fail anyway. Although this is a unlikely case, and I know the code is there since initial commit. But I think it's still good to fix it. Have you tested your patch to verify nothing breaks? Yes. I have this patch in my local build image since the day I sent the patch. Regards, Axel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
2013/12/9 Axel Lin axel@ingics.com: 2013/12/9 Greg Kroah-Hartman gre...@linuxfoundation.org: On Mon, Dec 09, 2013 at 04:54:29PM +0800, Axel Lin wrote: 2013/12/9 Greg Kroah-Hartman gre...@linuxfoundation.org: On Wed, Dec 04, 2013 at 02:44:14PM +0800, Axel Lin wrote: 2013/12/4 Rob Landley r...@landley.net: On 11/16/2013 02:15:23 AM, Axel Lin wrote: The deleted variable is always 1 in current code. Initialize deleted variable to be 0, so delete_path() will be called only when necessary. Signed-off-by: Axel Lin axel@ingics.com I'm not seeing this in linux-next, or a reply on the web archive. Assuming nobody's objected to this, you might want to forward it to triv...@kernel.org. That said, you could describe what it _does_ a little more? I was expecting Greg to pick up this patch. I thought the description is pretty clear. What the patch does is changing the init value of deleted variable to 0. The intention of this change is to avoid unnecessary delete_path() call. I agree the logic is a bit odd here, but are you seeing an unnecessary delete_path() call happening? The code has always been like this from what I can tell... Honestly, I havn't see the unnecessary delete_path() call happening druing my test. I look at the code when I was debugging a hangup issue. (In the end, I think the issue is not related to the devtmpfs code.) But I found the logic for the deleted variable looks odd. There are below possible (unlikely) case: When strchr(nodename, '/') != 0 and 1. If dentry-d_inode is NULL 2. vfs_getattr returns error 3. vfs_unlink returns error except -ENOENT. In these cases, delete_path() will fail anyway. Although this is a unlikely case, and I know the code is there since initial commit. But I think it's still good to fix it. Have you tested your patch to verify nothing breaks? Yes. I have this patch in my local build image since the day I sent the patch. Hi Greg, If you want more testing for this patch to ensure nothing break, I think maybe Fengguang can also help to test it. Hi, Fengguang Can you help to add this patch to your test systems? It's a one-line change, you can find the patch at https://patchwork.kernel.org/patch/3192361/ Regards, Axel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
Hi, Fengguang Can you help to add this patch to your test systems? It's a one-line change, you can find the patch at https://patchwork.kernel.org/patch/3192361/ Hi Axel, Do you have a public git tree? If not, I'd like to take this chance to encourage you to setup one. The best work flow is to create a branch, apply the patch and tell me the git URL and branch name to test. Thanks, Fengguang -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
On Tue, Dec 10, 2013 at 03:26:33PM +0800, Fengguang Wu wrote: Hi, Fengguang Can you help to add this patch to your test systems? It's a one-line change, you can find the patch at https://patchwork.kernel.org/patch/3192361/ Hi Axel, Do you have a public git tree? If not, I'd like to take this chance to encourage you to setup one. The best work flow is to create a branch, apply the patch and tell me the git URL and branch name to test. Unless you have a bunch of devices added and removed from the system dynamically, you really aren't going to hit this codepath, so I don't think your automated system really is going to help out much here, sorry. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
On Wed, Dec 04, 2013 at 02:44:14PM +0800, Axel Lin wrote: > 2013/12/4 Rob Landley : > > On 11/16/2013 02:15:23 AM, Axel Lin wrote: > >> > >> The deleted variable is always 1 in current code. > >> Initialize deleted variable to be 0, so delete_path() will be called only > >> when > >> necessary. > >> > >> Signed-off-by: Axel Lin > > > > > > I'm not seeing this in linux-next, or a reply on the web archive. Assuming > > nobody's objected to this, you might want to forward it to > > triv...@kernel.org. > > > > That said, you could describe what it _does_ a little more? > > I was expecting Greg to pick up this patch. > > I thought the description is pretty clear. > What the patch does is changing the init value of deleted variable to 0. > The intention of this change is to avoid unnecessary delete_path() call. > > Hi Greg, > Would you pick up this patch? > If a re-send or a v2 is required, please just let me know. It's in my queue to get to, sorry, it's huge and slowly going down, it's not lost... greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
2013/12/4 Rob Landley : > On 11/16/2013 02:15:23 AM, Axel Lin wrote: >> >> The deleted variable is always 1 in current code. >> Initialize deleted variable to be 0, so delete_path() will be called only >> when >> necessary. >> >> Signed-off-by: Axel Lin > > > I'm not seeing this in linux-next, or a reply on the web archive. Assuming > nobody's objected to this, you might want to forward it to > triv...@kernel.org. > > That said, you could describe what it _does_ a little more? I was expecting Greg to pick up this patch. I thought the description is pretty clear. What the patch does is changing the init value of deleted variable to 0. The intention of this change is to avoid unnecessary delete_path() call. Hi Greg, Would you pick up this patch? If a re-send or a v2 is required, please just let me know. Thanks, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
On 11/16/2013 02:15:23 AM, Axel Lin wrote: The deleted variable is always 1 in current code. Initialize deleted variable to be 0, so delete_path() will be called only when necessary. Signed-off-by: Axel Lin I'm not seeing this in linux-next, or a reply on the web archive. Assuming nobody's objected to this, you might want to forward it to triv...@kernel.org. That said, you could describe what it _does_ a little more? Thanks, Rob-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
On 11/16/2013 02:15:23 AM, Axel Lin wrote: The deleted variable is always 1 in current code. Initialize deleted variable to be 0, so delete_path() will be called only when necessary. Signed-off-by: Axel Lin axel@ingics.com I'm not seeing this in linux-next, or a reply on the web archive. Assuming nobody's objected to this, you might want to forward it to triv...@kernel.org. That said, you could describe what it _does_ a little more? Thanks, Rob-- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
2013/12/4 Rob Landley r...@landley.net: On 11/16/2013 02:15:23 AM, Axel Lin wrote: The deleted variable is always 1 in current code. Initialize deleted variable to be 0, so delete_path() will be called only when necessary. Signed-off-by: Axel Lin axel@ingics.com I'm not seeing this in linux-next, or a reply on the web archive. Assuming nobody's objected to this, you might want to forward it to triv...@kernel.org. That said, you could describe what it _does_ a little more? I was expecting Greg to pick up this patch. I thought the description is pretty clear. What the patch does is changing the init value of deleted variable to 0. The intention of this change is to avoid unnecessary delete_path() call. Hi Greg, Would you pick up this patch? If a re-send or a v2 is required, please just let me know. Thanks, Axel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] devtmpfs: Calling delete_path() only when necessary
On Wed, Dec 04, 2013 at 02:44:14PM +0800, Axel Lin wrote: 2013/12/4 Rob Landley r...@landley.net: On 11/16/2013 02:15:23 AM, Axel Lin wrote: The deleted variable is always 1 in current code. Initialize deleted variable to be 0, so delete_path() will be called only when necessary. Signed-off-by: Axel Lin axel@ingics.com I'm not seeing this in linux-next, or a reply on the web archive. Assuming nobody's objected to this, you might want to forward it to triv...@kernel.org. That said, you could describe what it _does_ a little more? I was expecting Greg to pick up this patch. I thought the description is pretty clear. What the patch does is changing the init value of deleted variable to 0. The intention of this change is to avoid unnecessary delete_path() call. Hi Greg, Would you pick up this patch? If a re-send or a v2 is required, please just let me know. It's in my queue to get to, sorry, it's huge and slowly going down, it's not lost... greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] devtmpfs: Calling delete_path() only when necessary
The deleted variable is always 1 in current code.
Initialize deleted variable to be 0, so delete_path() will be called only when
necessary.
Signed-off-by: Axel Lin
---
drivers/base/devtmpfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
index 0f38201..25798db 100644
--- a/drivers/base/devtmpfs.c
+++ b/drivers/base/devtmpfs.c
@@ -299,7 +299,7 @@ static int handle_remove(const char *nodename, struct
device *dev)
{
struct path parent;
struct dentry *dentry;
- int deleted = 1;
+ int deleted = 0;
int err;
dentry = kern_path_locked(nodename, );
--
1.8.1.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] devtmpfs: Calling delete_path() only when necessary
The deleted variable is always 1 in current code.
Initialize deleted variable to be 0, so delete_path() will be called only when
necessary.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/base/devtmpfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
index 0f38201..25798db 100644
--- a/drivers/base/devtmpfs.c
+++ b/drivers/base/devtmpfs.c
@@ -299,7 +299,7 @@ static int handle_remove(const char *nodename, struct
device *dev)
{
struct path parent;
struct dentry *dentry;
- int deleted = 1;
+ int deleted = 0;
int err;
dentry = kern_path_locked(nodename, parent);
--
1.8.1.2
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
