Re: [PATCH] dma: mmp_pdma: fix a memory alloc error
2013/6/17 Vinod Koul : > On Tue, May 28, 2013 at 08:05:13PM +0800, Xiang Wang wrote: >> From: Xiang Wang >> >> pdev->phy is of type "struct mmp_pdma_phy *". But when >> allocating memory for it, "struct mmp_pdma_chan" is used >> by mistake. >> >> Signed-off-by: Xiang Wang >> --- >> drivers/dma/mmp_pdma.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c >> index c26699f..76a8dcf 100644 >> --- a/drivers/dma/mmp_pdma.c >> +++ b/drivers/dma/mmp_pdma.c >> @@ -801,7 +801,7 @@ static int mmp_pdma_probe(struct platform_device *op) >> } >> >> pdev->phy = devm_kzalloc(pdev->dev, >> - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); >> + dma_channels * sizeof(struct mmp_pdma_phy), GFP_KERNEL); > why not sizeof(*pdev-phy), that way you dont make above error > > -- > ~Vinod Hi, Updated patch V2 to use sizeof(*pdev->phy). Thanks! -- Regards, Xiang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] dma: mmp_pdma: fix a memory alloc error
2013/6/17 Vinod Koul vinod.k...@intel.com: On Tue, May 28, 2013 at 08:05:13PM +0800, Xiang Wang wrote: From: Xiang Wang wa...@marvell.com pdev-phy is of type struct mmp_pdma_phy *. But when allocating memory for it, struct mmp_pdma_chan is used by mistake. Signed-off-by: Xiang Wang wa...@marvell.com --- drivers/dma/mmp_pdma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index c26699f..76a8dcf 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -801,7 +801,7 @@ static int mmp_pdma_probe(struct platform_device *op) } pdev-phy = devm_kzalloc(pdev-dev, - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); + dma_channels * sizeof(struct mmp_pdma_phy), GFP_KERNEL); why not sizeof(*pdev-phy), that way you dont make above error -- ~Vinod Hi, Updated patch V2 to use sizeof(*pdev-phy). Thanks! -- Regards, Xiang -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] dma: mmp_pdma: fix a memory alloc error
On Tue, May 28, 2013 at 08:05:13PM +0800, Xiang Wang wrote: > From: Xiang Wang > > pdev->phy is of type "struct mmp_pdma_phy *". But when > allocating memory for it, "struct mmp_pdma_chan" is used > by mistake. > > Signed-off-by: Xiang Wang > --- > drivers/dma/mmp_pdma.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c > index c26699f..76a8dcf 100644 > --- a/drivers/dma/mmp_pdma.c > +++ b/drivers/dma/mmp_pdma.c > @@ -801,7 +801,7 @@ static int mmp_pdma_probe(struct platform_device *op) > } > > pdev->phy = devm_kzalloc(pdev->dev, > - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); > + dma_channels * sizeof(struct mmp_pdma_phy), GFP_KERNEL); why not sizeof(*pdev-phy), that way you dont make above error -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] dma: mmp_pdma: fix a memory alloc error
2013/5/31 Xiang Wang : > 2013/5/28 Andy Shevchenko : >> On Tue, May 28, 2013 at 3:05 PM, Xiang Wang wrote: >>> From: Xiang Wang >>> >>> pdev->phy is of type "struct mmp_pdma_phy *". But when >>> allocating memory for it, "struct mmp_pdma_chan" is used >>> by mistake. >> >> Have you tested it? >> >>> Signed-off-by: Xiang Wang >>> --- >>> drivers/dma/mmp_pdma.c |2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c >>> index c26699f..76a8dcf 100644 >>> --- a/drivers/dma/mmp_pdma.c >>> +++ b/drivers/dma/mmp_pdma.c >>> @@ -801,7 +801,7 @@ static int mmp_pdma_probe(struct platform_device *op) >>> } >>> >>> pdev->phy = devm_kzalloc(pdev->dev, >>> - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); >>> + dma_channels * sizeof(struct mmp_pdma_phy), GFP_KERNEL); >> >> For me it seems you did get how it works. >> >> -- >> With Best Regards, >> Andy Shevchenko > > Hi, Andy > Yes. I've tested on marvell pxa988 platform using dmatest.ko. Hi, All Do you have any comments about this patch? Thanks! -- Regards, Xiang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] dma: mmp_pdma: fix a memory alloc error
2013/5/31 Xiang Wang wangx...@gmail.com: 2013/5/28 Andy Shevchenko andy.shevche...@gmail.com: On Tue, May 28, 2013 at 3:05 PM, Xiang Wang wangx...@gmail.com wrote: From: Xiang Wang wa...@marvell.com pdev-phy is of type struct mmp_pdma_phy *. But when allocating memory for it, struct mmp_pdma_chan is used by mistake. Have you tested it? Signed-off-by: Xiang Wang wa...@marvell.com --- drivers/dma/mmp_pdma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index c26699f..76a8dcf 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -801,7 +801,7 @@ static int mmp_pdma_probe(struct platform_device *op) } pdev-phy = devm_kzalloc(pdev-dev, - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); + dma_channels * sizeof(struct mmp_pdma_phy), GFP_KERNEL); For me it seems you did get how it works. -- With Best Regards, Andy Shevchenko Hi, Andy Yes. I've tested on marvell pxa988 platform using dmatest.ko. Hi, All Do you have any comments about this patch? Thanks! -- Regards, Xiang -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] dma: mmp_pdma: fix a memory alloc error
On Tue, May 28, 2013 at 08:05:13PM +0800, Xiang Wang wrote: From: Xiang Wang wa...@marvell.com pdev-phy is of type struct mmp_pdma_phy *. But when allocating memory for it, struct mmp_pdma_chan is used by mistake. Signed-off-by: Xiang Wang wa...@marvell.com --- drivers/dma/mmp_pdma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index c26699f..76a8dcf 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -801,7 +801,7 @@ static int mmp_pdma_probe(struct platform_device *op) } pdev-phy = devm_kzalloc(pdev-dev, - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); + dma_channels * sizeof(struct mmp_pdma_phy), GFP_KERNEL); why not sizeof(*pdev-phy), that way you dont make above error -- ~Vinod -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] dma: mmp_pdma: fix a memory alloc error
2013/5/28 Andy Shevchenko : > On Tue, May 28, 2013 at 3:05 PM, Xiang Wang wrote: >> From: Xiang Wang >> >> pdev->phy is of type "struct mmp_pdma_phy *". But when >> allocating memory for it, "struct mmp_pdma_chan" is used >> by mistake. > > Have you tested it? > >> Signed-off-by: Xiang Wang >> --- >> drivers/dma/mmp_pdma.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c >> index c26699f..76a8dcf 100644 >> --- a/drivers/dma/mmp_pdma.c >> +++ b/drivers/dma/mmp_pdma.c >> @@ -801,7 +801,7 @@ static int mmp_pdma_probe(struct platform_device *op) >> } >> >> pdev->phy = devm_kzalloc(pdev->dev, >> - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); >> + dma_channels * sizeof(struct mmp_pdma_phy), GFP_KERNEL); > > For me it seems you did get how it works. > > -- > With Best Regards, > Andy Shevchenko Hi, Andy Yes. I've tested on marvell pxa988 platform using dmatest.ko. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] dma: mmp_pdma: fix a memory alloc error
2013/5/28 Andy Shevchenko andy.shevche...@gmail.com: On Tue, May 28, 2013 at 3:05 PM, Xiang Wang wangx...@gmail.com wrote: From: Xiang Wang wa...@marvell.com pdev-phy is of type struct mmp_pdma_phy *. But when allocating memory for it, struct mmp_pdma_chan is used by mistake. Have you tested it? Signed-off-by: Xiang Wang wa...@marvell.com --- drivers/dma/mmp_pdma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index c26699f..76a8dcf 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -801,7 +801,7 @@ static int mmp_pdma_probe(struct platform_device *op) } pdev-phy = devm_kzalloc(pdev-dev, - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); + dma_channels * sizeof(struct mmp_pdma_phy), GFP_KERNEL); For me it seems you did get how it works. -- With Best Regards, Andy Shevchenko Hi, Andy Yes. I've tested on marvell pxa988 platform using dmatest.ko. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] dma: mmp_pdma: fix a memory alloc error
On Tue, May 28, 2013 at 3:05 PM, Xiang Wang wrote: > From: Xiang Wang > > pdev->phy is of type "struct mmp_pdma_phy *". But when > allocating memory for it, "struct mmp_pdma_chan" is used > by mistake. Have you tested it? > Signed-off-by: Xiang Wang > --- > drivers/dma/mmp_pdma.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c > index c26699f..76a8dcf 100644 > --- a/drivers/dma/mmp_pdma.c > +++ b/drivers/dma/mmp_pdma.c > @@ -801,7 +801,7 @@ static int mmp_pdma_probe(struct platform_device *op) > } > > pdev->phy = devm_kzalloc(pdev->dev, > - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); > + dma_channels * sizeof(struct mmp_pdma_phy), GFP_KERNEL); For me it seems you did get how it works. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] dma: mmp_pdma: fix a memory alloc error
From: Xiang Wang pdev->phy is of type "struct mmp_pdma_phy *". But when allocating memory for it, "struct mmp_pdma_chan" is used by mistake. Signed-off-by: Xiang Wang --- drivers/dma/mmp_pdma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index c26699f..76a8dcf 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -801,7 +801,7 @@ static int mmp_pdma_probe(struct platform_device *op) } pdev->phy = devm_kzalloc(pdev->dev, - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); + dma_channels * sizeof(struct mmp_pdma_phy), GFP_KERNEL); if (pdev->phy == NULL) return -ENOMEM; -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] dma: mmp_pdma: fix a memory alloc error
From: Xiang Wang wa...@marvell.com pdev-phy is of type struct mmp_pdma_phy *. But when allocating memory for it, struct mmp_pdma_chan is used by mistake. Signed-off-by: Xiang Wang wa...@marvell.com --- drivers/dma/mmp_pdma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index c26699f..76a8dcf 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -801,7 +801,7 @@ static int mmp_pdma_probe(struct platform_device *op) } pdev-phy = devm_kzalloc(pdev-dev, - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); + dma_channels * sizeof(struct mmp_pdma_phy), GFP_KERNEL); if (pdev-phy == NULL) return -ENOMEM; -- 1.7.5.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] dma: mmp_pdma: fix a memory alloc error
On Tue, May 28, 2013 at 3:05 PM, Xiang Wang wangx...@gmail.com wrote: From: Xiang Wang wa...@marvell.com pdev-phy is of type struct mmp_pdma_phy *. But when allocating memory for it, struct mmp_pdma_chan is used by mistake. Have you tested it? Signed-off-by: Xiang Wang wa...@marvell.com --- drivers/dma/mmp_pdma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index c26699f..76a8dcf 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -801,7 +801,7 @@ static int mmp_pdma_probe(struct platform_device *op) } pdev-phy = devm_kzalloc(pdev-dev, - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); + dma_channels * sizeof(struct mmp_pdma_phy), GFP_KERNEL); For me it seems you did get how it works. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
