Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
Hi Baoyou, 2016-09-22 Greg Kroah-Hartman: > On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote: > > Hi Baoyou, > > > > On 20 September 2016 at 16:43, Gustavo Padovan wrote: > > > 2016-09-18 Baoyou Xie : > > > > > >> We get 1 warning when building kernel with W=1: > > >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for > > >> 'sync_timeline_create' [-Wmissing-prototypes] > > >> > > >> In fact, this function is only used in the file in which it is > > >> declared and don't need a declaration, but can be made static. > > >> So this patch marks it 'static'. > > >> > > >> Signed-off-by: Baoyou Xie > > >> --- > > >> drivers/dma-buf/sw_sync.c | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Thanks for finding this. > > > > Thanks for the patch; this doesn't apply to mainline yet, since the > > de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree. > > CC'ing him. > > > > Greg, would it be possible to please take this via your tree? > > If someone resends it to me with the needed acks and reviewed-by, I > will. Could please resend this to Greg with all the acks and reviewed-by in the commit message? Thanks. Gustavo
Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
Hi Baoyou, 2016-09-22 Greg Kroah-Hartman : > On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote: > > Hi Baoyou, > > > > On 20 September 2016 at 16:43, Gustavo Padovan wrote: > > > 2016-09-18 Baoyou Xie : > > > > > >> We get 1 warning when building kernel with W=1: > > >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for > > >> 'sync_timeline_create' [-Wmissing-prototypes] > > >> > > >> In fact, this function is only used in the file in which it is > > >> declared and don't need a declaration, but can be made static. > > >> So this patch marks it 'static'. > > >> > > >> Signed-off-by: Baoyou Xie > > >> --- > > >> drivers/dma-buf/sw_sync.c | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Thanks for finding this. > > > > Thanks for the patch; this doesn't apply to mainline yet, since the > > de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree. > > CC'ing him. > > > > Greg, would it be possible to please take this via your tree? > > If someone resends it to me with the needed acks and reviewed-by, I > will. Could please resend this to Greg with all the acks and reviewed-by in the commit message? Thanks. Gustavo
Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
On Saturday, September 24, 2016 12:33:46 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for > 'sync_timeline_create' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie> Acked-by: Arnd Bergmann
Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
On Saturday, September 24, 2016 12:33:46 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for > 'sync_timeline_create' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie > Acked-by: Arnd Bergmann
[PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
We get 1 warning when building kernel with W=1: drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. So this patch marks it 'static'. Signed-off-by: Baoyou Xie--- drivers/dma-buf/sw_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/sw_sync.c b/drivers/dma-buf/sw_sync.c index 62e8e6d..6f16c85 100644 --- a/drivers/dma-buf/sw_sync.c +++ b/drivers/dma-buf/sw_sync.c @@ -84,7 +84,7 @@ static inline struct sync_pt *fence_to_sync_pt(struct fence *fence) * Creates a new sync_timeline. Returns the sync_timeline object or NULL in * case of error. */ -struct sync_timeline *sync_timeline_create(const char *name) +static struct sync_timeline *sync_timeline_create(const char *name) { struct sync_timeline *obj; -- 2.7.4
[PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
We get 1 warning when building kernel with W=1: drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. So this patch marks it 'static'. Signed-off-by: Baoyou Xie --- drivers/dma-buf/sw_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/sw_sync.c b/drivers/dma-buf/sw_sync.c index 62e8e6d..6f16c85 100644 --- a/drivers/dma-buf/sw_sync.c +++ b/drivers/dma-buf/sw_sync.c @@ -84,7 +84,7 @@ static inline struct sync_pt *fence_to_sync_pt(struct fence *fence) * Creates a new sync_timeline. Returns the sync_timeline object or NULL in * case of error. */ -struct sync_timeline *sync_timeline_create(const char *name) +static struct sync_timeline *sync_timeline_create(const char *name) { struct sync_timeline *obj; -- 2.7.4
Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote: > Hi Baoyou, > > On 20 September 2016 at 16:43, Gustavo Padovanwrote: > > 2016-09-18 Baoyou Xie : > > > >> We get 1 warning when building kernel with W=1: > >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for > >> 'sync_timeline_create' [-Wmissing-prototypes] > >> > >> In fact, this function is only used in the file in which it is > >> declared and don't need a declaration, but can be made static. > >> So this patch marks it 'static'. > >> > >> Signed-off-by: Baoyou Xie > >> --- > >> drivers/dma-buf/sw_sync.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Thanks for finding this. > > Thanks for the patch; this doesn't apply to mainline yet, since the > de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree. > CC'ing him. > > Greg, would it be possible to please take this via your tree? If someone resends it to me with the needed acks and reviewed-by, I will. thanks, greg k-h
Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote: > Hi Baoyou, > > On 20 September 2016 at 16:43, Gustavo Padovan wrote: > > 2016-09-18 Baoyou Xie : > > > >> We get 1 warning when building kernel with W=1: > >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for > >> 'sync_timeline_create' [-Wmissing-prototypes] > >> > >> In fact, this function is only used in the file in which it is > >> declared and don't need a declaration, but can be made static. > >> So this patch marks it 'static'. > >> > >> Signed-off-by: Baoyou Xie > >> --- > >> drivers/dma-buf/sw_sync.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Thanks for finding this. > > Thanks for the patch; this doesn't apply to mainline yet, since the > de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree. > CC'ing him. > > Greg, would it be possible to please take this via your tree? If someone resends it to me with the needed acks and reviewed-by, I will. thanks, greg k-h
Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
Hi Baoyou, On 20 September 2016 at 16:43, Gustavo Padovanwrote: > 2016-09-18 Baoyou Xie : > >> We get 1 warning when building kernel with W=1: >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for >> 'sync_timeline_create' [-Wmissing-prototypes] >> >> In fact, this function is only used in the file in which it is >> declared and don't need a declaration, but can be made static. >> So this patch marks it 'static'. >> >> Signed-off-by: Baoyou Xie >> --- >> drivers/dma-buf/sw_sync.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks for finding this. Thanks for the patch; this doesn't apply to mainline yet, since the de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree. CC'ing him. Greg, would it be possible to please take this via your tree? > > Reviewed-by: Gustavo Padovan > Acked-by: Sumit Semwal > Gustavo > Best regards, Sumi
Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
Hi Baoyou, On 20 September 2016 at 16:43, Gustavo Padovan wrote: > 2016-09-18 Baoyou Xie : > >> We get 1 warning when building kernel with W=1: >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for >> 'sync_timeline_create' [-Wmissing-prototypes] >> >> In fact, this function is only used in the file in which it is >> declared and don't need a declaration, but can be made static. >> So this patch marks it 'static'. >> >> Signed-off-by: Baoyou Xie >> --- >> drivers/dma-buf/sw_sync.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks for finding this. Thanks for the patch; this doesn't apply to mainline yet, since the de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree. CC'ing him. Greg, would it be possible to please take this via your tree? > > Reviewed-by: Gustavo Padovan > Acked-by: Sumit Semwal > Gustavo > Best regards, Sumi
Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
2016-09-18 Baoyou Xie: > We get 1 warning when building kernel with W=1: > drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for > 'sync_timeline_create' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/dma-buf/sw_sync.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for finding this. Reviewed-by: Gustavo Padovan Gustavo
Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
2016-09-18 Baoyou Xie : > We get 1 warning when building kernel with W=1: > drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for > 'sync_timeline_create' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/dma-buf/sw_sync.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for finding this. Reviewed-by: Gustavo Padovan Gustavo
[PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
We get 1 warning when building kernel with W=1: drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. So this patch marks it 'static'. Signed-off-by: Baoyou Xie--- drivers/dma-buf/sw_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/sw_sync.c b/drivers/dma-buf/sw_sync.c index 62e8e6d..6f16c85 100644 --- a/drivers/dma-buf/sw_sync.c +++ b/drivers/dma-buf/sw_sync.c @@ -84,7 +84,7 @@ static inline struct sync_pt *fence_to_sync_pt(struct fence *fence) * Creates a new sync_timeline. Returns the sync_timeline object or NULL in * case of error. */ -struct sync_timeline *sync_timeline_create(const char *name) +static struct sync_timeline *sync_timeline_create(const char *name) { struct sync_timeline *obj; -- 2.7.4
[PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
We get 1 warning when building kernel with W=1: drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. So this patch marks it 'static'. Signed-off-by: Baoyou Xie --- drivers/dma-buf/sw_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/sw_sync.c b/drivers/dma-buf/sw_sync.c index 62e8e6d..6f16c85 100644 --- a/drivers/dma-buf/sw_sync.c +++ b/drivers/dma-buf/sw_sync.c @@ -84,7 +84,7 @@ static inline struct sync_pt *fence_to_sync_pt(struct fence *fence) * Creates a new sync_timeline. Returns the sync_timeline object or NULL in * case of error. */ -struct sync_timeline *sync_timeline_create(const char *name) +static struct sync_timeline *sync_timeline_create(const char *name) { struct sync_timeline *obj; -- 2.7.4