Re: [PATCH] dmaengine: bcm-sba-raid: Handle mbox_request_channel failure

[Vinod Koul]

Hi Rayagonda,

On 27-09-19, 09:38, Rayagonda Kokatanur wrote:
> Hi Vinod,
> 
> Did you get chance to review this fix?

Please do *not* top post

And on your question, sorry this is not in my queue somehow, please
rebase and repost

> 
> Best regards,
> Rayagonda
> 
> 
> On Thu, Jan 10, 2019 at 11:06 PM Ray Jui  wrote:
> >
> >
> >
> > On 1/9/2019 10:07 PM, Rayagonda Kokatanur wrote:
> > > Fix kernel NULL pointer dereference error when mbox_request_channel()
> > > fails to allocate channel.
> > >
> > > Fixes: 4e9f8187aecb ("dmaengine: bcm-sba-raid: Use only single mailbox 
> > > channel")
> > > Signed-off-by: Rayagonda Kokatanur 
> > > ---
> > >  drivers/dma/bcm-sba-raid.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
> > > index 72878ac5c78d..77ae74663a45 100644
> > > --- a/drivers/dma/bcm-sba-raid.c
> > > +++ b/drivers/dma/bcm-sba-raid.c
> > > @@ -1690,7 +1690,7 @@ static int sba_probe(struct platform_device *pdev)
> > >   sba->mchan = mbox_request_channel(>client, 0);
> > >   if (IS_ERR(sba->mchan)) {
> > >   ret = PTR_ERR(sba->mchan);
> > > - goto fail_free_mchan;
> > > + goto fail_exit;
> > >   }
> > >
> > >   /* Find-out underlying mailbox device */
> > > @@ -1747,6 +1747,7 @@ static int sba_probe(struct platform_device *pdev)
> > >   sba_freeup_channel_resources(sba);
> > >  fail_free_mchan:
> > >   mbox_free_channel(sba->mchan);
> > > +fail_exit:
> > >   return ret;
> > >  }
> > >
> > >
> >
> > Looks good to me.
> >
> > Reviewed-by: Ray Jui 

-- 
~Vinod

Re: [PATCH] dmaengine: bcm-sba-raid: Handle mbox_request_channel failure

[Rayagonda Kokatanur]

Hi Vinod,

Did you get chance to review this fix?

Best regards,
Rayagonda


On Thu, Jan 10, 2019 at 11:06 PM Ray Jui  wrote:
>
>
>
> On 1/9/2019 10:07 PM, Rayagonda Kokatanur wrote:
> > Fix kernel NULL pointer dereference error when mbox_request_channel()
> > fails to allocate channel.
> >
> > Fixes: 4e9f8187aecb ("dmaengine: bcm-sba-raid: Use only single mailbox 
> > channel")
> > Signed-off-by: Rayagonda Kokatanur 
> > ---
> >  drivers/dma/bcm-sba-raid.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
> > index 72878ac5c78d..77ae74663a45 100644
> > --- a/drivers/dma/bcm-sba-raid.c
> > +++ b/drivers/dma/bcm-sba-raid.c
> > @@ -1690,7 +1690,7 @@ static int sba_probe(struct platform_device *pdev)
> >   sba->mchan = mbox_request_channel(>client, 0);
> >   if (IS_ERR(sba->mchan)) {
> >   ret = PTR_ERR(sba->mchan);
> > - goto fail_free_mchan;
> > + goto fail_exit;
> >   }
> >
> >   /* Find-out underlying mailbox device */
> > @@ -1747,6 +1747,7 @@ static int sba_probe(struct platform_device *pdev)
> >   sba_freeup_channel_resources(sba);
> >  fail_free_mchan:
> >   mbox_free_channel(sba->mchan);
> > +fail_exit:
> >   return ret;
> >  }
> >
> >
>
> Looks good to me.
>
> Reviewed-by: Ray Jui 

Re: [PATCH] dmaengine: bcm-sba-raid: Handle mbox_request_channel failure

[Ray Jui]

On 1/9/2019 10:07 PM, Rayagonda Kokatanur wrote:
> Fix kernel NULL pointer dereference error when mbox_request_channel()
> fails to allocate channel.
> 
> Fixes: 4e9f8187aecb ("dmaengine: bcm-sba-raid: Use only single mailbox 
> channel")
> Signed-off-by: Rayagonda Kokatanur 
> ---
>  drivers/dma/bcm-sba-raid.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
> index 72878ac5c78d..77ae74663a45 100644
> --- a/drivers/dma/bcm-sba-raid.c
> +++ b/drivers/dma/bcm-sba-raid.c
> @@ -1690,7 +1690,7 @@ static int sba_probe(struct platform_device *pdev)
>   sba->mchan = mbox_request_channel(>client, 0);
>   if (IS_ERR(sba->mchan)) {
>   ret = PTR_ERR(sba->mchan);
> - goto fail_free_mchan;
> + goto fail_exit;
>   }
>  
>   /* Find-out underlying mailbox device */
> @@ -1747,6 +1747,7 @@ static int sba_probe(struct platform_device *pdev)
>   sba_freeup_channel_resources(sba);
>  fail_free_mchan:
>   mbox_free_channel(sba->mchan);
> +fail_exit:
>   return ret;
>  }
>  
> 

Looks good to me.

Reviewed-by: Ray Jui