Re: [PATCH] dmaengine: edma: Implement device_synchronize callback

[kbuild test robot]

Hi Peter,

[auto build test ERROR on slave-dma/next]
[also build test ERROR on v4.5-rc3 next-20160211]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improving the system]

url:
https://github.com/0day-ci/linux/commits/Peter-Ujfalusi/dmaengine-edma-Implement-device_synchronize-callback/20160211-170011
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git next
config: arm-multi_v7_defconfig (attached as .config)
reproduce:
wget 
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
 -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   drivers/dma/edma.c: In function 'edma_synchronize':
>> drivers/dma/edma.c:874:41: error: 'chan' undeclared (first use in this 
>> function)
 struct edma_chan *echan = to_edma_chan(chan);
^
   drivers/dma/edma.c:874:41: note: each undeclared identifier is reported only 
once for each function it appears in

vim +/chan +874 drivers/dma/edma.c

   868  
   869  return 0;
   870  }
   871  
   872  static void edma_synchronize(struct dma_chan *c)
   873  {
 > 874  struct edma_chan *echan = to_edma_chan(chan);
   875  
   876  vchan_synchronize(>vchan);
   877  }

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: Binary data

Re: [PATCH] dmaengine: edma: Implement device_synchronize callback

[Peter Ujfalusi]

On 02/11/2016 10:54 AM, Peter Ujfalusi wrote:
> We need the callback to support the dmaengine_terminate_sync().

I have made some typos and I only compiled the kernel after sending the patch..
Resending.

> 
> Signed-off-by: Peter Ujfalusi 
> ---
>  drivers/dma/edma.c | 9 +
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index 2dac314a2d7a..ea0d919a3318 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -869,6 +869,13 @@ static int edma_terminate_all(struct dma_chan *chan)
>   return 0;
>  }
>  
> +static void edma_synchronize(struct dma_chan *c)
> +{
> + struct edma_chan *echan = to_edma_chan(chan);
> +
> + vchan_synchronize(>vchan);
> +}
> +
>  static int edma_slave_config(struct dma_chan *chan,
>   struct dma_slave_config *cfg)
>  {
> @@ -1808,6 +1815,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool 
> legacy_mode)
>   s_ddev->device_pause = edma_dma_pause;
>   s_ddev->device_resume = edma_dma_resume;
>   s_ddev->device_terminate_all = edma_terminate_all;
> + s_ddev->device_synchronize = edma_synchronize;
>  
>   s_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
>   s_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
> @@ -1833,6 +1841,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool 
> legacy_mode)
>   m_ddev->device_pause = edma_dma_pause;
>   m_ddev->device_resume = edma_dma_resume;
>   m_ddev->device_terminate_all = edma_terminate_all;
> + m_ddev->device_synchronize = edma_synchronize;
>  
>   m_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
>   m_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
> 


-- 
Péter

[PATCH] dmaengine: edma: Implement device_synchronize callback

[Peter Ujfalusi]

We need the callback to support the dmaengine_terminate_sync().

Signed-off-by: Peter Ujfalusi 
---
 drivers/dma/edma.c | 9 +
 1 file changed, 9 insertions(+)

diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index 2dac314a2d7a..ea0d919a3318 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -869,6 +869,13 @@ static int edma_terminate_all(struct dma_chan *chan)
return 0;
 }
 
+static void edma_synchronize(struct dma_chan *c)
+{
+   struct edma_chan *echan = to_edma_chan(chan);
+
+   vchan_synchronize(>vchan);
+}
+
 static int edma_slave_config(struct dma_chan *chan,
struct dma_slave_config *cfg)
 {
@@ -1808,6 +1815,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool 
legacy_mode)
s_ddev->device_pause = edma_dma_pause;
s_ddev->device_resume = edma_dma_resume;
s_ddev->device_terminate_all = edma_terminate_all;
+   s_ddev->device_synchronize = edma_synchronize;
 
s_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
s_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
@@ -1833,6 +1841,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool 
legacy_mode)
m_ddev->device_pause = edma_dma_pause;
m_ddev->device_resume = edma_dma_resume;
m_ddev->device_terminate_all = edma_terminate_all;
+   m_ddev->device_synchronize = edma_synchronize;
 
m_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
m_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
-- 
2.7.1

Re: [PATCH] dmaengine: edma: Implement device_synchronize callback

[Peter Ujfalusi]

On 02/11/2016 10:54 AM, Peter Ujfalusi wrote:
> We need the callback to support the dmaengine_terminate_sync().

I have made some typos and I only compiled the kernel after sending the patch..
Resending.

> 
> Signed-off-by: Peter Ujfalusi 
> ---
>  drivers/dma/edma.c | 9 +
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index 2dac314a2d7a..ea0d919a3318 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -869,6 +869,13 @@ static int edma_terminate_all(struct dma_chan *chan)
>   return 0;
>  }
>  
> +static void edma_synchronize(struct dma_chan *c)
> +{
> + struct edma_chan *echan = to_edma_chan(chan);
> +
> + vchan_synchronize(>vchan);
> +}
> +
>  static int edma_slave_config(struct dma_chan *chan,
>   struct dma_slave_config *cfg)
>  {
> @@ -1808,6 +1815,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool 
> legacy_mode)
>   s_ddev->device_pause = edma_dma_pause;
>   s_ddev->device_resume = edma_dma_resume;
>   s_ddev->device_terminate_all = edma_terminate_all;
> + s_ddev->device_synchronize = edma_synchronize;
>  
>   s_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
>   s_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
> @@ -1833,6 +1841,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool 
> legacy_mode)
>   m_ddev->device_pause = edma_dma_pause;
>   m_ddev->device_resume = edma_dma_resume;
>   m_ddev->device_terminate_all = edma_terminate_all;
> + m_ddev->device_synchronize = edma_synchronize;
>  
>   m_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
>   m_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
> 


-- 
Péter

[PATCH] dmaengine: edma: Implement device_synchronize callback

[Peter Ujfalusi]

We need the callback to support the dmaengine_terminate_sync().

Signed-off-by: Peter Ujfalusi 
---
 drivers/dma/edma.c | 9 +
 1 file changed, 9 insertions(+)

diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index 2dac314a2d7a..ea0d919a3318 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -869,6 +869,13 @@ static int edma_terminate_all(struct dma_chan *chan)
return 0;
 }
 
+static void edma_synchronize(struct dma_chan *c)
+{
+   struct edma_chan *echan = to_edma_chan(chan);
+
+   vchan_synchronize(>vchan);
+}
+
 static int edma_slave_config(struct dma_chan *chan,
struct dma_slave_config *cfg)
 {
@@ -1808,6 +1815,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool 
legacy_mode)
s_ddev->device_pause = edma_dma_pause;
s_ddev->device_resume = edma_dma_resume;
s_ddev->device_terminate_all = edma_terminate_all;
+   s_ddev->device_synchronize = edma_synchronize;
 
s_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
s_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
@@ -1833,6 +1841,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool 
legacy_mode)
m_ddev->device_pause = edma_dma_pause;
m_ddev->device_resume = edma_dma_resume;
m_ddev->device_terminate_all = edma_terminate_all;
+   m_ddev->device_synchronize = edma_synchronize;
 
m_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
m_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
-- 
2.7.1

Re: [PATCH] dmaengine: edma: Implement device_synchronize callback

[kbuild test robot]

Hi Peter,

[auto build test ERROR on slave-dma/next]
[also build test ERROR on v4.5-rc3 next-20160211]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improving the system]

url:
https://github.com/0day-ci/linux/commits/Peter-Ujfalusi/dmaengine-edma-Implement-device_synchronize-callback/20160211-170011
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git next
config: arm-multi_v7_defconfig (attached as .config)
reproduce:
wget 
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
 -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   drivers/dma/edma.c: In function 'edma_synchronize':
>> drivers/dma/edma.c:874:41: error: 'chan' undeclared (first use in this 
>> function)
 struct edma_chan *echan = to_edma_chan(chan);
^
   drivers/dma/edma.c:874:41: note: each undeclared identifier is reported only 
once for each function it appears in

vim +/chan +874 drivers/dma/edma.c

   868  
   869  return 0;
   870  }
   871  
   872  static void edma_synchronize(struct dma_chan *c)
   873  {
 > 874  struct edma_chan *echan = to_edma_chan(chan);
   875  
   876  vchan_synchronize(>vchan);
   877  }

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: Binary data