Re: [PATCH] doc: rcu: Fix code listing in performance and scalability requirements

2018-10-15 Thread Paul E. McKenney 
On Sun, Oct 14, 2018 at 07:29:42PM -0700, Joel Fernandes (Google) wrote:
> The code listing under this section has a quick quiz that says line 19
> uses rcu_access_pointer, but the code listing itself does not. Fix this.
> 
> Signed-off-by: Joel Fernandes (Google) 

Good eyes!  Queued for the merge window after this coming one,
thank you!

Thanx, Paul

> ---
>  .../RCU/Design/Requirements/Requirements.html|  2 +-
>  kernel/sys.c | 16 
>  2 files changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/RCU/Design/Requirements/Requirements.html 
> b/Documentation/RCU/Design/Requirements/Requirements.html
> index 4fae55056c1d..f74a2233865c 100644
> --- a/Documentation/RCU/Design/Requirements/Requirements.html
> +++ b/Documentation/RCU/Design/Requirements/Requirements.html
> @@ -1596,7 +1596,7 @@ used in place of synchronize_rcu() as follows:
>  16   struct foo *p;
>  17
>  18   spin_lock(gp_lock);
> -19   p = rcu_dereference(gp);
> +19   p = rcu_access_pointer(gp);
>  20   if (!p) {
>  21 spin_unlock(gp_lock);
>  22 return false;
> -- 
> 2.19.0.605.g01d371f741-goog
>

Re: [PATCH] doc: rcu: Fix code listing in performance and scalability requirements

2018-10-15 Thread Paul E. McKenney 
On Sun, Oct 14, 2018 at 07:29:42PM -0700, Joel Fernandes (Google) wrote:
> The code listing under this section has a quick quiz that says line 19
> uses rcu_access_pointer, but the code listing itself does not. Fix this.
> 
> Signed-off-by: Joel Fernandes (Google) 

Good eyes!  Queued for the merge window after this coming one,
thank you!

Thanx, Paul

> ---
>  .../RCU/Design/Requirements/Requirements.html|  2 +-
>  kernel/sys.c | 16 
>  2 files changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/RCU/Design/Requirements/Requirements.html 
> b/Documentation/RCU/Design/Requirements/Requirements.html
> index 4fae55056c1d..f74a2233865c 100644
> --- a/Documentation/RCU/Design/Requirements/Requirements.html
> +++ b/Documentation/RCU/Design/Requirements/Requirements.html
> @@ -1596,7 +1596,7 @@ used in place of synchronize_rcu() as follows:
>  16   struct foo *p;
>  17
>  18   spin_lock(gp_lock);
> -19   p = rcu_dereference(gp);
> +19   p = rcu_access_pointer(gp);
>  20   if (!p) {
>  21 spin_unlock(gp_lock);
>  22 return false;
> -- 
> 2.19.0.605.g01d371f741-goog
>

[PATCH] doc: rcu: Fix code listing in performance and scalability requirements

2018-10-14 Thread Joel Fernandes (Google) 
The code listing under this section has a quick quiz that says line 19
uses rcu_access_pointer, but the code listing itself does not. Fix this.

Signed-off-by: Joel Fernandes (Google) 
---
 .../RCU/Design/Requirements/Requirements.html|  2 +-
 kernel/sys.c | 16 
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/Documentation/RCU/Design/Requirements/Requirements.html 
b/Documentation/RCU/Design/Requirements/Requirements.html
index 4fae55056c1d..f74a2233865c 100644
--- a/Documentation/RCU/Design/Requirements/Requirements.html
+++ b/Documentation/RCU/Design/Requirements/Requirements.html
@@ -1596,7 +1596,7 @@ used in place of synchronize_rcu() as follows:
 16   struct foo *p;
 17
 18   spin_lock(gp_lock);
-19   p = rcu_dereference(gp);
+19   p = rcu_access_pointer(gp);
 20   if (!p) {
 21 spin_unlock(gp_lock);
 22 return false;
-- 
2.19.0.605.g01d371f741-goog

[PATCH] doc: rcu: Fix code listing in performance and scalability requirements

2018-10-14 Thread Joel Fernandes (Google) 
The code listing under this section has a quick quiz that says line 19
uses rcu_access_pointer, but the code listing itself does not. Fix this.

Signed-off-by: Joel Fernandes (Google) 
---
 .../RCU/Design/Requirements/Requirements.html|  2 +-
 kernel/sys.c | 16 
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/Documentation/RCU/Design/Requirements/Requirements.html 
b/Documentation/RCU/Design/Requirements/Requirements.html
index 4fae55056c1d..f74a2233865c 100644
--- a/Documentation/RCU/Design/Requirements/Requirements.html
+++ b/Documentation/RCU/Design/Requirements/Requirements.html
@@ -1596,7 +1596,7 @@ used in place of synchronize_rcu() as follows:
 16   struct foo *p;
 17
 18   spin_lock(gp_lock);
-19   p = rcu_dereference(gp);
+19   p = rcu_access_pointer(gp);
 20   if (!p) {
 21 spin_unlock(gp_lock);
 22 return false;
-- 
2.19.0.605.g01d371f741-goog