[PATCH] drivers/pci/hotplug/cpqphp_core.c: fix a check after use

[Greg KH]

ChangeSet 1.2181.16.20, 2005/03/28 15:10:15-08:00, [EMAIL PROTECTED]

[PATCH] drivers/pci/hotplug/cpqphp_core.c: fix a check after use

This patch fixes a check after use found by the Coverity checker.

Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>


 drivers/pci/hotplug/cpqphp_core.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


diff -Nru a/drivers/pci/hotplug/cpqphp_core.c 
b/drivers/pci/hotplug/cpqphp_core.c
--- a/drivers/pci/hotplug/cpqphp_core.c 2005-04-01 15:33:05 -08:00
+++ b/drivers/pci/hotplug/cpqphp_core.c 2005-04-01 15:33:05 -08:00
@@ -577,10 +577,10 @@
 {
u8 hp_slot;
 
-   hp_slot = func->device - ctrl->slot_device_offset;
-
if (func == NULL)
return(1);
+
+   hp_slot = func->device - ctrl->slot_device_offset;
 
// Wait for exclusive access to hardware
down(&ctrl->crit_sect);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [2.6 patch] drivers/pci/hotplug/cpqphp_core.c: fix a check after use

[Greg KH]

On Fri, Mar 25, 2005 at 01:21:55AM +0100, Adrian Bunk wrote:
> This patch fixes a check after use found by the Coverity checker.

Applied, thanks.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[2.6 patch] drivers/pci/hotplug/cpqphp_core.c: fix a check after use

[Adrian Bunk]

This patch fixes a check after use found by the Coverity checker.

Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

--- linux-2.6.12-rc1-mm1-full/drivers/pci/hotplug/cpqphp_core.c.old 
2005-03-23 05:10:34.0 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/pci/hotplug/cpqphp_core.c 2005-03-23 
05:10:55.0 +0100
@@ -577,11 +577,11 @@ cpqhp_set_attention_status(struct contro
 {
u8 hp_slot;
 
-   hp_slot = func->device - ctrl->slot_device_offset;
-
if (func == NULL)
return(1);
 
+   hp_slot = func->device - ctrl->slot_device_offset;
+
// Wait for exclusive access to hardware
down(&ctrl->crit_sect);
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/