[PATCH] drivers/pci/msi.c: fix a check after use

2005-04-01 Thread Greg KH
ChangeSet 1.2181.16.24, 2005/03/28 15:20:34-08:00, [EMAIL PROTECTED]

[PATCH] drivers/pci/msi.c: fix a check after use

This patch fixes a check after use found by the Coverity checker.

Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>


 drivers/pci/msi.c |4 +++-
 1 files changed, 3 insertions(+), 1 deletion(-)


diff -Nru a/drivers/pci/msi.c b/drivers/pci/msi.c
--- a/drivers/pci/msi.c 2005-04-01 15:31:25 -08:00
+++ b/drivers/pci/msi.c 2005-04-01 15:31:25 -08:00
@@ -703,11 +703,13 @@
  **/
 int pci_enable_msi(struct pci_dev* dev)
 {
-   int pos, temp = dev->irq, status = -EINVAL;
+   int pos, temp, status = -EINVAL;
u16 control;
 
if (!pci_msi_enable || !dev)
return status;
+
+   temp = dev->irq;
 
if ((status = msi_init()) < 0)
return status;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] drivers/pci/msi.c: fix a check after use

2005-04-01 Thread Greg KH
ChangeSet 1.2181.16.24, 2005/03/28 15:20:34-08:00, [EMAIL PROTECTED]

[PATCH] drivers/pci/msi.c: fix a check after use

This patch fixes a check after use found by the Coverity checker.

Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED]


 drivers/pci/msi.c |4 +++-
 1 files changed, 3 insertions(+), 1 deletion(-)


diff -Nru a/drivers/pci/msi.c b/drivers/pci/msi.c
--- a/drivers/pci/msi.c 2005-04-01 15:31:25 -08:00
+++ b/drivers/pci/msi.c 2005-04-01 15:31:25 -08:00
@@ -703,11 +703,13 @@
  **/
 int pci_enable_msi(struct pci_dev* dev)
 {
-   int pos, temp = dev-irq, status = -EINVAL;
+   int pos, temp, status = -EINVAL;
u16 control;
 
if (!pci_msi_enable || !dev)
return status;
+
+   temp = dev-irq;
 
if ((status = msi_init())  0)
return status;

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [2.6 patch] drivers/pci/msi.c: fix a check after use

2005-03-28 Thread Greg KH
On Sun, Mar 27, 2005 at 11:15:24PM +0200, Adrian Bunk wrote:
> This patch fixes a check after use found by the Coverity checker.
> 
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

Applied, thanks.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [2.6 patch] drivers/pci/msi.c: fix a check after use

2005-03-28 Thread Greg KH
On Sun, Mar 27, 2005 at 11:15:24PM +0200, Adrian Bunk wrote:
 This patch fixes a check after use found by the Coverity checker.
 
 Signed-off-by: Adrian Bunk [EMAIL PROTECTED]

Applied, thanks.

greg k-h
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[2.6 patch] drivers/pci/msi.c: fix a check after use

2005-03-27 Thread Adrian Bunk
This patch fixes a check after use found by the Coverity checker.

Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

--- linux-2.6.12-rc1-mm1-full/drivers/pci/msi.c.old 2005-03-23 
04:46:30.0 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/pci/msi.c 2005-03-23 04:47:03.0 
+0100
@@ -703,12 +703,14 @@
  **/
 int pci_enable_msi(struct pci_dev* dev)
 {
-   int pos, temp = dev->irq, status = -EINVAL;
+   int pos, temp, status = -EINVAL;
u16 control;
 
if (!pci_msi_enable || !dev)
return status;
 
+   temp = dev->irq;
+
if ((status = msi_init()) < 0)
return status;
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[2.6 patch] drivers/pci/msi.c: fix a check after use

2005-03-27 Thread Adrian Bunk
This patch fixes a check after use found by the Coverity checker.

Signed-off-by: Adrian Bunk [EMAIL PROTECTED]

--- linux-2.6.12-rc1-mm1-full/drivers/pci/msi.c.old 2005-03-23 
04:46:30.0 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/pci/msi.c 2005-03-23 04:47:03.0 
+0100
@@ -703,12 +703,14 @@
  **/
 int pci_enable_msi(struct pci_dev* dev)
 {
-   int pos, temp = dev-irq, status = -EINVAL;
+   int pos, temp, status = -EINVAL;
u16 control;
 
if (!pci_msi_enable || !dev)
return status;
 
+   temp = dev-irq;
+
if ((status = msi_init())  0)
return status;
 

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/