Re: [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

2016-10-09 Thread Greg Kroah-Hartman 
On Fri, Oct 07, 2016 at 05:04:16PM -0700, Chase Metzger wrote:
> Added braces to else statements where checkpatch complained.
> 
> Signed-off-by: Chase Metzger 

You used the same subject here as your last patch, which implies it did
the same thing, yet it did not :(

So please make the subject unique.

thanks,

greg k-h

Re: [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

2016-10-09 Thread Greg Kroah-Hartman 
On Fri, Oct 07, 2016 at 05:04:16PM -0700, Chase Metzger wrote:
> Added braces to else statements where checkpatch complained.
> 
> Signed-off-by: Chase Metzger 

You used the same subject here as your last patch, which implies it did
the same thing, yet it did not :(

So please make the subject unique.

thanks,

greg k-h

[PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

2016-10-07 Thread Chase Metzger 
Added braces to else statements where checkpatch complained.

Signed-off-by: Chase Metzger 
---
 drivers/staging/greybus/audio_codec.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/audio_codec.c 
b/drivers/staging/greybus/audio_codec.c
index 8a0744b..1bdf849 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -655,8 +655,10 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, 
int mute, int stream)
ret = gb_audio_apbridgea_shutdown_rx(data->connection,
 0);
params->state = GBAUDIO_CODEC_STOP;
-   } else
+   } else {
ret = -EINVAL;
+   }
+
if (ret)
dev_err_ratelimited(dai->dev,
"%s:Error during %s %s stream:%d\n",
-- 
2.1.4

[PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

2016-10-07 Thread Chase Metzger 
Added braces to else statements where checkpatch complained.

Signed-off-by: Chase Metzger 
---
 drivers/staging/greybus/audio_codec.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/audio_codec.c 
b/drivers/staging/greybus/audio_codec.c
index 8a0744b..1bdf849 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -655,8 +655,10 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, 
int mute, int stream)
ret = gb_audio_apbridgea_shutdown_rx(data->connection,
 0);
params->state = GBAUDIO_CODEC_STOP;
-   } else
+   } else {
ret = -EINVAL;
+   }
+
if (ret)
dev_err_ratelimited(dai->dev,
"%s:Error during %s %s stream:%d\n",
-- 
2.1.4

Re: [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

2016-10-06 Thread Vaibhav Agarwal 
On Fri, Oct 7, 2016 at 8:08 AM, Chase Metzger  wrote:
> Added braces to else statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger 
> ---

Reviewed-by: Vaibhav Agarwal

Re: [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

2016-10-06 Thread Vaibhav Agarwal 
On Fri, Oct 7, 2016 at 8:08 AM, Chase Metzger  wrote:
> Added braces to else statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger 
> ---

Reviewed-by: Vaibhav Agarwal

Re: [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

2016-10-06 Thread Viresh Kumar 
On Fri, Oct 7, 2016 at 8:08 AM, Chase Metzger  wrote:
> Added braces to else statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger 
> ---
>  drivers/staging/greybus/audio_topology.c | 7 +--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Acked-by: Viresh Kumar

Re: [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

2016-10-06 Thread Viresh Kumar 
On Fri, Oct 7, 2016 at 8:08 AM, Chase Metzger  wrote:
> Added braces to else statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger 
> ---
>  drivers/staging/greybus/audio_topology.c | 7 +--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Acked-by: Viresh Kumar

[PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

2016-10-06 Thread Chase Metzger 
Added braces to else statements where checkpatch complained.

Signed-off-by: Chase Metzger 
---
 drivers/staging/greybus/audio_topology.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/audio_topology.c 
b/drivers/staging/greybus/audio_topology.c
index b625169..3a2678e 100644
--- a/drivers/staging/greybus/audio_topology.c
+++ b/drivers/staging/greybus/audio_topology.c
@@ -1044,8 +1044,10 @@ static int gbaudio_tplg_create_widget(struct 
gbaudio_module_info *module,
control->texts = (const char * const *)
gb_generate_enum_strings(module, gbenum);
control->items = gbenum->items;
-   } else
+   } else {
csize = sizeof(struct gb_audio_control);
+   }
+
*w_size += csize;
curr = (void *)curr + csize;
list_add(>list, >widget_ctl_list);
@@ -1190,8 +1192,9 @@ static int gbaudio_tplg_process_kcontrols(struct 
gbaudio_module_info *module,
control->texts = (const char * const *)
gb_generate_enum_strings(module, gbenum);
control->items = gbenum->items;
-   } else
+   } else {
csize = sizeof(struct gb_audio_control);
+   }
 
list_add(>list, >ctl_list);
dev_dbg(module->dev, "%d:%s created of type %d\n", curr->id,
-- 
2.1.4

[PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

2016-10-06 Thread Chase Metzger 
Added braces to else statements where checkpatch complained.

Signed-off-by: Chase Metzger 
---
 drivers/staging/greybus/audio_topology.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/audio_topology.c 
b/drivers/staging/greybus/audio_topology.c
index b625169..3a2678e 100644
--- a/drivers/staging/greybus/audio_topology.c
+++ b/drivers/staging/greybus/audio_topology.c
@@ -1044,8 +1044,10 @@ static int gbaudio_tplg_create_widget(struct 
gbaudio_module_info *module,
control->texts = (const char * const *)
gb_generate_enum_strings(module, gbenum);
control->items = gbenum->items;
-   } else
+   } else {
csize = sizeof(struct gb_audio_control);
+   }
+
*w_size += csize;
curr = (void *)curr + csize;
list_add(>list, >widget_ctl_list);
@@ -1190,8 +1192,9 @@ static int gbaudio_tplg_process_kcontrols(struct 
gbaudio_module_info *module,
control->texts = (const char * const *)
gb_generate_enum_strings(module, gbenum);
control->items = gbenum->items;
-   } else
+   } else {
csize = sizeof(struct gb_audio_control);
+   }
 
list_add(>list, >ctl_list);
dev_dbg(module->dev, "%d:%s created of type %d\n", curr->id,
-- 
2.1.4