Re: [PATCH] drm: msm: remove unused variable

2016-04-25 Thread Rob Clark 
On Sun, Apr 24, 2016 at 6:15 PM, Arnd Bergmann  wrote:
> On Saturday 16 April 2016 16:49:08 Rob Clark wrote:
>> On Sat, Apr 16, 2016 at 4:41 PM, Arnd Bergmann  wrote:
>> > A recent cleanup removed the only user of the 'kms' variable in
>> > msm_preclose(), causing a harmless compiler warning:
>> >
>> > drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose':
>> > drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' 
>> > [-Werror=unused-variable]
>> >
>> > This removes the variable as well.
>> >
>> > Signed-off-by: Arnd Bergmann 
>> > Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal")
>>
>> thanks, I'll pull that in for 4.7.. danvet actually pointed that out
>> to me yesterday (a needed fix of a fix.. ;-))
>
> I just realized that this is now the only defconfig warning we get in v4.6 
> with
> a recent compiler. Any chance we can still squeeze this in the current 
> release?

I don't have anything else to send for -fixes at the moment, but

Signed-off-by: Rob Clark 

Dave, if you are sending another -fixes, mind grabbing this:

  git pw apply -s 5827

(or if you are still on the old pw, 'pwclient git-am 8277241')

BR,
-R

> Arnd

Re: [PATCH] drm: msm: remove unused variable

2016-04-25 Thread Rob Clark 
On Sun, Apr 24, 2016 at 6:15 PM, Arnd Bergmann  wrote:
> On Saturday 16 April 2016 16:49:08 Rob Clark wrote:
>> On Sat, Apr 16, 2016 at 4:41 PM, Arnd Bergmann  wrote:
>> > A recent cleanup removed the only user of the 'kms' variable in
>> > msm_preclose(), causing a harmless compiler warning:
>> >
>> > drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose':
>> > drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' 
>> > [-Werror=unused-variable]
>> >
>> > This removes the variable as well.
>> >
>> > Signed-off-by: Arnd Bergmann 
>> > Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal")
>>
>> thanks, I'll pull that in for 4.7.. danvet actually pointed that out
>> to me yesterday (a needed fix of a fix.. ;-))
>
> I just realized that this is now the only defconfig warning we get in v4.6 
> with
> a recent compiler. Any chance we can still squeeze this in the current 
> release?

I don't have anything else to send for -fixes at the moment, but

Signed-off-by: Rob Clark 

Dave, if you are sending another -fixes, mind grabbing this:

  git pw apply -s 5827

(or if you are still on the old pw, 'pwclient git-am 8277241')

BR,
-R

> Arnd

Re: [PATCH] drm: msm: remove unused variable

2016-04-24 Thread Arnd Bergmann 
On Saturday 16 April 2016 16:49:08 Rob Clark wrote:
> On Sat, Apr 16, 2016 at 4:41 PM, Arnd Bergmann  wrote:
> > A recent cleanup removed the only user of the 'kms' variable in
> > msm_preclose(), causing a harmless compiler warning:
> >
> > drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose':
> > drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' 
> > [-Werror=unused-variable]
> >
> > This removes the variable as well.
> >
> > Signed-off-by: Arnd Bergmann 
> > Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal")
> 
> thanks, I'll pull that in for 4.7.. danvet actually pointed that out
> to me yesterday (a needed fix of a fix.. ;-))

I just realized that this is now the only defconfig warning we get in v4.6 with
a recent compiler. Any chance we can still squeeze this in the current release?

Arnd

Re: [PATCH] drm: msm: remove unused variable

2016-04-24 Thread Arnd Bergmann 
On Saturday 16 April 2016 16:49:08 Rob Clark wrote:
> On Sat, Apr 16, 2016 at 4:41 PM, Arnd Bergmann  wrote:
> > A recent cleanup removed the only user of the 'kms' variable in
> > msm_preclose(), causing a harmless compiler warning:
> >
> > drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose':
> > drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' 
> > [-Werror=unused-variable]
> >
> > This removes the variable as well.
> >
> > Signed-off-by: Arnd Bergmann 
> > Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal")
> 
> thanks, I'll pull that in for 4.7.. danvet actually pointed that out
> to me yesterday (a needed fix of a fix.. ;-))

I just realized that this is now the only defconfig warning we get in v4.6 with
a recent compiler. Any chance we can still squeeze this in the current release?

Arnd

Re: [PATCH] drm: msm: remove unused variable

2016-04-16 Thread Rob Clark 
On Sat, Apr 16, 2016 at 4:41 PM, Arnd Bergmann  wrote:
> A recent cleanup removed the only user of the 'kms' variable in
> msm_preclose(), causing a harmless compiler warning:
>
> drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose':
> drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' 
> [-Werror=unused-variable]
>
> This removes the variable as well.
>
> Signed-off-by: Arnd Bergmann 
> Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal")

thanks, I'll pull that in for 4.7.. danvet actually pointed that out
to me yesterday (a needed fix of a fix.. ;-))

BR,
-R

> ---
>  drivers/gpu/drm/msm/msm_drv.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index c03b96709179..701c51ed3e7c 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -465,7 +465,6 @@ static void msm_preclose(struct drm_device *dev, struct 
> drm_file *file)
>  {
> struct msm_drm_private *priv = dev->dev_private;
> struct msm_file_private *ctx = file->driver_priv;
> -   struct msm_kms *kms = priv->kms;
>
> mutex_lock(>struct_mutex);
> if (ctx == priv->lastctx)
> --
> 2.7.0
>

Re: [PATCH] drm: msm: remove unused variable

2016-04-16 Thread Rob Clark 
On Sat, Apr 16, 2016 at 4:41 PM, Arnd Bergmann  wrote:
> A recent cleanup removed the only user of the 'kms' variable in
> msm_preclose(), causing a harmless compiler warning:
>
> drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose':
> drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' 
> [-Werror=unused-variable]
>
> This removes the variable as well.
>
> Signed-off-by: Arnd Bergmann 
> Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal")

thanks, I'll pull that in for 4.7.. danvet actually pointed that out
to me yesterday (a needed fix of a fix.. ;-))

BR,
-R

> ---
>  drivers/gpu/drm/msm/msm_drv.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index c03b96709179..701c51ed3e7c 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -465,7 +465,6 @@ static void msm_preclose(struct drm_device *dev, struct 
> drm_file *file)
>  {
> struct msm_drm_private *priv = dev->dev_private;
> struct msm_file_private *ctx = file->driver_priv;
> -   struct msm_kms *kms = priv->kms;
>
> mutex_lock(>struct_mutex);
> if (ctx == priv->lastctx)
> --
> 2.7.0
>

[PATCH] drm: msm: remove unused variable

2016-04-16 Thread Arnd Bergmann 
A recent cleanup removed the only user of the 'kms' variable in
msm_preclose(), causing a harmless compiler warning:

drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose':
drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' 
[-Werror=unused-variable]

This removes the variable as well.

Signed-off-by: Arnd Bergmann 
Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal")
---
 drivers/gpu/drm/msm/msm_drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index c03b96709179..701c51ed3e7c 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -465,7 +465,6 @@ static void msm_preclose(struct drm_device *dev, struct 
drm_file *file)
 {
struct msm_drm_private *priv = dev->dev_private;
struct msm_file_private *ctx = file->driver_priv;
-   struct msm_kms *kms = priv->kms;
 
mutex_lock(>struct_mutex);
if (ctx == priv->lastctx)
-- 
2.7.0

[PATCH] drm: msm: remove unused variable

2016-04-16 Thread Arnd Bergmann 
A recent cleanup removed the only user of the 'kms' variable in
msm_preclose(), causing a harmless compiler warning:

drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose':
drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' 
[-Werror=unused-variable]

This removes the variable as well.

Signed-off-by: Arnd Bergmann 
Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal")
---
 drivers/gpu/drm/msm/msm_drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index c03b96709179..701c51ed3e7c 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -465,7 +465,6 @@ static void msm_preclose(struct drm_device *dev, struct 
drm_file *file)
 {
struct msm_drm_private *priv = dev->dev_private;
struct msm_file_private *ctx = file->driver_priv;
-   struct msm_kms *kms = priv->kms;
 
mutex_lock(>struct_mutex);
if (ctx == priv->lastctx)
-- 
2.7.0

Re: [PATCH] drm/msm: remove unused variable

2016-02-11 Thread Daniel Vetter 
On Thu, Feb 11, 2016 at 10:10:00AM +0100, Arnd Bergmann wrote:
> After the drm_device_is_unplugged() was removed, the 'dev' variable is now
> unused, and we get a warning for that:
> 
> drivers/gpu/drm/msm/msm_fbdev.c: In function 'msm_fbdev_mmap':
> drivers/gpu/drm/msm/msm_fbdev.c:65:21: error: unused variable 'dev' 
> [-Werror=unused-variable]
> 
> This removes the variable as well.
> 
> Signed-off-by: Arnd Bergmann 
> Fixes: e9f8250f2f92 ("drm/msm: remove the drm_device_is_unplugged check")

Applied, thanks.
-Daniel

> ---
>  drivers/gpu/drm/msm/msm_fbdev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
> index e119c2979509..d9759bf3482e 100644
> --- a/drivers/gpu/drm/msm/msm_fbdev.c
> +++ b/drivers/gpu/drm/msm/msm_fbdev.c
> @@ -62,7 +62,6 @@ static int msm_fbdev_mmap(struct fb_info *info, struct 
> vm_area_struct *vma)
>   struct drm_fb_helper *helper = (struct drm_fb_helper *)info->par;
>   struct msm_fbdev *fbdev = to_msm_fbdev(helper);
>   struct drm_gem_object *drm_obj = fbdev->bo;
> - struct drm_device *dev = helper->dev;
>   int ret = 0;
>  
>   ret = drm_gem_mmap_obj(drm_obj, drm_obj->size, vma);
> -- 
> 2.7.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

[PATCH] drm/msm: remove unused variable

2016-02-11 Thread Arnd Bergmann 
After the drm_device_is_unplugged() was removed, the 'dev' variable is now
unused, and we get a warning for that:

drivers/gpu/drm/msm/msm_fbdev.c: In function 'msm_fbdev_mmap':
drivers/gpu/drm/msm/msm_fbdev.c:65:21: error: unused variable 'dev' 
[-Werror=unused-variable]

This removes the variable as well.

Signed-off-by: Arnd Bergmann 
Fixes: e9f8250f2f92 ("drm/msm: remove the drm_device_is_unplugged check")
---
 drivers/gpu/drm/msm/msm_fbdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index e119c2979509..d9759bf3482e 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b/drivers/gpu/drm/msm/msm_fbdev.c
@@ -62,7 +62,6 @@ static int msm_fbdev_mmap(struct fb_info *info, struct 
vm_area_struct *vma)
struct drm_fb_helper *helper = (struct drm_fb_helper *)info->par;
struct msm_fbdev *fbdev = to_msm_fbdev(helper);
struct drm_gem_object *drm_obj = fbdev->bo;
-   struct drm_device *dev = helper->dev;
int ret = 0;
 
ret = drm_gem_mmap_obj(drm_obj, drm_obj->size, vma);
-- 
2.7.0

[PATCH] drm/msm: remove unused variable

2016-02-11 Thread Arnd Bergmann 
After the drm_device_is_unplugged() was removed, the 'dev' variable is now
unused, and we get a warning for that:

drivers/gpu/drm/msm/msm_fbdev.c: In function 'msm_fbdev_mmap':
drivers/gpu/drm/msm/msm_fbdev.c:65:21: error: unused variable 'dev' 
[-Werror=unused-variable]

This removes the variable as well.

Signed-off-by: Arnd Bergmann 
Fixes: e9f8250f2f92 ("drm/msm: remove the drm_device_is_unplugged check")
---
 drivers/gpu/drm/msm/msm_fbdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index e119c2979509..d9759bf3482e 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b/drivers/gpu/drm/msm/msm_fbdev.c
@@ -62,7 +62,6 @@ static int msm_fbdev_mmap(struct fb_info *info, struct 
vm_area_struct *vma)
struct drm_fb_helper *helper = (struct drm_fb_helper *)info->par;
struct msm_fbdev *fbdev = to_msm_fbdev(helper);
struct drm_gem_object *drm_obj = fbdev->bo;
-   struct drm_device *dev = helper->dev;
int ret = 0;
 
ret = drm_gem_mmap_obj(drm_obj, drm_obj->size, vma);
-- 
2.7.0

Re: [PATCH] drm/msm: remove unused variable

2016-02-11 Thread Daniel Vetter 
On Thu, Feb 11, 2016 at 10:10:00AM +0100, Arnd Bergmann wrote:
> After the drm_device_is_unplugged() was removed, the 'dev' variable is now
> unused, and we get a warning for that:
> 
> drivers/gpu/drm/msm/msm_fbdev.c: In function 'msm_fbdev_mmap':
> drivers/gpu/drm/msm/msm_fbdev.c:65:21: error: unused variable 'dev' 
> [-Werror=unused-variable]
> 
> This removes the variable as well.
> 
> Signed-off-by: Arnd Bergmann 
> Fixes: e9f8250f2f92 ("drm/msm: remove the drm_device_is_unplugged check")

Applied, thanks.
-Daniel

> ---
>  drivers/gpu/drm/msm/msm_fbdev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
> index e119c2979509..d9759bf3482e 100644
> --- a/drivers/gpu/drm/msm/msm_fbdev.c
> +++ b/drivers/gpu/drm/msm/msm_fbdev.c
> @@ -62,7 +62,6 @@ static int msm_fbdev_mmap(struct fb_info *info, struct 
> vm_area_struct *vma)
>   struct drm_fb_helper *helper = (struct drm_fb_helper *)info->par;
>   struct msm_fbdev *fbdev = to_msm_fbdev(helper);
>   struct drm_gem_object *drm_obj = fbdev->bo;
> - struct drm_device *dev = helper->dev;
>   int ret = 0;
>  
>   ret = drm_gem_mmap_obj(drm_obj, drm_obj->size, vma);
> -- 
> 2.7.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch