Re: [PATCH] edac: Fix build error caused by wrong member access

[Borislav Petkov]

On Tue, Aug 19, 2014 at 05:10:46PM -0400, Pranith Kumar wrote:
> Fix the following error 
> 
> drivers/edac/ppc4xx_edac.c:977:45: error: request for member 'dimm' in 
> something
> not a structure or union
> 
> by changing member access to pointer dereference
> 
> Signed-off-by: Pranith Kumar 
> CC: Andre Morton 

Applied, thanks.

-- 
Regards/Gruss,
Boris.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] edac: Fix build error caused by wrong member access

[Borislav Petkov]

On Tue, Aug 19, 2014 at 05:10:46PM -0400, Pranith Kumar wrote:
 Fix the following error 
 
 drivers/edac/ppc4xx_edac.c:977:45: error: request for member 'dimm' in 
 something
 not a structure or union
 
 by changing member access to pointer dereference
 
 Signed-off-by: Pranith Kumar bobby.pr...@gmail.com
 CC: Andre Morton a...@linux-foundation.org

Applied, thanks.

-- 
Regards/Gruss,
Boris.
--
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] edac: Fix build error caused by wrong member access

[Pranith Kumar]

On Thu, Aug 21, 2014 at 5:28 PM, Andrew Morton
 wrote:
>
> This driver seems pretty unhealthy and I suspect it has been
> broken for quite a while.
>
> drivers/edac/ppc4xx_edac.c: In function 'mfsdram':
> drivers/edac/ppc4xx_edac.c:249: error: implicit declaration of function 
> '__mfdcri'
> drivers/edac/ppc4xx_edac.c: In function 'mtsdram':
> drivers/edac/ppc4xx_edac.c:266: error: implicit declaration of function 
> '__mtdcri'
> drivers/edac/ppc4xx_edac.c:269: warning: 'return' with a value, in function 
> returning void
> drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_init_csrows':
> drivers/edac/ppc4xx_edac.c:924: warning: initialization from incompatible 
> pointer type
> drivers/edac/ppc4xx_edac.c:977: error: request for member 'dimm' in something 
> not a structure or union
> drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_map_dcrs':
> drivers/edac/ppc4xx_edac.c:1209: warning: passing argument 1 of 
> 'dcr_map_mmio' discards qualifiers from pointer target type
>
>

Yes, not sure if anyone is actually using it.

Anways, I will send in a patch to fix the errors which you point out here.

-- 
Pranith
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] edac: Fix build error caused by wrong member access

[Andrew Morton]

On Tue, 19 Aug 2014 17:10:46 -0400 Pranith Kumar  wrote:

> Fix the following error 
> 
> drivers/edac/ppc4xx_edac.c:977:45: error: request for member 'dimm' in 
> something
> not a structure or union
> 
> by changing member access to pointer dereference
> 
> --- a/drivers/edac/ppc4xx_edac.c
> +++ b/drivers/edac/ppc4xx_edac.c
> @@ -974,7 +974,7 @@ static int ppc4xx_edac_init_csrows(struct mem_ctl_info 
> *mci, u32 mcopt1)
>* page size (PAGE_SIZE) or the memory width (2 or 4).
>*/
>   for (j = 0; j < csi->nr_channels; j++) {
> - struct dimm_info *dimm = csi->channels[j].dimm;
> + struct dimm_info *dimm = csi->channels[j]->dimm;
>  
>   dimm->nr_pages  = nr_pages / csi->nr_channels;
>   dimm->grain = 1;

This driver seems pretty unhealthy and I suspect it has been
broken for quite a while.

drivers/edac/ppc4xx_edac.c: In function 'mfsdram':
drivers/edac/ppc4xx_edac.c:249: error: implicit declaration of function 
'__mfdcri'
drivers/edac/ppc4xx_edac.c: In function 'mtsdram':
drivers/edac/ppc4xx_edac.c:266: error: implicit declaration of function 
'__mtdcri'
drivers/edac/ppc4xx_edac.c:269: warning: 'return' with a value, in function 
returning void
drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_init_csrows':
drivers/edac/ppc4xx_edac.c:924: warning: initialization from incompatible 
pointer type
drivers/edac/ppc4xx_edac.c:977: error: request for member 'dimm' in something 
not a structure or union
drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_map_dcrs':
drivers/edac/ppc4xx_edac.c:1209: warning: passing argument 1 of 'dcr_map_mmio' 
discards qualifiers from pointer target type


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] edac: Fix build error caused by wrong member access

[Andrew Morton]

On Tue, 19 Aug 2014 17:10:46 -0400 Pranith Kumar bobby.pr...@gmail.com wrote:

 Fix the following error 
 
 drivers/edac/ppc4xx_edac.c:977:45: error: request for member 'dimm' in 
 something
 not a structure or union
 
 by changing member access to pointer dereference
 
 --- a/drivers/edac/ppc4xx_edac.c
 +++ b/drivers/edac/ppc4xx_edac.c
 @@ -974,7 +974,7 @@ static int ppc4xx_edac_init_csrows(struct mem_ctl_info 
 *mci, u32 mcopt1)
* page size (PAGE_SIZE) or the memory width (2 or 4).
*/
   for (j = 0; j  csi-nr_channels; j++) {
 - struct dimm_info *dimm = csi-channels[j].dimm;
 + struct dimm_info *dimm = csi-channels[j]-dimm;
  
   dimm-nr_pages  = nr_pages / csi-nr_channels;
   dimm-grain = 1;

This driver seems pretty unhealthy and I suspect it has been
broken for quite a while.

drivers/edac/ppc4xx_edac.c: In function 'mfsdram':
drivers/edac/ppc4xx_edac.c:249: error: implicit declaration of function 
'__mfdcri'
drivers/edac/ppc4xx_edac.c: In function 'mtsdram':
drivers/edac/ppc4xx_edac.c:266: error: implicit declaration of function 
'__mtdcri'
drivers/edac/ppc4xx_edac.c:269: warning: 'return' with a value, in function 
returning void
drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_init_csrows':
drivers/edac/ppc4xx_edac.c:924: warning: initialization from incompatible 
pointer type
drivers/edac/ppc4xx_edac.c:977: error: request for member 'dimm' in something 
not a structure or union
drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_map_dcrs':
drivers/edac/ppc4xx_edac.c:1209: warning: passing argument 1 of 'dcr_map_mmio' 
discards qualifiers from pointer target type


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] edac: Fix build error caused by wrong member access

[Pranith Kumar]

On Thu, Aug 21, 2014 at 5:28 PM, Andrew Morton
a...@linux-foundation.org wrote:

 This driver seems pretty unhealthy and I suspect it has been
 broken for quite a while.

 drivers/edac/ppc4xx_edac.c: In function 'mfsdram':
 drivers/edac/ppc4xx_edac.c:249: error: implicit declaration of function 
 '__mfdcri'
 drivers/edac/ppc4xx_edac.c: In function 'mtsdram':
 drivers/edac/ppc4xx_edac.c:266: error: implicit declaration of function 
 '__mtdcri'
 drivers/edac/ppc4xx_edac.c:269: warning: 'return' with a value, in function 
 returning void
 drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_init_csrows':
 drivers/edac/ppc4xx_edac.c:924: warning: initialization from incompatible 
 pointer type
 drivers/edac/ppc4xx_edac.c:977: error: request for member 'dimm' in something 
 not a structure or union
 drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_map_dcrs':
 drivers/edac/ppc4xx_edac.c:1209: warning: passing argument 1 of 
 'dcr_map_mmio' discards qualifiers from pointer target type



Yes, not sure if anyone is actually using it.

Anways, I will send in a patch to fix the errors which you point out here.

-- 
Pranith
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] edac: Fix build error caused by wrong member access

[Pranith Kumar]

Fix the following error 

drivers/edac/ppc4xx_edac.c:977:45: error: request for member 'dimm' in something
not a structure or union

by changing member access to pointer dereference

Signed-off-by: Pranith Kumar 
CC: Andre Morton 
---
 drivers/edac/ppc4xx_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/ppc4xx_edac.c b/drivers/edac/ppc4xx_edac.c
index ef6b7e0..0f04d5e 100644
--- a/drivers/edac/ppc4xx_edac.c
+++ b/drivers/edac/ppc4xx_edac.c
@@ -974,7 +974,7 @@ static int ppc4xx_edac_init_csrows(struct mem_ctl_info 
*mci, u32 mcopt1)
 * page size (PAGE_SIZE) or the memory width (2 or 4).
 */
for (j = 0; j < csi->nr_channels; j++) {
-   struct dimm_info *dimm = csi->channels[j].dimm;
+   struct dimm_info *dimm = csi->channels[j]->dimm;
 
dimm->nr_pages  = nr_pages / csi->nr_channels;
dimm->grain = 1;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] edac: Fix build error caused by wrong member access

[Pranith Kumar]

Fix the following error 

drivers/edac/ppc4xx_edac.c:977:45: error: request for member 'dimm' in something
not a structure or union

by changing member access to pointer dereference

Signed-off-by: Pranith Kumar bobby.pr...@gmail.com
CC: Andre Morton a...@linux-foundation.org
---
 drivers/edac/ppc4xx_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/ppc4xx_edac.c b/drivers/edac/ppc4xx_edac.c
index ef6b7e0..0f04d5e 100644
--- a/drivers/edac/ppc4xx_edac.c
+++ b/drivers/edac/ppc4xx_edac.c
@@ -974,7 +974,7 @@ static int ppc4xx_edac_init_csrows(struct mem_ctl_info 
*mci, u32 mcopt1)
 * page size (PAGE_SIZE) or the memory width (2 or 4).
 */
for (j = 0; j  csi-nr_channels; j++) {
-   struct dimm_info *dimm = csi-channels[j].dimm;
+   struct dimm_info *dimm = csi-channels[j]-dimm;
 
dimm-nr_pages  = nr_pages / csi-nr_channels;
dimm-grain = 1;
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/