Re: [PATCH] efi: Clear EFI_RUNTIME_SERVICES rather than EFI_BOOT by "noefi" boot parameter
On Wed, 2013-02-13 at 17:20 -0800, H. Peter Anvin wrote: > On 02/13/2013 04:12 PM, Satoru Takeuchi wrote: > > From: Satoru Takeuchi > > > > There was a serious problem in samsung-laptop that its platform driver is > > designed to run under BIOS and running under EFI can cause the machine to > > become bricked or can cause Machine Check Exceptions. > > > > Matt, unless you object I'll pick this one up as urgent, please take the > cleanup patch in normal order. No objection from me, this looks correct. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] efi: Clear EFI_RUNTIME_SERVICES rather than EFI_BOOT by "noefi" boot parameter
On 02/13/2013 04:12 PM, Satoru Takeuchi wrote: > From: Satoru Takeuchi > > There was a serious problem in samsung-laptop that its platform driver is > designed to run under BIOS and running under EFI can cause the machine to > become bricked or can cause Machine Check Exceptions. > Matt, unless you object I'll pick this one up as urgent, please take the cleanup patch in normal order. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] efi: Clear EFI_RUNTIME_SERVICES rather than EFI_BOOT by "noefi" boot parameter
From: Satoru Takeuchi
There was a serious problem in samsung-laptop that its platform driver is
designed to run under BIOS and running under EFI can cause the machine to
become bricked or can cause Machine Check Exceptions.
Discussion about this problem:
https://bugs.launchpad.net/ubuntu-cdimage/+bug/1040557
https://bugzilla.kernel.org/show_bug.cgi?id=47121
The patches to fix this problem:
efi: Make 'efi_enabled' a function to query EFI facilities
83e68189745ad931c2afd45d8ee3303929233e7f
samsung-laptop: Disable on EFI hardware
e0094244e41c4d0c7ad69920681972fc45d8ce34
Unfortunately this problem comes back again if users specify "noefi" option.
This parameter clears EFI_BOOT and that driver continues to run even if running
under EFI. Refer to the document, this parameter should clear
EFI_RUNTIME_SERVICES instead.
Documentation/kernel-parameters.txt:
===
...
noefi [X86] Disable EFI runtime services support.
...
===
Documentation/x86/x86_64/uefi.txt:
===
...
- If some or all EFI runtime services don't work, you can try following
kernel command line parameters to turn off some or all EFI runtime
services.
noefi turn off all EFI runtime services
...
===
Signed-off-by: Satoru Takeuchi
Cc: Matt Fleming
Cc: David Airlie
Cc: Corentin Chary
Cc: Matthew Garrett
Cc: Dave Jiang
Cc: Olof Johansson
Cc: Peter Jones
Cc: Colin Ian King
Cc: Steve Langasek
Cc: Tony Luck
Cc: Konrad Rzeszutek Wilk
Cc: Rafael J. Wysocki
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: H. Peter Anvin
Cc: Greg Kroah-Hartman
Cc: sta...@vger.kernel.org
---
arch/x86/platform/efi/efi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 77cf009..928bf83 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -87,7 +87,7 @@ EXPORT_SYMBOL(efi_enabled);
static int __init setup_noefi(char *arg)
{
- clear_bit(EFI_BOOT, _efi_facility);
+ clear_bit(EFI_RUNTIME_SERVICES, _efi_facility);
return 0;
}
early_param("noefi", setup_noefi);
-- 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] efi: Clear EFI_RUNTIME_SERVICES rather than EFI_BOOT by noefi boot parameter
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
There was a serious problem in samsung-laptop that its platform driver is
designed to run under BIOS and running under EFI can cause the machine to
become bricked or can cause Machine Check Exceptions.
Discussion about this problem:
https://bugs.launchpad.net/ubuntu-cdimage/+bug/1040557
https://bugzilla.kernel.org/show_bug.cgi?id=47121
The patches to fix this problem:
efi: Make 'efi_enabled' a function to query EFI facilities
83e68189745ad931c2afd45d8ee3303929233e7f
samsung-laptop: Disable on EFI hardware
e0094244e41c4d0c7ad69920681972fc45d8ce34
Unfortunately this problem comes back again if users specify noefi option.
This parameter clears EFI_BOOT and that driver continues to run even if running
under EFI. Refer to the document, this parameter should clear
EFI_RUNTIME_SERVICES instead.
Documentation/kernel-parameters.txt:
===
...
noefi [X86] Disable EFI runtime services support.
...
===
Documentation/x86/x86_64/uefi.txt:
===
...
- If some or all EFI runtime services don't work, you can try following
kernel command line parameters to turn off some or all EFI runtime
services.
noefi turn off all EFI runtime services
...
===
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Cc: Matt Fleming matt.flem...@intel.com
Cc: David Airlie airl...@linux.ie
Cc: Corentin Chary corenti...@iksaif.net
Cc: Matthew Garrett mj...@srcf.ucam.org
Cc: Dave Jiang dave.ji...@intel.com
Cc: Olof Johansson o...@lixom.net
Cc: Peter Jones pjo...@redhat.com
Cc: Colin Ian King colin.k...@canonical.com
Cc: Steve Langasek steve.langa...@canonical.com
Cc: Tony Luck tony.l...@intel.com
Cc: Konrad Rzeszutek Wilk kon...@kernel.org
Cc: Rafael J. Wysocki r...@sisk.pl
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@linux.intel.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: sta...@vger.kernel.org
---
arch/x86/platform/efi/efi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 77cf009..928bf83 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -87,7 +87,7 @@ EXPORT_SYMBOL(efi_enabled);
static int __init setup_noefi(char *arg)
{
- clear_bit(EFI_BOOT, x86_efi_facility);
+ clear_bit(EFI_RUNTIME_SERVICES, x86_efi_facility);
return 0;
}
early_param(noefi, setup_noefi);
-- 1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] efi: Clear EFI_RUNTIME_SERVICES rather than EFI_BOOT by noefi boot parameter
On 02/13/2013 04:12 PM, Satoru Takeuchi wrote: From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com There was a serious problem in samsung-laptop that its platform driver is designed to run under BIOS and running under EFI can cause the machine to become bricked or can cause Machine Check Exceptions. Matt, unless you object I'll pick this one up as urgent, please take the cleanup patch in normal order. -hpa -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] efi: Clear EFI_RUNTIME_SERVICES rather than EFI_BOOT by noefi boot parameter
On Wed, 2013-02-13 at 17:20 -0800, H. Peter Anvin wrote: On 02/13/2013 04:12 PM, Satoru Takeuchi wrote: From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com There was a serious problem in samsung-laptop that its platform driver is designed to run under BIOS and running under EFI can cause the machine to become bricked or can cause Machine Check Exceptions. Matt, unless you object I'll pick this one up as urgent, please take the cleanup patch in normal order. No objection from me, this looks correct. -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
