Re: [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break
On 07/13/2012 01:16 AM, Mark Brown wrote: > On Thu, Jul 12, 2012 at 01:32:27PM +0900, Chanwoo Choi wrote: >> This patch modify 'Kconfig' of EXTCON Subsystem to support either >> active or inactive of EXTCON Subsystem. The various subsystem refer >> to EXTCON subsystem for controlling external connector, so core class >> of EXTCON should be included in kernel image. If EXTCON subsystem is >> builded with MODULE, other subsystem have build break because of >> linking the core class of EXTCON. > > By this logic very little in the kernel should be a module. We usually > only force things to be built in if there's a technical need for it like > init ordering constraints. Generally this is just a case of making sure > the Kconfig stuff is set up with appropriate dependencies. As you said, I will fix it. Thank you, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break
Hi Greg, On 07/13/2012 12:36 AM, Greg KH wrote: > On Thu, Jul 12, 2012 at 01:32:27PM +0900, Chanwoo Choi wrote: >> This patch modify 'Kconfig' of EXTCON Subsystem to support either >> active or inactive of EXTCON Subsystem. The various subsystem refer >> to EXTCON subsystem for controlling external connector, so core class >> of EXTCON should be included in kernel image. If EXTCON subsystem is >> builded with MODULE, other subsystem have build break because of >> linking the core class of EXTCON. > > Then something else is wrong, as the extcon_class code should be able to > be built as a module. Don't load up systems with kernel code that they > don't need (think of distro kernels that have to build everything.) > > So no, please fix the real problem here, I will not take this patch, > sorry. OK, I will add appropriate dependency to 'Kconfig' of subsystem/driver using EXTCON to resolve build break. Thank you, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break
On Thu, Jul 12, 2012 at 01:32:27PM +0900, Chanwoo Choi wrote: > This patch modify 'Kconfig' of EXTCON Subsystem to support either > active or inactive of EXTCON Subsystem. The various subsystem refer > to EXTCON subsystem for controlling external connector, so core class > of EXTCON should be included in kernel image. If EXTCON subsystem is > builded with MODULE, other subsystem have build break because of > linking the core class of EXTCON. By this logic very little in the kernel should be a module. We usually only force things to be built in if there's a technical need for it like init ordering constraints. Generally this is just a case of making sure the Kconfig stuff is set up with appropriate dependencies. signature.asc Description: Digital signature
Re: [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break
On Thu, Jul 12, 2012 at 01:32:27PM +0900, Chanwoo Choi wrote: > This patch modify 'Kconfig' of EXTCON Subsystem to support either > active or inactive of EXTCON Subsystem. The various subsystem refer > to EXTCON subsystem for controlling external connector, so core class > of EXTCON should be included in kernel image. If EXTCON subsystem is > builded with MODULE, other subsystem have build break because of > linking the core class of EXTCON. Then something else is wrong, as the extcon_class code should be able to be built as a module. Don't load up systems with kernel code that they don't need (think of distro kernels that have to build everything.) So no, please fix the real problem here, I will not take this patch, sorry. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break
Hi Greg, On 07/13/2012 12:36 AM, Greg KH wrote: On Thu, Jul 12, 2012 at 01:32:27PM +0900, Chanwoo Choi wrote: This patch modify 'Kconfig' of EXTCON Subsystem to support either active or inactive of EXTCON Subsystem. The various subsystem refer to EXTCON subsystem for controlling external connector, so core class of EXTCON should be included in kernel image. If EXTCON subsystem is builded with MODULE, other subsystem have build break because of linking the core class of EXTCON. Then something else is wrong, as the extcon_class code should be able to be built as a module. Don't load up systems with kernel code that they don't need (think of distro kernels that have to build everything.) So no, please fix the real problem here, I will not take this patch, sorry. OK, I will add appropriate dependency to 'Kconfig' of subsystem/driver using EXTCON to resolve build break. Thank you, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break
On 07/13/2012 01:16 AM, Mark Brown wrote: On Thu, Jul 12, 2012 at 01:32:27PM +0900, Chanwoo Choi wrote: This patch modify 'Kconfig' of EXTCON Subsystem to support either active or inactive of EXTCON Subsystem. The various subsystem refer to EXTCON subsystem for controlling external connector, so core class of EXTCON should be included in kernel image. If EXTCON subsystem is builded with MODULE, other subsystem have build break because of linking the core class of EXTCON. By this logic very little in the kernel should be a module. We usually only force things to be built in if there's a technical need for it like init ordering constraints. Generally this is just a case of making sure the Kconfig stuff is set up with appropriate dependencies. As you said, I will fix it. Thank you, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break
On Thu, Jul 12, 2012 at 01:32:27PM +0900, Chanwoo Choi wrote: This patch modify 'Kconfig' of EXTCON Subsystem to support either active or inactive of EXTCON Subsystem. The various subsystem refer to EXTCON subsystem for controlling external connector, so core class of EXTCON should be included in kernel image. If EXTCON subsystem is builded with MODULE, other subsystem have build break because of linking the core class of EXTCON. Then something else is wrong, as the extcon_class code should be able to be built as a module. Don't load up systems with kernel code that they don't need (think of distro kernels that have to build everything.) So no, please fix the real problem here, I will not take this patch, sorry. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break
On Thu, Jul 12, 2012 at 01:32:27PM +0900, Chanwoo Choi wrote: This patch modify 'Kconfig' of EXTCON Subsystem to support either active or inactive of EXTCON Subsystem. The various subsystem refer to EXTCON subsystem for controlling external connector, so core class of EXTCON should be included in kernel image. If EXTCON subsystem is builded with MODULE, other subsystem have build break because of linking the core class of EXTCON. By this logic very little in the kernel should be a module. We usually only force things to be built in if there's a technical need for it like init ordering constraints. Generally this is just a case of making sure the Kconfig stuff is set up with appropriate dependencies. signature.asc Description: Digital signature
[PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break
This patch modify 'Kconfig' of EXTCON Subsystem to support either active or inactive of EXTCON Subsystem. The various subsystem refer to EXTCON subsystem for controlling external connector, so core class of EXTCON should be included in kernel image. If EXTCON subsystem is builded with MODULE, other subsystem have build break because of linking the core class of EXTCON. Signed-off-by: Chanwoo Choi Signed-off-by: Myungjoo Ham Signed-off-by: Kyungmin Park --- drivers/extcon/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig index 29c5cf8..b0eac45 100644 --- a/drivers/extcon/Kconfig +++ b/drivers/extcon/Kconfig @@ -1,5 +1,5 @@ menuconfig EXTCON - tristate "External Connector Class (extcon) support" + bool "External Connector Class (extcon) support" help Say Y here to enable external connector class (extcon) support. This allows monitoring external connectors by userspace -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break
This patch modify 'Kconfig' of EXTCON Subsystem to support either active or inactive of EXTCON Subsystem. The various subsystem refer to EXTCON subsystem for controlling external connector, so core class of EXTCON should be included in kernel image. If EXTCON subsystem is builded with MODULE, other subsystem have build break because of linking the core class of EXTCON. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/extcon/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig index 29c5cf8..b0eac45 100644 --- a/drivers/extcon/Kconfig +++ b/drivers/extcon/Kconfig @@ -1,5 +1,5 @@ menuconfig EXTCON - tristate External Connector Class (extcon) support + bool External Connector Class (extcon) support help Say Y here to enable external connector class (extcon) support. This allows monitoring external connectors by userspace -- 1.7.0.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
