Re: [PATCH] extcon: arizona: Free MICDET IRQ on error during probe

2012-08-26 Thread Chanwoo Choi 
On 08/27/2012 05:58 AM, Mark Brown wrote:

> Signed-off-by: Mark Brown 
> ---
>  drivers/extcon/extcon-arizona.c |4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index fa2114f..13eafcb 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -488,11 +488,13 @@ static int __devinit arizona_extcon_probe(struct 
> platform_device *pdev)
>   ret = input_register_device(info->input);
>   if (ret) {
>   dev_err(>dev, "Can't register input device: %d\n", ret);
> - goto err_fall_wake;
> + goto err_micdet;
>   }
>  
>   return 0;
>  
> +err_micdet:
> + arizona_free_irq(arizona, ARIZONA_IRQ_MICDET, info);
>  err_fall_wake:
>   arizona_set_irq_wake(arizona, ARIZONA_IRQ_JD_FALL, 0);
>  err_fall:


Thanks much,

Signed-off-by: Chanwoo Choi 

I will apply this patch to
http://10.90.51.51/cgi-bin/gitweb.cgi?p=linux-samsung;a=shortlog;h=refs/heads/extcon-for-next
and you can check it after some hours.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] extcon: arizona: Free MICDET IRQ on error during probe

2012-08-26 Thread Mark Brown 
Signed-off-by: Mark Brown 
---
 drivers/extcon/extcon-arizona.c |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index fa2114f..13eafcb 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -488,11 +488,13 @@ static int __devinit arizona_extcon_probe(struct 
platform_device *pdev)
ret = input_register_device(info->input);
if (ret) {
dev_err(>dev, "Can't register input device: %d\n", ret);
-   goto err_fall_wake;
+   goto err_micdet;
}
 
return 0;
 
+err_micdet:
+   arizona_free_irq(arizona, ARIZONA_IRQ_MICDET, info);
 err_fall_wake:
arizona_set_irq_wake(arizona, ARIZONA_IRQ_JD_FALL, 0);
 err_fall:
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] extcon: arizona: Free MICDET IRQ on error during probe

2012-08-26 Thread Mark Brown 
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
 drivers/extcon/extcon-arizona.c |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index fa2114f..13eafcb 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -488,11 +488,13 @@ static int __devinit arizona_extcon_probe(struct 
platform_device *pdev)
ret = input_register_device(info-input);
if (ret) {
dev_err(pdev-dev, Can't register input device: %d\n, ret);
-   goto err_fall_wake;
+   goto err_micdet;
}
 
return 0;
 
+err_micdet:
+   arizona_free_irq(arizona, ARIZONA_IRQ_MICDET, info);
 err_fall_wake:
arizona_set_irq_wake(arizona, ARIZONA_IRQ_JD_FALL, 0);
 err_fall:
-- 
1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] extcon: arizona: Free MICDET IRQ on error during probe

2012-08-26 Thread Chanwoo Choi 
On 08/27/2012 05:58 AM, Mark Brown wrote:

 Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
 ---
  drivers/extcon/extcon-arizona.c |4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
 
 diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
 index fa2114f..13eafcb 100644
 --- a/drivers/extcon/extcon-arizona.c
 +++ b/drivers/extcon/extcon-arizona.c
 @@ -488,11 +488,13 @@ static int __devinit arizona_extcon_probe(struct 
 platform_device *pdev)
   ret = input_register_device(info-input);
   if (ret) {
   dev_err(pdev-dev, Can't register input device: %d\n, ret);
 - goto err_fall_wake;
 + goto err_micdet;
   }
  
   return 0;
  
 +err_micdet:
 + arizona_free_irq(arizona, ARIZONA_IRQ_MICDET, info);
  err_fall_wake:
   arizona_set_irq_wake(arizona, ARIZONA_IRQ_JD_FALL, 0);
  err_fall:


Thanks much,

Signed-off-by: Chanwoo Choi cw00.c...@samsung.com

I will apply this patch to
http://10.90.51.51/cgi-bin/gitweb.cgi?p=linux-samsung;a=shortlog;h=refs/heads/extcon-for-next
and you can check it after some hours.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/