Re: [PATCH] extcon: arizona: unlock mutex on error path in arizona_micdet()
On 11/05/2012 05:04 PM, Mark Brown wrote: > On Sun, Nov 04, 2012 at 01:19:46PM -0700, Alexey Khoroshilov wrote: >> If regmap_read() failed, arizona_micdet() returns IRQ_NONE >> leaving >lock mutex locked as opposed to all other return paths. >> >> Found by Linux Driver Verification project (linuxtesting.org). > > Acked-by: Mark Brown Applied, thanks. You can check this patch on extcon git tree: - git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git (for-next branch) Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] extcon: arizona: unlock mutex on error path in arizona_micdet()
On Sun, Nov 04, 2012 at 01:19:46PM -0700, Alexey Khoroshilov wrote: > If regmap_read() failed, arizona_micdet() returns IRQ_NONE > leaving >lock mutex locked as opposed to all other return paths. > > Found by Linux Driver Verification project (linuxtesting.org). Acked-by: Mark Brown signature.asc Description: Digital signature
Re: [PATCH] extcon: arizona: unlock mutex on error path in arizona_micdet()
On Sun, Nov 04, 2012 at 01:19:46PM -0700, Alexey Khoroshilov wrote: If regmap_read() failed, arizona_micdet() returns IRQ_NONE leaving info-lock mutex locked as opposed to all other return paths. Found by Linux Driver Verification project (linuxtesting.org). Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature
Re: [PATCH] extcon: arizona: unlock mutex on error path in arizona_micdet()
On 11/05/2012 05:04 PM, Mark Brown wrote: On Sun, Nov 04, 2012 at 01:19:46PM -0700, Alexey Khoroshilov wrote: If regmap_read() failed, arizona_micdet() returns IRQ_NONE leaving info-lock mutex locked as opposed to all other return paths. Found by Linux Driver Verification project (linuxtesting.org). Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Applied, thanks. You can check this patch on extcon git tree: - git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git (for-next branch) Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] extcon: arizona: unlock mutex on error path in arizona_micdet()
If regmap_read() failed, arizona_micdet() returns IRQ_NONE
leaving >lock mutex locked as opposed to all other return paths.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
---
drivers/extcon/extcon-arizona.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index cdab9e5..d876a54 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -166,6 +166,7 @@ static irqreturn_t arizona_micdet(int irq, void *data)
ret = regmap_read(arizona->regmap, ARIZONA_MIC_DETECT_3, );
if (ret != 0) {
dev_err(arizona->dev, "Failed to read MICDET: %d\n", ret);
+ mutex_unlock(>lock);
return IRQ_NONE;
}
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] extcon: arizona: unlock mutex on error path in arizona_micdet()
If regmap_read() failed, arizona_micdet() returns IRQ_NONE
leaving info-lock mutex locked as opposed to all other return paths.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru
---
drivers/extcon/extcon-arizona.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index cdab9e5..d876a54 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -166,6 +166,7 @@ static irqreturn_t arizona_micdet(int irq, void *data)
ret = regmap_read(arizona-regmap, ARIZONA_MIC_DETECT_3, val);
if (ret != 0) {
dev_err(arizona-dev, Failed to read MICDET: %d\n, ret);
+ mutex_unlock(info-lock);
return IRQ_NONE;
}
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
