Re: [f2fs-dev] [PATCH] f2fs: handle unallocated section and zone on pinned/atgc

2020-12-23 Thread Chao Yu 

On 2020/12/24 4:02, Jaegeuk Kim wrote:

If we have large section/zone, unallocated segment makes them corrupted.

E.g.,

   - Pinned file:   -1 119304647 119304647
   - ATGC   data:   -1 119304647 119304647

Signed-off-by: Jaegeuk Kim 


Reviewed-by: Chao Yu 

Thanks,

[PATCH] f2fs: handle unallocated section and zone on pinned/atgc

2020-12-23 Thread Jaegeuk Kim 
If we have large section/zone, unallocated segment makes them corrupted.

E.g.,

  - Pinned file:   -1 119304647 119304647
  - ATGC   data:   -1 119304647 119304647

Signed-off-by: Jaegeuk Kim 
---
 fs/f2fs/segment.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index e81eb0748e2a..229814b4f4a6 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -101,11 +101,11 @@ static inline void sanity_check_seg_type(struct 
f2fs_sb_info *sbi,
 #define BLKS_PER_SEC(sbi)  \
((sbi)->segs_per_sec * (sbi)->blocks_per_seg)
 #define GET_SEC_FROM_SEG(sbi, segno)   \
-   ((segno) / (sbi)->segs_per_sec)
+   (((segno) == -1) ? -1: (segno) / (sbi)->segs_per_sec)
 #define GET_SEG_FROM_SEC(sbi, secno)   \
((secno) * (sbi)->segs_per_sec)
 #define GET_ZONE_FROM_SEC(sbi, secno)  \
-   ((secno) / (sbi)->secs_per_zone)
+   (((secno) == -1) ? -1: (secno) / (sbi)->secs_per_zone)
 #define GET_ZONE_FROM_SEG(sbi, segno)  \
GET_ZONE_FROM_SEC(sbi, GET_SEC_FROM_SEG(sbi, segno))
 
-- 
2.29.2.729.g45daf8777d-goog