Re: [PATCH] firmware_loader: Remove unnecessary conversion to bool

[Shuah Khan]

On 2/18/21 2:12 AM, Jiapeng Chong wrote:

Fix the following coccicheck warnings:

./tools/testing/selftests/firmware/fw_namespace.c:98:54-59: WARNING:
conversion to bool not needed here.

Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 
---
  tools/testing/selftests/firmware/fw_namespace.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/firmware/fw_namespace.c 
b/tools/testing/selftests/firmware/fw_namespace.c
index 5ebc1ae..0e393cb 100644
--- a/tools/testing/selftests/firmware/fw_namespace.c
+++ b/tools/testing/selftests/firmware/fw_namespace.c
@@ -95,7 +95,7 @@ static bool test_fw_in_ns(const char *fw_name, const char 
*sys_path, bool block_
}
if (block_fw_in_parent_ns)
umount("/lib/firmware");
-   return WEXITSTATUS(status) == EXIT_SUCCESS ? true : false;


This looks right to me. test_fw_in_ns() returns true or false and
test_fw_in_ns() callers print appropriate message.

I don't think this patch is necessary.

thanks,
-- Shuah

[PATCH] firmware_loader: Remove unnecessary conversion to bool

[Jiapeng Chong]

Fix the following coccicheck warnings:

./tools/testing/selftests/firmware/fw_namespace.c:98:54-59: WARNING:
conversion to bool not needed here.

Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 
---
 tools/testing/selftests/firmware/fw_namespace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/firmware/fw_namespace.c 
b/tools/testing/selftests/firmware/fw_namespace.c
index 5ebc1ae..0e393cb 100644
--- a/tools/testing/selftests/firmware/fw_namespace.c
+++ b/tools/testing/selftests/firmware/fw_namespace.c
@@ -95,7 +95,7 @@ static bool test_fw_in_ns(const char *fw_name, const char 
*sys_path, bool block_
}
if (block_fw_in_parent_ns)
umount("/lib/firmware");
-   return WEXITSTATUS(status) == EXIT_SUCCESS ? true : false;
+   return WEXITSTATUS(status) == EXIT_SUCCESS;
}
 
if (unshare(CLONE_NEWNS) != 0) {
-- 
1.8.3.1