Re: [PATCH] fs/kernfs: remove the double check of dentry->inode

[Tejun Heo]

On Fri, Nov 13, 2020 at 09:21:43PM +0800, Hui Su wrote:
> In both kernfs_node_from_dentry() and in
> kernfs_dentry_node(), we will check the dentry->inode
> is NULL or not, which is superfluous.
> 
> So remove the check in kernfs_node_from_dentry().
> 
> Signed-off-by: Hui Su 

Acked-by: Tejun Heo 

Thanks.

-- 
tejun

[PATCH] fs/kernfs: remove the double check of dentry->inode

[Hui Su]

In both kernfs_node_from_dentry() and in
kernfs_dentry_node(), we will check the dentry->inode
is NULL or not, which is superfluous.

So remove the check in kernfs_node_from_dentry().

Signed-off-by: Hui Su 
---
 fs/kernfs/dir.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
index 9aec80b9d7c6..b062c666df05 100644
--- a/fs/kernfs/dir.c
+++ b/fs/kernfs/dir.c
@@ -604,8 +604,7 @@ const struct dentry_operations kernfs_dops = {
  */
 struct kernfs_node *kernfs_node_from_dentry(struct dentry *dentry)
 {
-   if (dentry->d_sb->s_op == _sops &&
-   !d_really_is_negative(dentry))
+   if (dentry->d_sb->s_op == _sops)
return kernfs_dentry_node(dentry);
return NULL;
 }
-- 
2.29.0