Re: [PATCH] fs:ext4:hash.c: reduce one "if" comparison

2013-02-01 Thread Theodore Ts'o 
On Sat, Dec 01, 2012 at 11:33:41PM +, Cong Ding wrote:
> it is unnecessary to check i<4 after the loop. just do it before the break.
> 
> Signed-off-by: Cong Ding 

Thanks, applied.

- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] fs:ext4:hash.c: reduce one if comparison

2013-02-01 Thread Theodore Ts'o 
On Sat, Dec 01, 2012 at 11:33:41PM +, Cong Ding wrote:
 it is unnecessary to check i4 after the loop. just do it before the break.
 
 Signed-off-by: Cong Ding ding...@gmail.com

Thanks, applied.

- Ted
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] fs:ext4:hash.c: reduce one "if" comparison

2012-12-01 Thread Cong Ding 
it is unnecessary to check i<4 after the loop. just do it before the break.

Signed-off-by: Cong Ding 
---
 fs/ext4/hash.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/hash.c b/fs/ext4/hash.c
index fa8e491..3d586f0 100644
--- a/fs/ext4/hash.c
+++ b/fs/ext4/hash.c
@@ -155,11 +155,11 @@ int ext4fs_dirhash(const char *name, int len, struct 
dx_hash_info *hinfo)
/* Check to see if the seed is all zero's */
if (hinfo->seed) {
for (i = 0; i < 4; i++) {
-   if (hinfo->seed[i])
+   if (hinfo->seed[i]) {
+   memcpy(buf, hinfo->seed, sizeof(buf));
break;
+   }
}
-   if (i < 4)
-   memcpy(buf, hinfo->seed, sizeof(buf));
}
 
switch (hinfo->hash_version) {
-- 
1.7.4.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] fs:ext4:hash.c: reduce one if comparison

2012-12-01 Thread Cong Ding 
it is unnecessary to check i4 after the loop. just do it before the break.

Signed-off-by: Cong Ding ding...@gmail.com
---
 fs/ext4/hash.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/hash.c b/fs/ext4/hash.c
index fa8e491..3d586f0 100644
--- a/fs/ext4/hash.c
+++ b/fs/ext4/hash.c
@@ -155,11 +155,11 @@ int ext4fs_dirhash(const char *name, int len, struct 
dx_hash_info *hinfo)
/* Check to see if the seed is all zero's */
if (hinfo-seed) {
for (i = 0; i  4; i++) {
-   if (hinfo-seed[i])
+   if (hinfo-seed[i]) {
+   memcpy(buf, hinfo-seed, sizeof(buf));
break;
+   }
}
-   if (i  4)
-   memcpy(buf, hinfo-seed, sizeof(buf));
}
 
switch (hinfo-hash_version) {
-- 
1.7.4.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/