Re: [PATCH] gpio: fix memory leak in error path

2013-11-19 Thread Linus Walleij 
On Wed, Nov 13, 2013 at 9:20 PM, Michal Nazarewicz  wrote:

> From: Michal Nazarewicz 
>
> Signed-off-by: Michal Nazarewicz 

Good catch!

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] gpio: fix memory leak in error path

2013-11-19 Thread Linus Walleij 
On Wed, Nov 13, 2013 at 9:20 PM, Michal Nazarewicz m...@google.com wrote:

 From: Michal Nazarewicz min...@mina86.com

 Signed-off-by: Michal Nazarewicz min...@mina86.com

Good catch!

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] gpio: fix memory leak in error path

2013-11-13 Thread Michal Nazarewicz 
From: Michal Nazarewicz 

Signed-off-by: Michal Nazarewicz 
---
 drivers/gpio/gpiolib.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 4e10b10..068011c 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1341,8 +1341,10 @@ int gpiochip_add_pingroup_range(struct gpio_chip *chip,
ret = pinctrl_get_group_pins(pctldev, pin_group,
_range->range.pins,
_range->range.npins);
-   if (ret < 0)
+   if (ret < 0) {
+   kfree(pin_range);
return ret;
+   }
 
pinctrl_add_gpio_range(pctldev, _range->range);
 
-- 
1.8.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] gpio: fix memory leak in error path

2013-11-13 Thread Michal Nazarewicz 
From: Michal Nazarewicz min...@mina86.com

Signed-off-by: Michal Nazarewicz min...@mina86.com
---
 drivers/gpio/gpiolib.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 4e10b10..068011c 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1341,8 +1341,10 @@ int gpiochip_add_pingroup_range(struct gpio_chip *chip,
ret = pinctrl_get_group_pins(pctldev, pin_group,
pin_range-range.pins,
pin_range-range.npins);
-   if (ret  0)
+   if (ret  0) {
+   kfree(pin_range);
return ret;
+   }
 
pinctrl_add_gpio_range(pctldev, pin_range-range);
 
-- 
1.8.4.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/