Re: [PATCH] gpiolib: add missing declarations
On 11/25/2013 06:28 PM, Mika Westerberg wrote: On Mon, Nov 25, 2013 at 06:07:10PM +0900, Alexandre Courbot wrote: On Mon, Nov 25, 2013 at 5:58 PM, Mika Westerberg wrote: On Sat, Nov 23, 2013 at 02:54:29PM +0900, Alexandre Courbot wrote: Add missing declarations and include files to avoid warnings during compilation of include/gpio/driver.h. It would be good to have those warnings included in the changelog as well. As in, copy-pasting the compiler's output? Isn't the change explicit enough? If you just do 'git log' you can't see the change itself and that's where the changelog should help. If I see some warnings when I build the kernel, the first thing I usually do is to check 'git log' against linux-next and see if someone has already fixed that warning (grepping the warning message from changelog). Ah, I can see several examples of what you mention indeed. Will add these and send a v2. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpiolib: add missing declarations
On Mon, Nov 25, 2013 at 06:07:10PM +0900, Alexandre Courbot wrote: > On Mon, Nov 25, 2013 at 5:58 PM, Mika Westerberg > wrote: > > On Sat, Nov 23, 2013 at 02:54:29PM +0900, Alexandre Courbot wrote: > >> Add missing declarations and include files to avoid warnings during > >> compilation of include/gpio/driver.h. > > > > It would be good to have those warnings included in the changelog as well. > > As in, copy-pasting the compiler's output? Isn't the change explicit enough? If you just do 'git log' you can't see the change itself and that's where the changelog should help. If I see some warnings when I build the kernel, the first thing I usually do is to check 'git log' against linux-next and see if someone has already fixed that warning (grepping the warning message from changelog). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpiolib: add missing declarations
On Mon, Nov 25, 2013 at 5:58 PM, Mika Westerberg wrote: > On Sat, Nov 23, 2013 at 02:54:29PM +0900, Alexandre Courbot wrote: >> Add missing declarations and include files to avoid warnings during >> compilation of include/gpio/driver.h. > > It would be good to have those warnings included in the changelog as well. As in, copy-pasting the compiler's output? Isn't the change explicit enough? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpiolib: add missing declarations
On Sat, Nov 23, 2013 at 02:54:29PM +0900, Alexandre Courbot wrote: > Add missing declarations and include files to avoid warnings during > compilation of include/gpio/driver.h. It would be good to have those warnings included in the changelog as well. > > Signed-off-by: Alexandre Courbot > Reported-by: Stephen Warren Reviewed-by: Mika Westerberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] gpiolib: add missing declarations
Add missing declarations and include files to avoid warnings during compilation of include/gpio/driver.h. Signed-off-by: Alexandre Courbot Reported-by: Stephen Warren --- include/linux/gpio/driver.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h index 82eac61..3ea2cf6 100644 --- a/include/linux/gpio/driver.h +++ b/include/linux/gpio/driver.h @@ -2,9 +2,12 @@ #define __LINUX_GPIO_DRIVER_H #include +#include struct device; struct gpio_desc; +struct of_phandle_args; +struct device_node; struct seq_file; /** -- 1.8.4.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
