Re: [PATCH] habanalabs/gaudi: use correct define for qman init
On Tue, Sep 29, 2020 at 11:58:22PM +0300, Oded Gabbay wrote: > On Fri, Sep 25, 2020 at 8:14 PM Oded Gabbay wrote: > > > > There was a copy-paste error, and the wrong define was used for > > initializing the QMAN. > > > > Signed-off-by: Oded Gabbay > > --- > > drivers/misc/habanalabs/gaudi/gaudi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c > > b/drivers/misc/habanalabs/gaudi/gaudi.c > > index a227806be328..5f65a1691551 100644 > > --- a/drivers/misc/habanalabs/gaudi/gaudi.c > > +++ b/drivers/misc/habanalabs/gaudi/gaudi.c > > @@ -2039,7 +2039,7 @@ static void gaudi_init_hbm_dma_qman(struct hl_device > > *hdev, int dma_id, > > WREG32(mmDMA0_QM_CP_LDMA_SRC_BASE_LO_OFFSET_0 + q_off, > > > > QMAN_LDMA_SRC_OFFSET); > > WREG32(mmDMA0_QM_CP_LDMA_DST_BASE_LO_OFFSET_0 + q_off, > > - > > QMAN_LDMA_SIZE_OFFSET); > > + > > QMAN_LDMA_DST_OFFSET); > > > > /* Configure RAZWI IRQ */ > > dma_qm_err_cfg = HBM_DMA_QMAN_GLBL_ERR_CFG_MSG_EN_MASK; > > -- > > 2.17.1 > > > > Hi Greg, > Do you think you can apply this patch directly to your char-misc-next > branch before the merge window opens ? > I don't have anything pending and I don't want to send a pull request > for a single patch. Sure, I'll be glad to queue it up now. thanks, greg k-h
Re: [PATCH] habanalabs/gaudi: use correct define for qman init
On Fri, Sep 25, 2020 at 8:14 PM Oded Gabbay wrote: > > There was a copy-paste error, and the wrong define was used for > initializing the QMAN. > > Signed-off-by: Oded Gabbay > --- > drivers/misc/habanalabs/gaudi/gaudi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c > b/drivers/misc/habanalabs/gaudi/gaudi.c > index a227806be328..5f65a1691551 100644 > --- a/drivers/misc/habanalabs/gaudi/gaudi.c > +++ b/drivers/misc/habanalabs/gaudi/gaudi.c > @@ -2039,7 +2039,7 @@ static void gaudi_init_hbm_dma_qman(struct hl_device > *hdev, int dma_id, > WREG32(mmDMA0_QM_CP_LDMA_SRC_BASE_LO_OFFSET_0 + q_off, > QMAN_LDMA_SRC_OFFSET); > WREG32(mmDMA0_QM_CP_LDMA_DST_BASE_LO_OFFSET_0 + q_off, > - > QMAN_LDMA_SIZE_OFFSET); > + QMAN_LDMA_DST_OFFSET); > > /* Configure RAZWI IRQ */ > dma_qm_err_cfg = HBM_DMA_QMAN_GLBL_ERR_CFG_MSG_EN_MASK; > -- > 2.17.1 > Hi Greg, Do you think you can apply this patch directly to your char-misc-next branch before the merge window opens ? I don't have anything pending and I don't want to send a pull request for a single patch. Thanks, Oded
[PATCH] habanalabs/gaudi: use correct define for qman init
There was a copy-paste error, and the wrong define was used for initializing the QMAN. Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi/gaudi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c index a227806be328..5f65a1691551 100644 --- a/drivers/misc/habanalabs/gaudi/gaudi.c +++ b/drivers/misc/habanalabs/gaudi/gaudi.c @@ -2039,7 +2039,7 @@ static void gaudi_init_hbm_dma_qman(struct hl_device *hdev, int dma_id, WREG32(mmDMA0_QM_CP_LDMA_SRC_BASE_LO_OFFSET_0 + q_off, QMAN_LDMA_SRC_OFFSET); WREG32(mmDMA0_QM_CP_LDMA_DST_BASE_LO_OFFSET_0 + q_off, - QMAN_LDMA_SIZE_OFFSET); + QMAN_LDMA_DST_OFFSET); /* Configure RAZWI IRQ */ dma_qm_err_cfg = HBM_DMA_QMAN_GLBL_ERR_CFG_MSG_EN_MASK; -- 2.17.1