Re: [PATCH] habanalabs: fix up absolute include instructions
On Wed, Jul 29, 2020 at 08:09:38AM +1000, Stephen Rothwell wrote: > Hi Greg, > > On Tue, 28 Jul 2020 19:18:51 +0200 Greg Kroah-Hartman > wrote: > > > > diff --git a/drivers/misc/habanalabs/common/Makefile > > b/drivers/misc/habanalabs/common/Makefile > > index 97d03b5c8683..b984bfa4face 100644 > > --- a/drivers/misc/habanalabs/common/Makefile > > +++ b/drivers/misc/habanalabs/common/Makefile > > @@ -1,6 +1,4 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > -subdir-ccflags-y += -I$(src)/common > > I've seen oter places use > > subdir-ccflags-y += -I$(srcdir)/$(src)/common > > which would probably work as well. i.e. just change this in the > Makefiles rather than every source file. I hate seeing odd ccflags stuff in Makefiles as it can catch you "by surprise" as to what exactly is happening when looking at .c code. But yes, your change would also work. thanks, greg k-h
Re: [PATCH] habanalabs: fix up absolute include instructions
Hi Greg, I love your patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [cannot apply to linux/master linus/master v5.8-rc7 next-20200728] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Greg-Kroah-Hartman/habanalabs-fix-up-absolute-include-instructions/20200729-012043 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 65a9bde6ed484880987a6d88de6e372eca52059f config: i386-randconfig-s001-20200728 (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-94-geb6779f6-dirty # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) drivers/misc/habanalabs/goya/goya.c:2778:17: sparse: sparse: cast removes address space '__iomem' of expression >> drivers/misc/habanalabs/goya/goya.c:5228:5: sparse: sparse: symbol >> 'goya_ctx_init' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:885:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000) drivers/misc/habanalabs/goya/goya.c:887:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000) drivers/misc/habanalabs/goya/goya.c:891:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040) drivers/misc/habanalabs/goya/goya.c:934:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040) drivers/misc/habanalabs/goya/goya.c:1143:9: sparse: sparse: cast truncates bits from constant value (80 becomes 0) drivers/misc/habanalabs/goya/goya.c:1618:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000) drivers/misc/habanalabs/goya/goya.c:1620:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000) drivers/misc/habanalabs/goya/goya.c:1624:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040) drivers/misc/habanalabs/goya/goya.c:1667:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000) drivers/misc/habanalabs/goya/goya.c:1669:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000) drivers/misc/habanalabs/goya/goya.c:1673:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040) drivers/misc/habanalabs/goya/goya.c:1705:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000) drivers/misc/habanalabs/goya/goya.c:1725:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000) drivers/misc/habanalabs/goya/goya.c:1727:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000) drivers/misc/habanalabs/goya/goya.c:1731:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040) drivers/misc/habanalabs/goya/goya.c:1774:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000) drivers/misc/habanalabs/goya/goya.c:1776:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000) drivers/misc/habanalabs/goya/goya.c:1780:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040) drivers/misc/habanalabs/goya/goya.c:1815:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000) drivers/misc/habanalabs/goya/goya.c:2339:27: sparse: sparse: cast truncates bits from constant value (7ff000 becomes f000) drivers/misc/habanalabs/goya/goya.c:3422:26: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000) drivers/misc/habanalabs/goya/goya.c:3423:24: sparse: sparse: cast truncates bits from constant value (7ffc112ffc becomes fc112ffc) -- >> drivers/misc/habanalabs/gaudi/gaudi.c:6275:5: sparse: sparse: symbol >> 'gaudi_ctx_init' was not declared. Should it be static? drivers/misc/habanalabs/gaudi/gaudi.c:1807:26: sparse: sparse: cast truncates bits from constant value (7ffc4f4000 becomes fc4f4000) drivers/misc/habanalabs/gaudi/gaudi.c:1811:25: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000) drivers/misc/habanalabs/gaudi/gaudi.c:1815:26: sparse: sparse: cast truncates bits from constant value (7ffc494000 becomes fc494000) drivers/misc/habanalabs/gaudi/gaudi.c:1819:25: sparse: sparse: cast truncates bits from constant value (7ffc492000 becomes fc492000)
Re: [PATCH] habanalabs: fix up absolute include instructions
Hi Greg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[cannot apply to linux/master linus/master v5.8-rc7 next-20200728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Greg-Kroah-Hartman/habanalabs-fix-up-absolute-include-instructions/20200729-012043
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
65a9bde6ed484880987a6d88de6e372eca52059f
config: x86_64-randconfig-m001-20200728 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> drivers/misc/habanalabs/goya/goya.c:5228:5: warning: no previous prototype
>> for 'goya_ctx_init' [-Wmissing-prototypes]
5228 | int goya_ctx_init(struct hl_ctx *ctx)
| ^
--
>> drivers/misc/habanalabs/gaudi/gaudi.c:6275:5: warning: no previous prototype
>> for 'gaudi_ctx_init' [-Wmissing-prototypes]
6275 | int gaudi_ctx_init(struct hl_ctx *ctx)
| ^~
vim +/goya_ctx_init +5228 drivers/misc/habanalabs/goya/goya.c
f8c8c7d5f1b0ea Oded Gabbay 2019-02-16 5227
a04b7cd97eef13 Ofir Bitton 2020-07-13 @5228 int goya_ctx_init(struct hl_ctx
*ctx)
a04b7cd97eef13 Ofir Bitton 2020-07-13 5229 {
a04b7cd97eef13 Ofir Bitton 2020-07-13 5230 return 0;
a04b7cd97eef13 Ofir Bitton 2020-07-13 5231 }
a04b7cd97eef13 Ofir Bitton 2020-07-13 5232
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
Re: [PATCH] habanalabs: fix up absolute include instructions
Hi Greg, On Tue, 28 Jul 2020 19:18:51 +0200 Greg Kroah-Hartman wrote: > > diff --git a/drivers/misc/habanalabs/common/Makefile > b/drivers/misc/habanalabs/common/Makefile > index 97d03b5c8683..b984bfa4face 100644 > --- a/drivers/misc/habanalabs/common/Makefile > +++ b/drivers/misc/habanalabs/common/Makefile > @@ -1,6 +1,4 @@ > # SPDX-License-Identifier: GPL-2.0-only > -subdir-ccflags-y += -I$(src)/common I've seen oter places use subdir-ccflags-y += -I$(srcdir)/$(src)/common which would probably work as well. i.e. just change this in the Makefiles rather than every source file. -- Cheers, Stephen Rothwell pgpo0alOyaOcs.pgp Description: OpenPGP digital signature
[PATCH] habanalabs: fix up absolute include instructions
There's no need to try to be cute with the include file locations in the Makefile, so just specify exactly where the files are. Bonus is this fixes the problem of building with O= as well as trying to just build the subdirectory alone. Reported-by: Stephen Rothwell Cc: Oded Gabbay Cc: Omer Shpigelman Cc: Tomer Tayar Cc: Moti Haimovski Cc: Ofir Bitton Cc: Ben Segal Cc: Christine Gharzuzi Cc: Pawel Piskorski Signed-off-by: Greg Kroah-Hartman --- drivers/misc/habanalabs/common/Makefile | 2 -- drivers/misc/habanalabs/common/debugfs.c| 2 +- drivers/misc/habanalabs/common/firmware_if.c| 2 +- drivers/misc/habanalabs/common/habanalabs.h | 4 ++-- drivers/misc/habanalabs/common/memory.c | 2 +- drivers/misc/habanalabs/common/mmu.c| 2 +- drivers/misc/habanalabs/common/pci.c| 2 +- drivers/misc/habanalabs/gaudi/Makefile | 2 -- drivers/misc/habanalabs/gaudi/gaudi.c | 12 ++-- drivers/misc/habanalabs/gaudi/gaudiP.h | 10 +- drivers/misc/habanalabs/gaudi/gaudi_coresight.c | 6 +++--- drivers/misc/habanalabs/gaudi/gaudi_hwmgr.c | 2 +- drivers/misc/habanalabs/gaudi/gaudi_security.c | 2 +- drivers/misc/habanalabs/goya/Makefile | 2 -- drivers/misc/habanalabs/goya/goya.c | 8 drivers/misc/habanalabs/goya/goyaP.h| 12 ++-- drivers/misc/habanalabs/goya/goya_coresight.c | 6 +++--- drivers/misc/habanalabs/goya/goya_security.c| 2 +- 18 files changed, 37 insertions(+), 43 deletions(-) diff --git a/drivers/misc/habanalabs/common/Makefile b/drivers/misc/habanalabs/common/Makefile index 97d03b5c8683..b984bfa4face 100644 --- a/drivers/misc/habanalabs/common/Makefile +++ b/drivers/misc/habanalabs/common/Makefile @@ -1,6 +1,4 @@ # SPDX-License-Identifier: GPL-2.0-only -subdir-ccflags-y += -I$(src)/common - HL_COMMON_FILES := common/habanalabs_drv.o common/device.o common/context.o \ common/asid.o common/habanalabs_ioctl.o \ common/command_buffer.o common/hw_queue.o common/irq.o \ diff --git a/drivers/misc/habanalabs/common/debugfs.c b/drivers/misc/habanalabs/common/debugfs.c index 0bc036e01ee8..c50c6fc9e905 100644 --- a/drivers/misc/habanalabs/common/debugfs.c +++ b/drivers/misc/habanalabs/common/debugfs.c @@ -6,7 +6,7 @@ */ #include "habanalabs.h" -#include "include/hw_ip/mmu/mmu_general.h" +#include "../include/hw_ip/mmu/mmu_general.h" #include #include diff --git a/drivers/misc/habanalabs/common/firmware_if.c b/drivers/misc/habanalabs/common/firmware_if.c index 5981dbd8c6df..f70302cdab1b 100644 --- a/drivers/misc/habanalabs/common/firmware_if.c +++ b/drivers/misc/habanalabs/common/firmware_if.c @@ -6,7 +6,7 @@ */ #include "habanalabs.h" -#include "include/common/hl_boot_if.h" +#include "../include/common/hl_boot_if.h" #include #include diff --git a/drivers/misc/habanalabs/common/habanalabs.h b/drivers/misc/habanalabs/common/habanalabs.h index eb42aa5476a9..018d9d67e8e6 100644 --- a/drivers/misc/habanalabs/common/habanalabs.h +++ b/drivers/misc/habanalabs/common/habanalabs.h @@ -8,8 +8,8 @@ #ifndef HABANALABSP_H_ #define HABANALABSP_H_ -#include "include/common/armcp_if.h" -#include "include/common/qman_if.h" +#include "../include/common/armcp_if.h" +#include "../include/common/qman_if.h" #include #include diff --git a/drivers/misc/habanalabs/common/memory.c b/drivers/misc/habanalabs/common/memory.c index e4e1693e5c6c..dce9273e557a 100644 --- a/drivers/misc/habanalabs/common/memory.c +++ b/drivers/misc/habanalabs/common/memory.c @@ -7,7 +7,7 @@ #include #include "habanalabs.h" -#include "include/hw_ip/mmu/mmu_general.h" +#include "../include/hw_ip/mmu/mmu_general.h" #include #include diff --git a/drivers/misc/habanalabs/common/mmu.c b/drivers/misc/habanalabs/common/mmu.c index 04303950e630..edcc11d5eaf1 100644 --- a/drivers/misc/habanalabs/common/mmu.c +++ b/drivers/misc/habanalabs/common/mmu.c @@ -6,7 +6,7 @@ */ #include "habanalabs.h" -#include "include/hw_ip/mmu/mmu_general.h" +#include "../include/hw_ip/mmu/mmu_general.h" #include #include diff --git a/drivers/misc/habanalabs/common/pci.c b/drivers/misc/habanalabs/common/pci.c index 1791f6623c69..7bd3737571f3 100644 --- a/drivers/misc/habanalabs/common/pci.c +++ b/drivers/misc/habanalabs/common/pci.c @@ -6,7 +6,7 @@ */ #include "habanalabs.h" -#include "include/hw_ip/pci/pci_general.h" +#include "../include/hw_ip/pci/pci_general.h" #include #include diff --git a/drivers/misc/habanalabs/gaudi/Makefile b/drivers/misc/habanalabs/gaudi/Makefile index 75104ae74e2b..c9f4703cff24 100644 --- a/drivers/misc/habanalabs/gaudi/Makefile +++ b/drivers/misc/habanalabs/gaudi/Makefile @@ -1,5 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only -subdir-ccflags-y += -I$(src)/common - HL_GAUDI_FILES := gaudi/gaudi.o gaudi/gaudi_hwmgr.o gaudi/gaudi_security.o \ gaudi/gaudi_coresight.o diff
