Re: [PATCH] hostap: remove set but not used variable 'copied' in prism2_io_debug_proc_read
zhong jiang wrote: > Obviously, variable 'copied' is initialized to zero. But it is not used. > hence just remove it. > > Signed-off-by: zhong jiang Patch applied to wireless-drivers-next.git, thanks. 64827a6ac049 hostap: remove set but not used variable 'copied' in prism2_io_debug_proc_read -- https://patchwork.kernel.org/patch/11127357/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH] hostap: remove set but not used variable 'copied' in prism2_io_debug_proc_read
zhong jiang writes: > On 2019/9/5 21:45, Kalle Valo wrote: >> zhong jiang writes: >> >>> Please ignore the patch. Because the hostap_proc.c is marked as >>> 'obsolete'. >> You mean marked in the MAINTAINERS file? I don't see that as a problem, >> I can (and should) still apply any patches submitted to hostap driver. >> > I hit the following issue when checking the patch by checkpatch.pl > > WARNING: drivers/net/wireless/intersil/hostap/hostap_proc.c is marked > as 'obsolete' in the MAINTAINERS hierarchy. > No unnecessary modifications please. > > I certainly hope it can be appiled to upstream if the above check doesn't > matter. I have no idea why checkpatch says like that and I'm going to just ignore that warning. As long as the driver is in the tree I think it should be improved. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH] hostap: remove set but not used variable 'copied' in prism2_io_debug_proc_read
On 2019/9/5 21:45, Kalle Valo wrote: > zhong jiang writes: > >> Please ignore the patch. Because the hostap_proc.c is marked as 'obsolete'. > You mean marked in the MAINTAINERS file? I don't see that as a problem, > I can (and should) still apply any patches submitted to hostap driver. > I hit the following issue when checking the patch by checkpatch.pl WARNING: drivers/net/wireless/intersil/hostap/hostap_proc.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please. I certainly hope it can be appiled to upstream if the above check doesn't matter. Thanks, zhong jiang
Re: [PATCH] hostap: remove set but not used variable 'copied' in prism2_io_debug_proc_read
zhong jiang writes: > Please ignore the patch. Because the hostap_proc.c is marked as 'obsolete'. You mean marked in the MAINTAINERS file? I don't see that as a problem, I can (and should) still apply any patches submitted to hostap driver. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH] hostap: remove set but not used variable 'copied' in prism2_io_debug_proc_read
Please ignore the patch. Because the hostap_proc.c is marked as 'obsolete'.
Thanks,
zhong jiang
On 2019/9/3 15:57, zhong jiang wrote:
> Obviously, variable 'copied' is initialized to zero. But it is not used.
> hence just remove it.
>
> Signed-off-by: zhong jiang
> ---
> drivers/net/wireless/intersil/hostap/hostap_proc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/intersil/hostap/hostap_proc.c
> b/drivers/net/wireless/intersil/hostap/hostap_proc.c
> index 703d74c..6151d8d 100644
> --- a/drivers/net/wireless/intersil/hostap/hostap_proc.c
> +++ b/drivers/net/wireless/intersil/hostap/hostap_proc.c
> @@ -234,7 +234,7 @@ static int prism2_io_debug_proc_read(char *page, char
> **start, off_t off,
> {
> local_info_t *local = (local_info_t *) data;
> int head = local->io_debug_head;
> - int start_bytes, left, copy, copied;
> + int start_bytes, left, copy;
>
> if (off + count > PRISM2_IO_DEBUG_SIZE * 4) {
> *eof = 1;
> @@ -243,7 +243,6 @@ static int prism2_io_debug_proc_read(char *page, char
> **start, off_t off,
> count = PRISM2_IO_DEBUG_SIZE * 4 - off;
> }
>
> - copied = 0;
> start_bytes = (PRISM2_IO_DEBUG_SIZE - head) * 4;
> left = count;
>
[PATCH] hostap: remove set but not used variable 'copied' in prism2_io_debug_proc_read
Obviously, variable 'copied' is initialized to zero. But it is not used.
hence just remove it.
Signed-off-by: zhong jiang
---
drivers/net/wireless/intersil/hostap/hostap_proc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intersil/hostap/hostap_proc.c
b/drivers/net/wireless/intersil/hostap/hostap_proc.c
index 703d74c..6151d8d 100644
--- a/drivers/net/wireless/intersil/hostap/hostap_proc.c
+++ b/drivers/net/wireless/intersil/hostap/hostap_proc.c
@@ -234,7 +234,7 @@ static int prism2_io_debug_proc_read(char *page, char
**start, off_t off,
{
local_info_t *local = (local_info_t *) data;
int head = local->io_debug_head;
- int start_bytes, left, copy, copied;
+ int start_bytes, left, copy;
if (off + count > PRISM2_IO_DEBUG_SIZE * 4) {
*eof = 1;
@@ -243,7 +243,6 @@ static int prism2_io_debug_proc_read(char *page, char
**start, off_t off,
count = PRISM2_IO_DEBUG_SIZE * 4 - off;
}
- copied = 0;
start_bytes = (PRISM2_IO_DEBUG_SIZE - head) * 4;
left = count;
--
1.7.12.4
