Re: [PATCH] i2c: print correct device invalid address

[Wolfram Sang]

On Fri, Jan 06, 2017 at 07:02:57PM +0800, John Garry wrote:
> In of_i2c_register_device(), when the check for
> device address validity fails we print the info.addr,
> which has not been assigned properly.
> 
> Fix this by printing the actual invalid address.
> 
> Signed-off-by: John Garry 

Applied to for-current, thanks!

Re: [PATCH] i2c: print correct device invalid address

[Wolfram Sang]

On Fri, Jan 06, 2017 at 07:02:57PM +0800, John Garry wrote:
> In of_i2c_register_device(), when the check for
> device address validity fails we print the info.addr,
> which has not been assigned properly.
> 
> Fix this by printing the actual invalid address.
> 
> Signed-off-by: John Garry 

Applied to for-current, thanks!

Re: [PATCH] i2c: print correct device invalid address

[Vladimir Zapolskiy]

On 01/06/2017 01:02 PM, John Garry wrote:
> In of_i2c_register_device(), when the check for
> device address validity fails we print the info.addr,
> which has not been assigned properly.
> 
> Fix this by printing the actual invalid address.
> 
> Signed-off-by: John Garry 
> 
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> index cf9e396..03cfcdd 100644
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -1708,7 +1708,7 @@ static struct i2c_client *of_i2c_register_device(struct 
> i2c_adapter *adap,
>  
>   if (i2c_check_addr_validity(addr, info.flags)) {
>   dev_err(>dev, "of_i2c: invalid addr=%x on %s\n",
> - info.addr, node->full_name);
> + addr, node->full_name);
>   return ERR_PTR(-EINVAL);
>   }
>  
> 

Reviewed-by: Vladimir Zapolskiy 
Fixes: b4e2f6ac1281 ("i2c: apply DT flags when probing")

Thank you for the fix.

--
With best wishes,
Vladimir

Re: [PATCH] i2c: print correct device invalid address

[Vladimir Zapolskiy]

On 01/06/2017 01:02 PM, John Garry wrote:
> In of_i2c_register_device(), when the check for
> device address validity fails we print the info.addr,
> which has not been assigned properly.
> 
> Fix this by printing the actual invalid address.
> 
> Signed-off-by: John Garry 
> 
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> index cf9e396..03cfcdd 100644
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -1708,7 +1708,7 @@ static struct i2c_client *of_i2c_register_device(struct 
> i2c_adapter *adap,
>  
>   if (i2c_check_addr_validity(addr, info.flags)) {
>   dev_err(>dev, "of_i2c: invalid addr=%x on %s\n",
> - info.addr, node->full_name);
> + addr, node->full_name);
>   return ERR_PTR(-EINVAL);
>   }
>  
> 

Reviewed-by: Vladimir Zapolskiy 
Fixes: b4e2f6ac1281 ("i2c: apply DT flags when probing")

Thank you for the fix.

--
With best wishes,
Vladimir

[PATCH] i2c: print correct device invalid address

[John Garry]

In of_i2c_register_device(), when the check for
device address validity fails we print the info.addr,
which has not been assigned properly.

Fix this by printing the actual invalid address.

Signed-off-by: John Garry 

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index cf9e396..03cfcdd 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1708,7 +1708,7 @@ static struct i2c_client *of_i2c_register_device(struct 
i2c_adapter *adap,
 
if (i2c_check_addr_validity(addr, info.flags)) {
dev_err(>dev, "of_i2c: invalid addr=%x on %s\n",
-   info.addr, node->full_name);
+   addr, node->full_name);
return ERR_PTR(-EINVAL);
}
 
-- 
1.9.1

[PATCH] i2c: print correct device invalid address

[John Garry]

In of_i2c_register_device(), when the check for
device address validity fails we print the info.addr,
which has not been assigned properly.

Fix this by printing the actual invalid address.

Signed-off-by: John Garry 

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index cf9e396..03cfcdd 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1708,7 +1708,7 @@ static struct i2c_client *of_i2c_register_device(struct 
i2c_adapter *adap,
 
if (i2c_check_addr_validity(addr, info.flags)) {
dev_err(>dev, "of_i2c: invalid addr=%x on %s\n",
-   info.addr, node->full_name);
+   addr, node->full_name);
return ERR_PTR(-EINVAL);
}
 
-- 
1.9.1